Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 04 May 2023 09:51:15 +0200
Message-ID: <87ild8mt58.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Ruliang Lin <u202112092@hust.edu.cn>
Cc:     Daniel Mack <zonque@gmail.com>, Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>,
        Karsten Wiese <fzu@wemgehoertderstaat.de>,
        hust-os-kernel-patches@googlegroups.com,
        Dongliang Mu <dzm91@hust.edu.cn>,
        Daniel Mack <daniel@caiaq.org>,
        Jaroslav Kysela <perex@suse.cz>, alsa-devel@alsa-project.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sound: caiaq: input: Add error handling for unsupported input methods in `snd_usb_caiaq_input_init`
In-Reply-To: <20230504065054.3309-1-u202112092@hust.edu.cn>
References: <20230504065054.3309-1-u202112092@hust.edu.cn>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Thu, 04 May 2023 08:50:53 +0200,
Ruliang Lin wrote:
> 
> Smatch complains that:
> snd_usb_caiaq_input_init() warn: missing error code 'ret'
> 
> This patch adds a new case to handle the situation where the 
> device does not support any input methods in the 
> `snd_usb_caiaq_input_init` function. It returns an `-EINVAL` error code 
> to indicate that no input methods are supported on the device.
> 
> Fixes: 523f1dce3743 ("[ALSA] Add Native Instrument usb audio device support")
> Signed-off-by: Ruliang Lin <u202112092@hust.edu.cn>
> Reviewed-by: Dongliang Mu <dzm91@hust.edu.cn>
> ---
> The issue is found by static analyzer. The patched code has passed
> Smatch checker, but remains untested on real device.

Thanks, applied.


Takashi