Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: i56a14606:Fastmail
User-Agent: Cyrus-JMAP/3.9.0-alpha0-386-g2404815117-fm-20230425.001-g24048151
Mime-Version: 1.0
Message-Id: <c99babb3-532a-4d00-876c-3c316b456325@app.fastmail.com>
In-Reply-To: <8ce93998-84c3-0640-a6e1-76ff17b3953c@linaro.org>
References: <20230504033726.93-1-ychuang570808@gmail.com>
 <20230504033726.93-2-ychuang570808@gmail.com>
 <8ce93998-84c3-0640-a6e1-76ff17b3953c@linaro.org>
Date:   Thu, 04 May 2023 09:49:18 +0200
From:   "Arnd Bergmann" <arnd@arndb.de>
To:     "Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>,
        "Jacky Huang" <ychuang570808@gmail.com>,
        "Rob Herring" <robh+dt@kernel.org>,
        krzysztof.kozlowski+dt@linaro.org, "Lee Jones" <lee@kernel.org>,
        "Michael Turquette" <mturquette@baylibre.com>,
        "Stephen Boyd" <sboyd@kernel.org>,
        "Philipp Zabel" <p.zabel@pengutronix.de>,
        "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
        "Jiri Slaby" <jirislaby@kernel.org>,
        "Tomer Maimon" <tmaimon77@gmail.com>,
        "Catalin Marinas" <catalin.marinas@arm.com>,
        "Will Deacon" <will@kernel.org>
Cc:     devicetree@vger.kernel.org, linux-clk@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-serial@vger.kernel.org, schung@nuvoton.com,
        mjchen@nuvoton.com, "Jacky Huang" <ychuang3@nuvoton.com>
Subject: Re: [PATCH v9 01/10] arm64: Kconfig.platforms: Add config for Nuvoton MA35
 platform
Content-Type: text/plain
Precedence: bulk

On Thu, May 4, 2023, at 08:32, Krzysztof Kozlowski wrote:
> On 04/05/2023 05:37, Jacky Huang wrote:
>> From: Jacky Huang <ychuang3@nuvoton.com>
>> 
>> Add ARCH_NUVOTON configuration option for Nuvoton MA35 family SoCs.
>> 
>> Signed-off-by: Jacky Huang <ychuang3@nuvoton.com>
>> ---
>>  arch/arm64/Kconfig.platforms | 9 +++++++++
>>  1 file changed, 9 insertions(+)
>> 
>> diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
>> index 89a0b13b058d..c1f277c05569 100644
>> --- a/arch/arm64/Kconfig.platforms
>> +++ b/arch/arm64/Kconfig.platforms
>> @@ -236,6 +236,15 @@ config ARCH_NPCM
>>  	  General support for NPCM8xx BMC (Arbel).
>>  	  Nuvoton NPCM8xx BMC based on the Cortex A35.
>>  
>> +config ARCH_NUVOTON
>
> Either this should be ARCH_MA35 or you should integrate it with NPCM.
> ARCH_NUVOTON means all Nuvoton platforms.

I'd go with two separate Kconfig options here (ARCH_MA35 and ARCH_NPCM)
for arm64, but keep the shared arch/arm64/boot/dts/nuvoton directory,
I think that fits most closely what we do on other targets, and there
is apparently very little sharing of IP blocks between npcm and ma35,
if any.

      Arnd