Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <37f089fd-ff1a-1008-1004-f6c70a46c3bc@oracle.com>
Date:   Thu, 4 May 2023 09:19:10 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [PATCH RFC 16/16] nvme: Support atomic writes
Content-Language: en-US
To:     Bart Van Assche <bvanassche@acm.org>, axboe@kernel.dk,
        kbusch@kernel.org, hch@lst.de, sagi@grimberg.me,
        martin.petersen@oracle.com, djwong@kernel.org,
        viro@zeniv.linux.org.uk, brauner@kernel.org, dchinner@redhat.com,
        jejb@linux.ibm.com
Cc:     linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-nvme@lists.infradead.org, linux-scsi@vger.kernel.org,
        linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
        linux-security-module@vger.kernel.org, paul@paul-moore.com,
        jmorris@namei.org, serge@hallyn.com,
        Alan Adamson <alan.adamson@oracle.com>
References: <20230503183821.1473305-1-john.g.garry@oracle.com>
 <20230503183821.1473305-17-john.g.garry@oracle.com>
 <ab663865-9099-8f6b-de1e-30c1356d5078@acm.org>
From:   John Garry <john.g.garry@oracle.com>
Organization: Oracle Corporation
In-Reply-To: <ab663865-9099-8f6b-de1e-30c1356d5078@acm.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dWMydlQvY3pKbkloTitHeks1TjJIVTFuNWkxSjJLWkU4ZHMzbU96eHRYTlJ1?=
 =?utf-8?B?VCtOQnROc3pYN2tzWHYzMWRnSVVFb05MOWhTRXNhZFdTaUxIWjYvWU9FOGxX?=
 =?utf-8?B?cnNQNVVVQXlvSmRvcGFhVGhjQVdnRGl1ZUVubjkxcEZRTXZhWmh0Wjkrdk9L?=
 =?utf-8?B?a2VjUjlkZ0YrV3Q5UWlsb1pZNktxRERyQ1ZOSVZab3ZHd2tXZnl1eThTRUFl?=
 =?utf-8?B?ZFhwZ1gyN1pEczkxbmlaOWtHdnEwY0l3STV4VGc0Y2w1bDd1SHJ0SXl6Z3hH?=
 =?utf-8?B?YitybjNoYnh5b0NuTWl4eXhMa0xrQnVLNzE2R0JMSm0welRmdlYyYTFrSElj?=
 =?utf-8?B?Zk5xRXhVaTRMbDI2K2N0L0hXY2pzaWJQM1M5b01JZE55cDNxR2JWS3gwd0xm?=
 =?utf-8?B?U0F6RDlBTjE0N2xtY3Y1dXA1OVowclpuekZaVlJ4cml0cndwRWFWTU00bHpJ?=
 =?utf-8?B?ZHY0M1RJRHRGdEhualBzK3VpWWFuQ092U2JNS2lYcW9XbThyRGxzdW5oZlBo?=
 =?utf-8?B?MWtLL0YvSVZQVHBLMmxXL1pUL3JuNmtiSGdqeXVPSWh4QitxMTl1UTc3Rnd6?=
 =?utf-8?B?cGV1ZUNRL2dZSUlGUU9sOGJER2kzVTlUZ05lOEJzMjZ2RDliMHhJUGhDVlBH?=
 =?utf-8?B?YlRCWWtGNXZVUHNqTWNHWm1wN0JtWHd6Yy9JZEJzcFF3M3ZJeVRjMm5mUHhW?=
 =?utf-8?B?MHpYQVE2SFFaRjE1VGJBWThhSlRSRWZGMG9yV0lUR1FKVFd1N1NVKzBpbktZ?=
 =?utf-8?B?Q3ZOTkNTRWpaSy9VY0JUeVhDZnlwZ3I5TzdiMVd3Z1VmTkJJYUVkQy9ZNXpt?=
 =?utf-8?B?eklFYThocHRrZzhjQUhjdE1kaGF6aWR4RVBKMW9RUWw3SUxUZTdhVllPN0Ns?=
 =?utf-8?B?VDhKd0tiVkVtNUhuS3VJQ2RDRHUwQXArNHRnM0tvQXlYbS9UMExpWEdBMUdU?=
 =?utf-8?B?Ui95UXVGUUJwY01XaEtDMENRdUNZTHRWbjV4QThheldhSmVwUXVkZHhvS25U?=
 =?utf-8?B?MmVEOGFDamxrUVJWNDBaWkZZNHovSnZpUXZ1T1dOdXdBZWZRdGZJbGxacTNP?=
 =?utf-8?B?K0h4UmZqYk55YzBuRDg1VFNscmwwcEtFbTJZUC82VE5Qc1kzRlhldUdYZEZy?=
 =?utf-8?B?SjVDeHdLU011OGdFL21ZL3gvSkt6aStNeTZXei9TY1VoU3p3NUZLY0pvdi9K?=
 =?utf-8?B?OTZpQUJ6aWhZeTZHMjYrSWlVU1N3TmJoWk01bVZVRWtTSExaU2wxUWU2dFRj?=
 =?utf-8?B?NFkya3RJaTRmK2ZPOFYxOVRoc3JZVVdxSWhqbG82NE5hSlV0cm1UVGo5SkNW?=
 =?utf-8?B?QW82QlRuNmlXZXVVVlVwL29sL2RvQkxXanhpVzA2Wmg3RERJcmltVHhVdGlm?=
 =?utf-8?B?MVVyM3d2bVF0VmRiL0dFYVI5akdScngxQmhaQWVVcFZ3QXJ0YnRrVjh5M2Rk?=
 =?utf-8?B?RWxpNGwyVktISXNwZW44S0ZQN0RHM3lvZHlVaUtZdUE1VEdiMXBYZkIyU0Er?=
 =?utf-8?B?eGhhTFZGRytYeWp2Z3RXMzlhalJEcVlUd3lhQmdzYmU1YjduWCt2bDNKZzVl?=
 =?utf-8?B?QU0vMWk2YjFFL05kWXBLaTZodGhkWVVTd2F4RmFmakdEeUdjQWE2eTBLKzFu?=
 =?utf-8?B?ZWgyMzdYSjFhZVZieUJTVWEzc2E2T09oSy9BRXdTZjBHSkJuTEdUQndvOGNw?=
 =?utf-8?B?RzNldlBiSUZWUUV4U3V4QS9MdzZVaXZaaU1Uc1NFcnI3S1gzQ1FDUUNwNGxO?=
 =?utf-8?B?TjRiK01mdFgxcXNoc0hyalRyaEJEazRhOXpleERudGdEVGlUSmducjJkNU8w?=
 =?utf-8?B?bm9wR3hmVWQ2VnBMM3ZIOHo5ODRhTk0zZmpNZk9qd3BvVGtCSFdVSDg2aVl5?=
 =?utf-8?B?VFNWbVBVTjFxRnB5akVSVS83S1h6dVc1TkIvVVJxK2IvajcxT0E1NjU5aXZR?=
 =?utf-8?B?MVNrcWtKdmZqZEFxUjlFUWV0YUUxTzM2S1hTQTBsdk01RlA5R1p4VFd1bUdR?=
 =?utf-8?B?NERDV2RlYXNXNHQ4M2NKaXF3azBJRkhrVDUyQThXMXhMM09MQWswQXQ5RmVv?=
 =?utf-8?B?ZWs4Smxub05XcEtlTkUwMHBZbTYxM0c4YXErREZHUXp3UUtjTzNsdEhiVmR6?=
 =?utf-8?B?OHhSODNTVTc1M3IzejIxVUVVWXo2eGtWYUpVRUhGMFptSERFdmsyNG52R3hx?=
 =?utf-8?B?Z1E9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?bkJBdlNuWmQ2MkxRTSt4UUdjY01ZWERCcUJMbEI3bUMrWk1zVEJOSzRHeXll?=
 =?utf-8?B?Q2dXbi9OUlRxUFU5S2pzZlQzQXZvd1FOZDBjSTB0czByalZKL2poRzZWaWdQ?=
 =?utf-8?B?ckdNOXFKWlFVWnpDRnVvZVNLQ053dURSZDFySzFpb2tUeUc3TERSSC9qcHlO?=
 =?utf-8?B?eWVnNjhjanFYSE1UMEVWNGVwWmdDTzk3cWE1WVRUMFRYaFQ1WkQ3WjVCV2pi?=
 =?utf-8?B?dHV3c3lqNlkyN21GdUQ0a3I4Y2NnOWFSYm1FQ1grQXFDOFlYcmFBTkVvdmdw?=
 =?utf-8?B?U1NCRVp4Q1h3TzllNzROYXh6ZzdnRXdCMXFvMUxGQVFZNG5NU1BmY3ZxZWxq?=
 =?utf-8?B?OE4yVnZuTnJVQVl4eCtGSFBwOEk2Z3dvc2FKUDJnRW9mZVljZThFd3k4UUk5?=
 =?utf-8?B?d3ZQVXhJYk9jQmJ5eExZSVpWdmJxYXUrYmczRlFRY0Rleno3UWkwd3hxU2d3?=
 =?utf-8?B?ZG95MXlpOE5SNDRYaTFRalpod0R5emUzN0FGcjF5c2ZRQ09tQlkrZnVzV3VM?=
 =?utf-8?B?WE5XZUduSXVLL3cyWTJCRERCWjJaakdLL3ZaM1JxS0hra0dnVzl0Y3RjdVBT?=
 =?utf-8?B?VnFET2dsREozUU1tZHZwN3dSWkRGNVJSRHlacHpIOTVCOHE4WFhvaUVTR1hO?=
 =?utf-8?B?aGlrR1FFMW0veWU1YWZWdVEzUG1Ta1dmMUErMnd0Ky92NDVraDFRWDVJR25y?=
 =?utf-8?B?RTFlV2x0RUQ2MXp3a3hlajhFUHJ0TW9nY1RkTjM4VnhXblRmSktacjhtMDRn?=
 =?utf-8?B?SG5aQnp4YWEzbDVRNlg4aEFKaXd6QlJrWm52Qk1IbkRmK3JKbXdMQnFpcDl5?=
 =?utf-8?B?T3lVL29DK2hidWtzNUQwRGgvSGErcFBCL09vd28zVWlyTmNCVzhlWUFZbHJ5?=
 =?utf-8?B?L0h0bXhVcmc5ZEdPUGUzTjlSSmxVY0ZvR2hEa0VINnZ4NXViZ1FZNjZLOWFr?=
 =?utf-8?B?ek1qYXJYWUJNa0puMW5CdlNMYTcwTjVaSHlGL2N1cGJZa0lxTzZSZytlQzJp?=
 =?utf-8?B?R0JHUTV3RDdWTHN4U1phemZpaDkwMGpKTlQ2WmF0Q25HcGlrNitzZ0tFOHlx?=
 =?utf-8?B?eHJnUGdOYmhBb2UxWTR5b2Y5RjlPa0pDWDlscnZKU01HMVdmbXVhS0xraEhs?=
 =?utf-8?B?SHJSK1FGZ1Z6R0ovQnlBNDN2SlU1NkgvSXltT2VGTXRHRjdiZDRCakdNNFZW?=
 =?utf-8?B?YlVvenFkUEwzYk0xVmdybmw5NThVZTdnNzlLdjhMa1FRVUM1OHM5OWNURU5s?=
 =?utf-8?B?WjFCemRvMTBJOEdsdHdVM3cydTU1aFpRR3FPZElsaUY5MkRDWjJ6VlhjOWxJ?=
 =?utf-8?B?ZzYxV1BQZEtEVThzUlFySDl6b2J3NDVXTDlGZzczczloU3VmK1RRZm9wRWwv?=
 =?utf-8?B?ZUJEUy9oalhlSnRzTS9aS2pNbUpONG9WNEZMdDBaejAxZnJxUDNOSFRnNWxE?=
 =?utf-8?B?RlhhMlowcXdEdUxyRnFlR3RWdWV0c2FOQk5Velp2dGk4TExIRElrZFRVZnJU?=
 =?utf-8?B?ZE4vVWZqR09SNE5HYkhIcGZMN1dIRmd1N1Z2V2JSRmY0NnQzeW0vQlJ0ZVpO?=
 =?utf-8?B?SkxUdz09?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e4a180d4-dfa2-47a3-8a5a-08db4c783ff5
X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2023 08:19:15.7930
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: xYIme9gegT1yVLKnD7fJlgQZiiWFS5TgZCKcLBx4l7dXtJRjZx8OoJNCYDwTV7dLEqbT746SJngEzQw/9VXgVQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB4534
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-05-04_04,2023-05-03_01,2023-02-09_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0
 mlxlogscore=955 spamscore=0 phishscore=0 adultscore=0 mlxscore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2303200000 definitions=main-2305040067
X-Proofpoint-GUID: W82vmXTZGG0E0PqNb_mTM5EOSc8QmbVG
X-Proofpoint-ORIG-GUID: W82vmXTZGG0E0PqNb_mTM5EOSc8QmbVG
X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 03/05/2023 19:49, Bart Van Assche wrote:
> On 5/3/23 11:38, John Garry wrote:
>> +            if (!(boundary & (boundary - 1))) {
> 
> Please use is_power_of_2() instead of open-coding it.

Sure, that can be changed, thanks