Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 4 May 2023 10:15:17 +0200
From:   Juri Lelli <juri.lelli@redhat.com>
To:     Peter Zijlstra <peterz@infradead.org>
Cc:     Ingo Molnar <mingo@kernel.org>, Qais Yousef <qyousef@layalina.io>,
        Waiman Long <longman@redhat.com>, Tejun Heo <tj@kernel.org>,
        Zefan Li <lizefan.x@bytedance.com>,
        Johannes Weiner <hannes@cmpxchg.org>,
        Hao Luo <haoluo@google.com>,
        Dietmar Eggemann <dietmar.eggemann@arm.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        linux-kernel@vger.kernel.org, luca.abeni@santannapisa.it,
        claudio@evidence.eu.com, tommaso.cucinotta@santannapisa.it,
        bristot@redhat.com, mathieu.poirier@linaro.org,
        cgroups@vger.kernel.org,
        Vincent Guittot <vincent.guittot@linaro.org>,
        Wei Wang <wvw@google.com>, Rick Yiu <rickyiu@google.com>,
        Quentin Perret <qperret@google.com>,
        Heiko Carstens <hca@linux.ibm.com>,
        Vasily Gorbik <gor@linux.ibm.com>,
        Alexander Gordeev <agordeev@linux.ibm.com>,
        Sudeep Holla <sudeep.holla@arm.com>
Subject: Re: [PATCH v2 5/6] sched/deadline: Create DL BW alloc, free & check
 overflow interface
Message-ID: <ZFNplb0IYONNPtAU@localhost.localdomain>
References: <20230503072228.115707-1-juri.lelli@redhat.com>
 <20230503072228.115707-6-juri.lelli@redhat.com>
 <20230504062359.GE1734100@hirez.programming.kicks-ass.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230504062359.GE1734100@hirez.programming.kicks-ass.net>
Precedence: bulk

On 04/05/23 08:23, Peter Zijlstra wrote:
> On Wed, May 03, 2023 at 09:22:27AM +0200, Juri Lelli wrote:
> > From: Dietmar Eggemann <dietmar.eggemann@arm.com>
> > 
> > Rework the existing dl_cpu_busy() interface which offers DL BW overflow
> > checking and per-task DL BW allocation.
> > 
> > Add dl_bw_free() as an interface to be able to free DL BW.
> > It will be used to allow freeing of the DL BW request done during
> > cpuset_can_attach() in case multiple controllers are attached to the
> > cgroup next to the cpuset controller and one of the non-cpuset
> > can_attach() fails.
> > 
> > dl_bw_alloc() (and dl_bw_free()) now take a `u64 dl_bw` parameter
> > instead of `struct task_struct *p` used in dl_cpu_busy().  This allows
> > to allocate DL BW for a set of tasks too rater than only for a single
> > task.
> > 
> 
> Changlog fails the 'why' test.
> 

Dietmar, if you could please add (or rework) the 'why' as a reply to
this email, I can fold in v3.

Thanks!