Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp244265rwr; Thu, 4 May 2023 02:15:21 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4PTVO4Tn9vyAdJijQnhJe8dVE3iY/C5VEvaS6Ol8EQjF+teIIyV+g5GRVq68FFZnbf1eQs X-Received: by 2002:a05:6a21:3390:b0:e9:5b0a:deff with SMTP id yy16-20020a056a21339000b000e95b0adeffmr2281834pzb.22.1683191721459; Thu, 04 May 2023 02:15:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683191721; cv=none; d=google.com; s=arc-20160816; b=PGpZBOxqFCju8ub0DLpWb/kqAvr70Z4KGic1KadLJ1S7Zaw6nkkPdbM5BKCoa846Io kLojGEgoSHAqVSqux29i5D2hsrI285YkR1lna1wL/oE8xPDJehbLG1lV2C1Ak/oqa6Ij 92nZhzNSTfVKOplqqSdPckNRBk0IKrdSCrd9hS0d7VGU2Vcs2f9S0477Zl8amQ3dwBl5 fZMHV4zQekrG25FLUbdQq1/RoX9CGIQMhEWwTxVAIJYfmbCck42yILys9QWJ+GMHipCm sxE0pH4ydm9Rutbj/NICiI75PG2x6nJS4WcelAcxPyQvw8lGCVQ9ZqHtVfd7DslF6V3+ TkdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature:dkim-signature; bh=zg7g2BOvhmWFc3dhiKasbnCc51IssmQS3By3r+3Vyvc=; b=QGaQ0odREzR7blOeTXi1tDL8I1uOnfVEE7CdmJ9hvL5KSEX+P+/c7JsNCSQvXz0TuZ 8ejUqTVm24w85oNQ5H7WENCcdblEQfXxRTyJ1vzRtOOqo5e3Zr0hVORg/sAIujTxUAw6 nCcWs58z402eTgmlrFl7cdQkx841nmXtRRSZ3kCkNcYlc2ziKhRh7IfNnzN7w3uewcnV hgE6DpaugW5/+v7/LfRX+3FSxQHRxKW2uegK9HCPXJ7rSkFAoceX9OJBlAMgaR+8ruzN neZNIfGarEs3LKyyFoJHPCe7O6rvh9/DyH4RPdJKTAL9X7GsKzfiZbJ/QhLDc5Ro8gOV hZSg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b="MC29e/jx"; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id bm18-20020a656e92000000b004fba0f483c8si36631085pgb.185.2023.05.04.02.15.07; Thu, 04 May 2023 02:15:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b="MC29e/jx"; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230224AbjEDJNH (ORCPT + 99 others); Thu, 4 May 2023 05:13:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37142 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229900AbjEDJNG (ORCPT ); Thu, 4 May 2023 05:13:06 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0271640E0 for ; Thu, 4 May 2023 02:13:04 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 7191433931; Thu, 4 May 2023 09:13:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1683191583; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=zg7g2BOvhmWFc3dhiKasbnCc51IssmQS3By3r+3Vyvc=; b=MC29e/jxsi3vii+r1q6FTuTeZ9+h8d2o2nRI1YT0GHIb8b+3hY5D/cK/bB6+235xHyv3Zk xmwAzcsL6Z7Ut13HNOfM6sqA3t1xUUIR+PeeHvsazShHC9J0k3sxzDInfOjw9e1sByNXkN A+6XzUMKhiPoDYHdkpvkkuQ/MXa+cHc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1683191583; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=zg7g2BOvhmWFc3dhiKasbnCc51IssmQS3By3r+3Vyvc=; b=ACIw7b/wmBFXaY6PHIuXXxbUkH5YR7XgPgF79dscbQGvzVoOyB1BddNCfwMy2WE9gsV7Mt C3T5oV8jOfQ8LMCQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 6127013444; Thu, 4 May 2023 09:13:03 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id WK+qFx93U2TVTwAAMHmgww (envelope-from ); Thu, 04 May 2023 09:13:03 +0000 From: Daniel Wagner To: linux-nvme@lists.infradead.org Cc: linux-kernel@vger.kernel.org, Chaitanya Kulkarni , Sagi Grimberg , Hannes Reinecke , James Smart , Daniel Wagner Subject: [RFC v3 0/9] Unifying fabrics drivers Date: Thu, 4 May 2023 11:12:50 +0200 Message-Id: <20230504091259.29100-1-dwagner@suse.de> X-Mailer: git-send-email 2.40.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I've rebased on nvme-6.4 and gave it a bit of testing. Up to the last patch it seems to work fine, at least blktests doesn't trigger any errors. I've tried to split the pure moving code around part from the part where we need to change some code. That means the last two patches highlight the problems I run into with this attempt to implement the setup_transport() callback changes: v2: - move the complete ctrl state machine to fabrics.c - https://lore.kernel.org/linux-nvme/20230306093244.20775-1-dwagner@suse.de/ v1: - https://lore.kernel.org/linux-nvme/20230301082737.10021-1-dwagner@suse.de/ Daniel Wagner (9): nvme-rdma: stream line queue functions arguments nvme-rdma: factor rdma specific queue init code out nvme-tcp: move error and connect work to nvme_ctrl nvme-rdma: use error and connect work from nvme_ctrl nvme-fabrics: add fabric state machine nvme-tcp: replace state machine with generic one nvme-rdma: replace state machine with generic one nvme: move queue flags to middle layer nvme: introduce setup_transport() drivers/nvme/host/fabrics.c | 513 +++++++++++++++++++++++++ drivers/nvme/host/fabrics.h | 24 ++ drivers/nvme/host/nvme.h | 19 + drivers/nvme/host/rdma.c | 720 ++++++++++-------------------------- drivers/nvme/host/tcp.c | 706 ++++++++--------------------------- 5 files changed, 913 insertions(+), 1069 deletions(-) -- 2.40.0