Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 4 May 2023 18:08:46 +0900
From:   Greg KH <gregkh@linuxfoundation.org>
To:     Peng Fan <peng.fan@nxp.com>
Cc:     "Peng Fan (OSS)" <peng.fan@oss.nxp.com>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "krzysztof.kozlowski+dt@linaro.org" 
        <krzysztof.kozlowski+dt@linaro.org>,
        "rafael@kernel.org" <rafael@kernel.org>,
        "andriy.shevchenko@linux.intel.com" 
        <andriy.shevchenko@linux.intel.com>,
        "hdegoede@redhat.com" <hdegoede@redhat.com>,
        "jgg@ziepe.ca" <jgg@ziepe.ca>,
        "saravanak@google.com" <saravanak@google.com>,
        "keescook@chromium.org" <keescook@chromium.org>,
        "tglx@linutronix.de" <tglx@linutronix.de>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "abel.vesa@linaro.org" <abel.vesa@linaro.org>
Subject: Re: [PATCH] devres: provide API devm_kstrndup
Message-ID: <2023050445-blizzard-splendid-cf1c@gregkh>
References: <20230504075754.372780-1-peng.fan@oss.nxp.com>
 <2023050413-margin-devotedly-468d@gregkh>
 <DU0PR04MB9417B76952E9B21E89946C09886D9@DU0PR04MB9417.eurprd04.prod.outlook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <DU0PR04MB9417B76952E9B21E89946C09886D9@DU0PR04MB9417.eurprd04.prod.outlook.com>
Precedence: bulk

On Thu, May 04, 2023 at 08:59:41AM +0000, Peng Fan wrote:
> Hi Greg,
> 
> > -----Original Message-----
> > From: Greg KH <gregkh@linuxfoundation.org>
> > Sent: 2023年5月4日 16:58
> > To: Peng Fan (OSS) <peng.fan@oss.nxp.com>
> > Cc: robh+dt@kernel.org; krzysztof.kozlowski+dt@linaro.org;
> > rafael@kernel.org; andriy.shevchenko@linux.intel.com;
> > hdegoede@redhat.com; jgg@ziepe.ca; saravanak@google.com;
> > keescook@chromium.org; tglx@linutronix.de; linux-kernel@vger.kernel.org;
> > abel.vesa@linaro.org; Peng Fan <peng.fan@nxp.com>
> > Subject: Re: [PATCH] devres: provide API devm_kstrndup
> > 
> > On Thu, May 04, 2023 at 03:57:54PM +0800, Peng Fan (OSS) wrote:
> > > From: Peng Fan <peng.fan@nxp.com>
> > >
> > > This patch introduces devm_kstrndup API so that the device's driver
> > > can allocate memory and copy string.
> > >
> > > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > > ---
> > >  drivers/base/devres.c  | 28 ++++++++++++++++++++++++++++
> > > include/linux/device.h |  1 +
> > >  2 files changed, 29 insertions(+)
> > 
> > We can not add apis with no users, please submit this at the same time a
> > driver needs it.
> > 
> > And what driver would need to copy a string?
> 
> https://lore.kernel.org/all/20230504085506.504474-1-peng.fan@oss.nxp.com/

Please never add new module parameters, ESPECIALLY for a driver.  This
is not the 1990's anymore, please use the correct apis instead (hint,
sysfs, configfs, DT, etc.)

> Should I submit V2 with the upper patch in a patchset?

I can't take this as-is, for the reason I said, so yes.  And again, your
dependant patch is not ok either, so I don't think this is needed
anymore.

thanks,

greg k-h