Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 4 May 2023 06:55:37 -0500
From:   Nishanth Menon <nm@ti.com>
To:     Sinthu Raja <sinthu.raja@mistralsolutions.com>
CC:     Tero Kristo <kristo@kernel.org>, Rob Herring <robh+dt@kernel.org>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        Sinthu Raja <sinthu.raja@ti.com>,
        Thejasvi Konduru <t-konduru@ti.com>
Subject: Re: [PATCH V5 1/2] arm64: dts: ti: k3-j721s2: fix wkup pinmux range
Message-ID: <20230504115537.aqdlcz3233eyu56q@pounce>
References: <20230504073432.6438-1-sinthu.raja@ti.com>
 <20230504073432.6438-2-sinthu.raja@ti.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230504073432.6438-2-sinthu.raja@ti.com>
Precedence: bulk

minor comment: $subject: s/fix/Fix - Vignesh might fix it up prior to
picking up the series.. but anyways.. just making a side note.

On 13:04-20230504, Sinthu Raja wrote:
> From: Sinthu Raja <sinthu.raja@ti.com>
> 
> The WKUP_PADCONFIG register region in J721S2 has multiple non-addressable
> regions, accordingly split the existing wkup_pmx region as follows to avoid
> the non-addressable regions and include the rest of valid WKUP_PADCONFIG
> registers. Also update references to old nodes with new ones.
> 
> wkup_pmx0 -> 13 pins (WKUP_PADCONFIG 0 - 12)
> wkup_pmx1 -> 11 pins (WKUP_PADCONFIG 14 - 24)
> wkup_pmx2 -> 72 pins (WKUP_PADCONFIG 26 - 97)
> wkup_pmx3 -> 1 pin (WKUP_PADCONFIG 100)
> 
> Fixes: b8545f9d3a54 ("arm64: dts: ti: Add initial support for J721S2 SoC")
> Signed-off-by: Thejasvi Konduru <t-konduru@ti.com>
> Signed-off-by: Sinthu Raja <sinthu.raja@ti.com>
> ---

is this mcu only ?

Could you provide a link to the output of:
$ cat /sys/kernel/debug/pinctrl/*/pins

Before and after the fixup? gist.github.com or some similar pastebin
link to the log will suffice.

[..]


-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D