Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Ding, Shenghao" <shenghao-ding@ti.com>
To:     Mark Brown <broonie@kernel.org>
CC:     "lgirdwood@gmail.com" <lgirdwood@gmail.com>,
        "perex@perex.cz" <perex@perex.cz>,
        "pierre-louis.bossart@linux.intel.com" 
        <pierre-louis.bossart@linux.intel.com>,
        "Lu, Kevin" <kevin-lu@ti.com>,
        "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Xu, Baojun" <x1077012@ti.com>, "Gupta, Peeyush" <peeyush@ti.com>,
        "Navada Kanyana, Mukund" <navada@ti.com>,
        "gentuser@gmail.com" <gentuser@gmail.com>,
        "Shenghao Ding" <13916275206@139.com>
Subject: RE: [EXTERNAL] Re: [PATCH v1 3/5] firmware: tasdevice_fmw: tasdevice
 firmware loading lib
Thread-Topic: [EXTERNAL] Re: [PATCH v1 3/5] firmware: tasdevice_fmw: tasdevice
 firmware loading lib
Thread-Index: AQHZfVYbZ97DiMVErUaDioHaf2zIQa9KHCLA
Date:   Thu, 4 May 2023 13:55:21 +0000
Message-ID: <82b9ac35631a4c4993dd2cd75f137273@ti.com>
References: <20230502053235.27066-1-13916275206@139.com>
 <ZFGqhM0VYFdorkRa@finisterre.sirena.org.uk>
In-Reply-To: <ZFGqhM0VYFdorkRa@finisterre.sirena.org.uk>
Accept-Language: zh-CN, en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Precedence: bulk

Hi Broonie
Thanks for your comments.
In fact, we have a dilemma whether to put the code into firmware folder or =
sound/soc/codecs.
As you know, most cases are audio-related application,  such as a pure audi=
o device or=20
audio2haptics device, keeping the tasdevice-firmware lib into sound/soc/cod=
ecs would make sense.
However, in other cases, tasdevice(such as tas2781) can be used  as pure ha=
ptic to drive the Motor.
moving the lib into firmware folder would make sense, although such an appl=
ication is a niche.
Would you be so kind and give some comments on it? Thanks.

BR
Shenghao Ding
-----Original Message-----
From: Mark Brown <broonie@kernel.org>=20
Sent: Wednesday, May 3, 2023 8:28 AM
To: Shenghao Ding <13916275206@139.com>
Cc: lgirdwood@gmail.com; perex@perex.cz; pierre-louis.bossart@linux.intel.c=
om; Lu, Kevin <kevin-lu@ti.com>; Ding, Shenghao <shenghao-ding@ti.com>; als=
a-devel@alsa-project.org; linux-kernel@vger.kernel.org; Xu, Baojun <x107701=
2@ti.com>; Gupta, Peeyush <peeyush@ti.com>; Navada Kanyana, Mukund <navada@=
ti.com>; gentuser@gmail.com
Subject: [EXTERNAL] Re: [PATCH v1 3/5] firmware: tasdevice_fmw: tasdevice f=
irmware loading lib

On Tue, May 02, 2023 at 01:32:35PM +0800, Shenghao Ding wrote:
> Create tasdevice firmware lib.

>  drivers/firmware/Kconfig            |    1 +
>  drivers/firmware/Makefile           |    1 +
>  drivers/firmware/ti/Kconfig         |    5 +
>  drivers/firmware/ti/Makefile        |    3 +
>  drivers/firmware/ti/tasdevice-fmw.c | 2380=20
> +++++++++++++++++++++++++++
>  5 files changed, 2390 insertions(+)

Given how large this part of the code for these devices is it definitely ma=
kes sense to split it into a separate commit like you've done but are there=
 any non-audio devices in this series which will share the same firmware st=
yle?  If not then it probably makes sense to keep the code in sound/soc/cod=
ecs, though a separate file would still make sense.

There's some devices that do keep firmware interface code in the firmware d=
irectory but in those cases the devices have other, non-audio, functionalit=
y which also uses the firmware (eg, always on monitoring) but I've not seen=
 any of the tas devices like that.  If there are some then the split you've=
 made here makes sense.