Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 4 May 2023 09:22:39 -0500
From:   Nishanth Menon <nm@ti.com>
To:     Thejasvi Konduru <t-konduru@ti.com>
CC:     Tero Kristo <kristo@kernel.org>, Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        Andrew Davis <afd@ti.com>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        Apurva Nandan <a-nandan@ti.com>, Udit Kumar <u-kumar1@ti.com>
Subject: Re: [PATCH] arm64: dts: ti: k3-j784s4: Fix wakeup pinmux range and
 pinctrl node offsets
Message-ID: <20230504142239.hqhni2c52k3a3asz@prune>
References: <20230503083143.32369-1-t-konduru@ti.com>
 <20230503114625.gqnijd3bog5bwemz@parameter>
 <31b31af7-6c54-7d05-f7ef-fcceba48580e@ti.com>
 <20230504115207.h6trzy4mqjcbkcm3@comment>
 <67eccecb-f4a4-7f15-5316-27fd39e65b51@ti.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <67eccecb-f4a4-7f15-5316-27fd39e65b51@ti.com>
Precedence: bulk

On 17:40-20230504, Thejasvi Konduru wrote:
> 
> On 04/05/23 17:22, Nishanth Menon wrote:
> > On 14:36-20230504, Thejasvi Konduru wrote:
> > > On 03/05/23 17:16, Nishanth Menon wrote:
> > > > On 14:01-20230503, Thejasvi Konduru wrote:
> > > > > The wkup_pmx register region in j784s4 has multiple non-addressable
> > > > > regions, hence the existing wkup_pmx region is split as follows to
> > > > > avoid the non-addressable regions. The pinctrl node offsets are
> > > > > also corrected as per the newly split wkup_pmx* nodes.
> > > > > 
> > > > > wkup_pmx0 -> 13 pins (WKUP_PADCONFIG 0 - 12)
> > > > > wkup_pmx1 -> 11 pins (WKUP_PADCONFIG 14 - 24)
> > > > > wkup_pmx2 -> 72 pins (WKUP_PADCONFIG 26 - 97)
> > > > > wkup_pmx3 -> 1 pin (WKUP_PADCONFIG 100)
> > > > > 
> > > > > Fixes: 4664ebd8346a ("arm64: dts: ti: Add initial support for J784S4 SoC")
> > > > > Signed-off-by: Thejasvi Konduru <t-konduru@ti.com>
> > > > > ---
> > > > Could you provide a link to the output of:
> > > > $ cat /sys/kernel/debug/pinctrl/*/pins
> > > https://gist.github.com/thejasvikonduru/05b1a8e0fd8176116b7a3cc4e43b244a
> > Was this failing prior to this patch? Trying to understand the "Fix"
> > aspect of this patch.
> > 
> Yes,it was failing prior to this patch.
> 

next time some asks this question - give summary AND give a log. Even
better, please don't make folks even ask the question in the first
place by including the logs in the diffstat of the patch.

Please share the log to understand what kind of "failure" was occurring.

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D