Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <facc9800-6af4-5cb3-bd22-b22b2250090a@quicinc.com>
Date:   Thu, 4 May 2023 19:34:28 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [PATCH 0/4] venus: add support for 10 bit decoding
To:     Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
        Dikshita Agarwal <quic_dikshita@quicinc.com>,
        <linux-media@vger.kernel.org>, <stanimir.k.varbanov@gmail.com>,
        <agross@kernel.org>, <andersson@kernel.org>,
        <konrad.dybcio@linaro.org>, <mchehab@kernel.org>
CC:     <linux-kernel@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>
References: <1683196599-3730-1-git-send-email-quic_dikshita@quicinc.com>
 <8df7f24b-9dbe-4491-bcb1-f53021bb482f@linaro.org>
 <66b8e665-1038-127a-1f4f-20d8fe7bcd8e@linaro.org>
Content-Language: en-US
From:   Vikash Garodia <quic_vgarodia@quicinc.com>
In-Reply-To: <66b8e665-1038-127a-1f4f-20d8fe7bcd8e@linaro.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 5/4/2023 7:21 PM, Bryan O'Donoghue wrote:
> On 04/05/2023 14:49, Bryan O'Donoghue wrote:
>> On 04/05/2023 11:36, Dikshita Agarwal wrote:
>>> This series includes the changes to
>>>    - add V4L2_PIX_FMT_P010 as supported decoder format.
>>>    - consider dpb color format while calculating buffer
>>>      size for dpb buffers.
>>>    - update dpb and opb color format when bit depth
>>>      changes is detected, also update preferred color
>>>      format to P010 in this case.
>>>
>>> With this series, divided the previous version [1] into
>>> multiple patches as suggested in review comments.
>>>
>>> [1] 
>>> https://patchwork.linuxtv.org/project/linux-media/list/?series=10376
>>>
>>> Dikshita Agarwal (4):
>>>    venus: add support for V4L2_PIX_FMT_P010 color format
>>>    venus: update calculation for dpb buffers
>>>    venus: add handling of bit depth change from firmwar
>>>    venus: return P010 as preferred format for 10 bit decode
>>>
>>>   drivers/media/platform/qcom/venus/helpers.c        | 24 
>>> ++++++++++++++++++++++
>>>   drivers/media/platform/qcom/venus/hfi_plat_bufs.h  |  3 +++
>>>   .../media/platform/qcom/venus/hfi_plat_bufs_v6.c   |  8 +++++++-
>>>   drivers/media/platform/qcom/venus/vdec.c           | 16 
>>> +++++++++++++--
>>>   4 files changed, 48 insertions(+), 3 deletions(-)
>>>
>>
>> For future reference a series like this should:
>>
>> 1. Include a log of what changed between the last series and this
>> 2. Describe which comments you addressed
>>     I generally try to say
>>     "Added newline to dts - Konrad"
>>     "Sent the series as a -v3 - Bryan"
>>     etc
>> 3. Ideally provide a link to the previous series in
>>
>> https://lore.kernel.org/linux-arm-msm/1682492417-20496-1-git-send-email-quic_dikshita@quicinc.com/ 
>>
>> 4. Use versioning
>>     This set should be prefixed with "v2-0000-cover-letter" 
>> "v2-0001-add-support" etc
>>
>> "git format-patch mybase..targettip --cover-letter -v2"
>>
>> ---
>> bod
>
> Doh I see you did most of that - just missed the V2.
>
> Please remember to version your subsequent series. "git format-patch -v2"

Does this qualify for a version upgrade when a single patch is 
subsequently raised as series ? IMO, the link

to previous single patch in cover letter and then starting the series 
(as v0) seems to provide the required info.

>
> ---
> bod