Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <72f73a40-d793-11dd-af34-f1491312d3b5@meta.com>
Date:   Thu, 4 May 2023 07:29:14 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.10.1
Subject: Re: [PATCH bpf-next v5 1/2] bpf: Add bpf_task_under_cgroup() kfunc
To:     Feng zhou <zhoufeng.zf@bytedance.com>, martin.lau@linux.dev,
        ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org,
        song@kernel.org, yhs@fb.com, john.fastabend@gmail.com,
        kpsingh@kernel.org, sdf@google.com, haoluo@google.com,
        jolsa@kernel.org, davem@davemloft.net, edumazet@google.com,
        kuba@kernel.org, pabeni@redhat.com, mykolal@fb.com,
        shuah@kernel.org
Cc:     bpf@vger.kernel.org, linux-kernel@vger.kernel.org,
        netdev@vger.kernel.org, linux-kselftest@vger.kernel.org,
        yangzhenze@bytedance.com, wangdongdong.6@bytedance.com
References: <20230504031513.13749-1-zhoufeng.zf@bytedance.com>
 <20230504031513.13749-2-zhoufeng.zf@bytedance.com>
Content-Language: en-US
From:   Yonghong Song <yhs@meta.com>
In-Reply-To: <20230504031513.13749-2-zhoufeng.zf@bytedance.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ajdEbloxRS9tOEFmaVBMcnhxWHlnbXhoMmsvSyt3OEM2b2xWRzh0aWMvWlZp?=
 =?utf-8?B?OXdnckIzTmFnM2Z2azBjbC9ueUExdXB2NTAyUjlLQSt1YWRNMlVJb0E4V0x3?=
 =?utf-8?B?VkF4UlBJY3QrVWlNS0Fka1pVYUhGb3lCOHMrVWIzR0JOTTlEaDNwQWRuZkdV?=
 =?utf-8?B?bklwTEpJZjRuZDZEY0hDdWhjRzA2UFpoZjVxVmdlSFc5eXIrdHZtWXFFR2t3?=
 =?utf-8?B?ZTcvdG1MRmhmV29xYm9tci9WYnVHdnhkSzhuYXhTYkV5cEU2NUN6NWM1WnFO?=
 =?utf-8?B?MXh0TXNDdWg5QlhHeHNOT0VFSDVoajNDVUJ3SzMxRzlNUWUrMU1tc0RaQkVk?=
 =?utf-8?B?N2thZ0p4Slo2TkV4bEpibCtXRnZ2UndDMWpaczNJMWVYY0lPSFIwZDRwTi8w?=
 =?utf-8?B?QWpVMFIvTC9SV2hGdWw4SGZQOFlGVFZ6UnhXOW9sRDRsc2h3UGZFTTUrTFAr?=
 =?utf-8?B?OGNUUDB6RUF3NC9mZXJoa2E0amFUQU80cEhURlhPUHkrb2w5bmVRWVJ2NDM5?=
 =?utf-8?B?dlI3d2tSYjUrVHhXWEUyWjVnaG5XWXNVV3BuNm41N0xVOXVCNGZlYnRZZ2tN?=
 =?utf-8?B?SE90UHAzajAxTzdXSHZXdzZIZVRCN3Q2dUYvZFlFTk50UjlGOE9GZDlvN2NJ?=
 =?utf-8?B?QkQrakJJNXBZTThWQk9mS1ZLSzdUMTdIVmdJUzhMV1o1YjRkbjZMWGd1MURD?=
 =?utf-8?B?QmZoSUN2aUsyRWlkM3dic0tUTXpQN1dnalFxMWZyT29CMWNuOTlHVlVGazM0?=
 =?utf-8?B?aXVmNllIcXFNdDM3azZyYkJoZW9kQStEeS9xV3diZXpTTHlMU3daL09JeEha?=
 =?utf-8?B?VSt4TG11WTcwbnNkZUNJUnYycVdxeW10S0tCU1BrdmxUcE9kZ0xFcWdOR3BN?=
 =?utf-8?B?a0ZBc2dVeDk3M2VLSWhRdDRGMU5MbjBjTEtxaWp2NlYwbzRMcnF2dm40WGhC?=
 =?utf-8?B?MktMR2tvNmppYmdhSW5hbVc3OVRaVmQwNS80Vyt0MzRwRHB5OERkMXVnSFpB?=
 =?utf-8?B?SXhyUEJsTUdiblRBN2JtZlNDVUNxRElkMGhrc25aMWNta08zUjlnYll3a2kv?=
 =?utf-8?B?ZVhEWjFDWVZtN1FSdjY4YmpGOUk1a0ZMWkZkYVlKZjNHdkpXS0p4Nm80YjZV?=
 =?utf-8?B?Qng5MVJBK0xJQWtqaDc3ajAybmdudytOMmNHclByZHNBN1I3U0h0dXhtQUVr?=
 =?utf-8?B?eHp4YlhTM2kwcHdKamNXMGpobEFqdVRSTE5wQ28vd21QZG9XaG1GcUl4U29E?=
 =?utf-8?B?Sy8yR2V6K0ZkM1JYQzhYVkdOcWNVS1hxSVBTbWE3c2JxdWdBeVlRQXI2RXB5?=
 =?utf-8?B?ZDVrdzFQQzVuVjd0RXk4eE83NThCSXYwU2lnbTk2b25ZclZYcEt3NmtjeEdX?=
 =?utf-8?B?UkxDbml3YzVDMkFTUnE1N0VPL2dnVEhZalZKOXJ2UVdkKytVMGQrNTBQK1o1?=
 =?utf-8?B?M2JwdWNyMXY1TWhSQ3hlRmVyOElvQjNHS0tzYWlGc21jejdtMVA3VGs3ZTVB?=
 =?utf-8?B?eFVwN2J1cnE3TVp3V3o2dkZIRENYbm95Sk9FaU12TmZtVjVVWmtjZXUwSlN6?=
 =?utf-8?B?Tjk0aUh6Y2xRSEdMWllwT1drT3BVWVdGaUFtOGQwS0Y4eVNVMkVoeGFhVU9Q?=
 =?utf-8?B?SnBWWmp0UUdmQ3RVSzJHK3BGV3d1NVFMZGE0YlNseG1meE1GbEk4MGdiVXNl?=
 =?utf-8?B?SmVZWTRqaWdWQ0FiaVc1MzZpRDh3VTR6MTJELzRTdXNNYlMzaHlaV1pMRmVk?=
 =?utf-8?B?bjNGZkRtd0RYdGV5V0d1bGJsRklpNE9WM1loQXI5azgyc3BvS2lrNlI2M3la?=
 =?utf-8?B?VlB4TW5MTDBMUzFTL3cvb0xybjViT0d4MUZrKy8zZTdsSisrQUF4WkhpSk4z?=
 =?utf-8?B?NTY4MzhhaythSjgybkFHRGVvaWdpaG9HS1crdUFRWXFKSDRZY1JqMzBvVzl6?=
 =?utf-8?B?a29HSmFHWjdrSnhDcDk1R3RaMjUyMEk5RnpTb3pjcGc0dnBIVnI3bVJTd3M4?=
 =?utf-8?B?YWtnNk9iQ3B3MmxWOEc0WHdkbENDUFVDdktydzlQMW5JQWNDWGRDVm8ycGVX?=
 =?utf-8?B?YlN2MGRnWjFMZWNtUHFUaVptWkhqMkRNNS9mZmN0YUZGNlRCamNNRnZ5MTcw?=
 =?utf-8?B?M0oyZlY2SUhiNkM2bTVkT1NwWmd2SmoxK3NWY1lJMCtiRU1NQ201WXdxUkFC?=
 =?utf-8?B?bHc9PQ==?=
X-OriginatorOrg: meta.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 51d2538a-1393-43ee-592c-08db4cabf1cc
X-MS-Exchange-CrossTenant-AuthSource: SN6PR1501MB2064.namprd15.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2023 14:29:18.4909
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1YMiwzMVSELf5rLp2g6O+DUYPiTnQ/NhHhGbCUwFy0mU7hvrNDKQbUx87i2DtyQy
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR15MB5899
X-Proofpoint-ORIG-GUID: 9bCAJVvOrCV2Skos8n0nGvB8vHHUENPk
X-Proofpoint-GUID: 9bCAJVvOrCV2Skos8n0nGvB8vHHUENPk
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-05-04_10,2023-05-04_01,2023-02-09_01
X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 5/3/23 8:15 PM, Feng zhou wrote:
> From: Feng Zhou <zhoufeng.zf@bytedance.com>
> 
> Add a kfunc that's similar to the bpf_current_task_under_cgroup.
> The difference is that it is a designated task.
> 
> When hook sched related functions, sometimes it is necessary to
> specify a task instead of the current task.
> 
> Signed-off-by: Feng Zhou <zhoufeng.zf@bytedance.com>

You can carry my Ack from previous revision since there
is no change to the patch.

Acked-by: Yonghong Song <yhs@fb.com>