Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <c42a721c-13a4-16a1-efe6-002c76f5c69b@axis.com>
Date:   Thu, 4 May 2023 17:08:15 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.0
Subject: Re: [PATCH v2 1/2] regulator: Add bindings for TPS6287x
Content-Language: en-US
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Mark Brown <broonie@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
CC:     <linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <kernel@axis.com>
References: <20230502-tps6287x-driver-v2-0-fb5419d46c49@axis.com>
 <20230502-tps6287x-driver-v2-1-fb5419d46c49@axis.com>
 <dfd3498c-62ab-92d3-22d6-21729dc619fa@linaro.org>
From:   =?UTF-8?Q?M=c3=a5rten_Lindahl?= <martenli@axis.com>
In-Reply-To: <dfd3498c-62ab-92d3-22d6-21729dc619fa@linaro.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cVlZd2t4cWxaN0tlQUFNbklRcU5SZFNVMWVwcjVxVHJGSlBVeXM2STRuNXVZ?=
 =?utf-8?B?SUhiT050YzVoMXZWY1BoUzNPei9oZmQzU3lpdDNZWXlidC9RTWJBR2xRenN3?=
 =?utf-8?B?UFcvazFrSklZOGRBb1hOMnMwUDBRNHUyRUVQckE3WUtSQW9iTURnOXR0dWFu?=
 =?utf-8?B?VWxGUllZWU5DVnp4UGRDeGlJQnkyd1Y5dHk2VjhHOVg0R2hhd24wMDFMNyto?=
 =?utf-8?B?aC9tMzYxTHhPbnhxa3ZRT0I5bjlhMHd6UFZNcTR1eFZCQlpRamEvMWVHVGQ4?=
 =?utf-8?B?YVlOc3hwaUxOUFB2d0owLzRuWklkUTlWWHZCSVFSOEVmaGZiMEtpS1hUZVBT?=
 =?utf-8?B?YnNzQjljcXZSbHRXTDAwS01kM0hSNzI1UzhnUzAxZmlWU1pVZ2FFTlJjTGpy?=
 =?utf-8?B?Q2hCL21JT1hHdUM1RWNNOC9BaHVmVmhQVjN4eVZRWGtIREhSZnYvSC8zdi9p?=
 =?utf-8?B?bkxkWU9PNjdDTk56cGFibHNxYkVmQWxqeTZ4T2IvcVJ1bmdmeDlISUdXZkov?=
 =?utf-8?B?aHk0SlA4anJ2VGc4dnlpU1NCK2JhRzBDZGZGNitJaTVzVlRoRWYzazZkS1Zh?=
 =?utf-8?B?cDdiWXlrZDdCRkV3d1BRSVJvSGZlNnJrQTZBNkdJNEtoUkNzOWU4eEUwdzBO?=
 =?utf-8?B?SXBpMk9jTXkrdFF4clRDMmxXcjQ4OU0wUWJMSG5sMTZUaDNvbGtuUVlOVjBY?=
 =?utf-8?B?ZGlZVUxFL2x6eFVTL09qaWp3REgwbmlJRE1WSVUxTFQ2eEk0b0tta1pqeTFR?=
 =?utf-8?B?MVdlN1IzY3Z1dDAvRzNybEd1czlxVkhRemZ6bnpRMlNVaXVaWXlvTk55Rm5h?=
 =?utf-8?B?bTE2UFRyVVZ5ZGkzUW5NZ3hMeDB0L25WYk5yUzZ1OVZZYWhxMHhhSkRwcnZi?=
 =?utf-8?B?dlpXcEYxZkFXaXRSL3RRaTVsbjloOEpaYmYwVXIwL0duV3B2d3pXdCtxb3ov?=
 =?utf-8?B?RldOVlZ5WlJFaWZtSVMrQ0Z0ZnVDdE9xdVNMOFpWTlhXS2JZUUV0cW1LaXhH?=
 =?utf-8?B?bHBkNnk5N3UvSFllaHlCUTFZNlpoVFJ3YWxMZ2YxY1hQMCtFcmdXNHZxeS8z?=
 =?utf-8?B?K0l0MWJTajgreGFlcjA1Z2tSUFF4clVUUVowMm1SV3ExVk5RS0lJVlNMWVly?=
 =?utf-8?B?RWlXaVB1VjB0ZDdCMmhxNFJxZi9DTkN6czJPWGt6blFlSzYxdWZnRnUyTlNh?=
 =?utf-8?B?NUxrOUdEY2p6VWgrb1d0MDR2a1JEaVJFemY0RVFuSXpjMC9qTTZYMkozNVNG?=
 =?utf-8?B?SWVnbjRUVmczWlVZT3JocllOWmliZGtjOERuZlNkSDNqNTNPNzlheDhOdGZn?=
 =?utf-8?B?S2VvREw5NjVjU0FLdWJ3YkMxdU1YRzZqMXdGS3FzcGhDR3FNVVUwbi9vaVFq?=
 =?utf-8?B?M0ZKa0ZldmRWVjVWUWNhODAvbmd2OVE3dGJ3RXY1WUNEV25vU2dOaDRXbTRK?=
 =?utf-8?B?TUtDWDJIS3JZbEwwZHFjN2ZES2pObXdpVysrWlgyR2FUNVJFVW1jdUs3SDhr?=
 =?utf-8?B?dHhZbVN2eWFJYms2Q2lJQmxZZjVLZHVkb2thd3piR2daS1RFcWlpWFV0MFpl?=
 =?utf-8?B?NnlMMjc3Vlp0eXZuWXY0YUR5OExKRXU0YjdpY0FjRXhyMHpId0VVb2FFS2VZ?=
 =?utf-8?B?NVZQK0tGMHFSMnRsV090eXpNczhwdGhHZjRMZTVuSlpQeVpzM3B2aFJudnZC?=
 =?utf-8?B?YkEwN20rRGVPaGFnUkx0bUIxQUw1anNKR3VlcFd6QldUY1paM0dMWWlXSll6?=
 =?utf-8?B?RktoQ3c2QmRtQmFRYnQ3SC93Q0QxUXdQRTU1ZllnMTZ5RXpnU0htK3ArQnp4?=
 =?utf-8?B?aTJlWGpxamRkWjhTQ0ppRjdiSUJnN1lhMU9JbkFMZTJoMUNLUGVJWDR1TGdI?=
 =?utf-8?B?bGhWRElPRTBGMzJHNWpEU2FSaXRCOTBWVi9FMk4wM0RVUkdseXdxRmFuU3c0?=
 =?utf-8?B?MWNJa0xDY3ZVWUtHU0VsT2JNSjMvQ1MzOFFaZDI4QjQvelhQSC8zTG50eU9s?=
 =?utf-8?B?eG1BQlBFeEMrTFVWUG1xcVZ4ZmhSK29vbHN5NU5OUEpFY0htdVZOMWJIYUxs?=
 =?utf-8?B?OGJKVXFpTjBad1p4M3FuVjBackowd1RuN0lzN0FDTlIzakFicnVxQ1hhNGdu?=
 =?utf-8?Q?qiJU6etLP6XyFQiwxQFC+l7rO?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 41a7713b-2f29-4faf-1d18-08db4cb163da
X-MS-Exchange-CrossTenant-AuthSource: AS8PR02MB9529.eurprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2023 15:08:17.3172
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 78703d3c-b907-432f-b066-88f7af9ca3af
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Wfe4qp2GbRB0jbofRaHV1Jj8p2UJIV44uOUNondiWCdgzFtrPWs/vwMuqmUUa2vvoaNBdxgVrWBkCiRSAoUYEg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR02MB10046
X-Spam-Status: No, score=-8.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_MED,
        SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Krzysztof!

On 5/4/23 11:34, Krzysztof Kozlowski wrote:
> On 04/05/2023 10:30, Mårten Lindahl wrote:
>> Add bindings for the TPS62870/TPS62871/TPS62872/TPS62873 voltage
>> regulators.
>>
> Use subject prefixes matching the subsystem (which you can get for
> example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
> your patch is touching).
>
> Just a hint - I in general ignore all the emails without dt-bindings prefix.
Ok, I'll prefix it "dt-bindings: regulator:"
>
>> Signed-off-by: Mårten Lindahl <marten.lindahl@axis.com>
>> ---
>>   .../devicetree/bindings/regulator/ti,tps62870.yaml | 62 ++++++++++++++++++++++
>>   1 file changed, 62 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/regulator/ti,tps62870.yaml b/Documentation/devicetree/bindings/regulator/ti,tps62870.yaml
>> new file mode 100644
>> index 000000000000..32f259f16314
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/regulator/ti,tps62870.yaml
>> @@ -0,0 +1,62 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/regulator/ti,tps62870.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: TI TPS62870/TPS62871/TPS62872/TPS62873 voltage regulator
>> +
>> +maintainers:
>> +  - Mårten Lindahl <marten.lindahl@axis.com>
>> +
>> +properties:
>> +  compatible:
>> +    enum:
>> +      - ti,tps62870
>> +      - ti,tps62871
>> +      - ti,tps62872
>> +      - ti,tps62873
>> +
>> +  reg:
>> +    maxItems: 1
>> +
>> +  regulators:
>> +    type: object
>> +
>> +    properties:
>> +      "vout":
> Drop quotes.
>
> Why do you need entire "regulators" node for one regulator? Why do you
> need child at first place. Drop it entirely.
I will remove the regulators node. I think the vout node is needed to 
get the of_get_regulator_init_data.
>
>
>> +        type: object
>> +        $ref: regulator.yaml#
>> +        unevaluatedProperties: false
> You missed that piece of explanation:
>
> "The set of possible operating modes depends on the capabilities of
> every hardware so each device binding documentation explains which
> values the regulator supports."

Ok, I will add a description for the valid regulator-initial-mode values.

Thanks!

Kind regards

Mårten

>
>
>
> Best regards,
> Krzysztof
>