Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Niklas Cassel <Niklas.Cassel@wdc.com>
To:     Keith Busch <kbusch@kernel.org>
CC:     Andrew Morton <akpm@linux-foundation.org>,
        "jiweisun126@126.com" <jiweisun126@126.com>,
        "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "axboe@fb.com" <axboe@fb.com>, "hch@lst.de" <hch@lst.de>,
        "sagi@grimberg.me" <sagi@grimberg.me>,
        "ahuang12@lenovo.com" <ahuang12@lenovo.com>,
        "sunjw10@lenovo.com" <sunjw10@lenovo.com>
Subject: Re: [PATCH] nvme: add cond_resched() to nvme_complete_batch()
Thread-Topic: [PATCH] nvme: add cond_resched() to nvme_complete_batch()
Thread-Index: AQHZfmxhAnBWBykOJUOdfcgNJU7LAa9J5RgAgABSBgCAAANPgA==
Date:   Thu, 4 May 2023 15:18:12 +0000
Message-ID: <ZFPMs6e2c3tM99o0@x1-carbon>
References: <20230502125412.65633-1-jiweisun126@126.com>
 <ZFKLxfet7qUIwScd@kbusch-mbp.dhcp.thefacebook.com>
 <ZFLxXjiQUPl+tV8L@kbusch-mbp.dhcp.thefacebook.com>
 <ZFN9aWYCxJW/HdHi@x1-carbon> <ZFOFHv8Kh/7KLuBa@x1-carbon>
 <ZFPJ7CYFEextnOqE@kbusch-mbp.dhcp.thefacebook.com>
In-Reply-To: <ZFPJ7CYFEextnOqE@kbusch-mbp.dhcp.thefacebook.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?hD2HX4bunlCGOxQaxQozT0SL0meanzLX3b5tv/f4vDuip7M6+OCmkP8JaVoM?=
 =?us-ascii?Q?roNFgJpHSodfOdoBZ2mVn5uAO+BRaolUWGe0vaLE8MApSLdjcFF4jld56Ygz?=
 =?us-ascii?Q?VH1y0WQcroZkmBjJ1cWjWSEEy5kIVANM3jkNi+bX7pUIeqEbEmKf7MYlwEFv?=
 =?us-ascii?Q?17kKOgtVXv4FB4iep0k4LzvTc1B8eJaEfBPvjWE7MZRsansaPvg+2nXTVw0A?=
 =?us-ascii?Q?w+SGtieYa+ooVKM1eJTkVUAF0EvlFf22c7Cir8j8ORY1cnfyUmGQ4PUiIZFy?=
 =?us-ascii?Q?7rH0MCX7GdNhOjzzS+yB/ECQHBixhQ3x4YzuTknss2yDMEll5FTT68+N8xLd?=
 =?us-ascii?Q?DbkuoMU9KOZqUlfnGvOggSV65doGq2qm0K8xwtHlgNZ0q3s60ATM6r1+JFHS?=
 =?us-ascii?Q?STR2VQUaK4FcotiwSzPTxtDB0N7Y4i60plUZFhT/7kMpRJ2lNdMTKKVjz+tp?=
 =?us-ascii?Q?k+NWmf2whBYSwKOmJPiVp28/McMyjcSvKWPi5dVs9aIn4qrBmL0axkffcUYf?=
 =?us-ascii?Q?qXpnloWleMgCDzPzJu2BfNbApOvy3KNQcyBeaGRulLvFH0Z+lePtJIGf4yVN?=
 =?us-ascii?Q?RXVi/8jYe5UKaRuI+Dm1xu7Ad8CNGBrnoJxjHdRZ39Xb/ZbOgHufDuWnRBJ/?=
 =?us-ascii?Q?J5pW8BR+mcX4mHRvdMKgP1XqCZmLm7zuxO75D5PKLdMoaKy9JIC1VgzILNeO?=
 =?us-ascii?Q?jR4XkIAjEZSJRGpDXsThUktDDnUA1PyF/BfiuAp6nfpk0fBfLuSU2X1L+K0Q?=
 =?us-ascii?Q?sivCUbNxoi98BnvU8PktEBpW4OgPmvdtuwRPQx6PJXnsgL/s/QM8OvaiyswE?=
 =?us-ascii?Q?RrZ77LVdBHO0ZE99oGoVH6xtyKnxCzZFS6wIZrn4NFTGGjfFm0LLOW8wXlT5?=
 =?us-ascii?Q?glDfREZvq0Eb2ys0yCaMXDfcSAkdB9a5GSQvK09xgQxiSFC2vh7xzkU62ztx?=
 =?us-ascii?Q?J3PBE0fsArTNAaXrYmyFpn38qtIWqL9nDJ042x1C6BpDiLRf+GSXtjKBwZHm?=
 =?us-ascii?Q?iAmpraWmvSAShwD59UgGcn7NAkn76P3ITJlA4lRBwO6r9ktWY6dSvHDgt69w?=
 =?us-ascii?Q?CwVqyh2f1fAtw80rlo6M5HeHa48rHgQD/2YDqetQP/4xkYAsU6hJ2Bl29nCh?=
 =?us-ascii?Q?RPYz+QRiymF7gM4qPAVaQKcUuLEH/svGaTmS5wLoLBYJL3P+fXG0GIAr7G0J?=
 =?us-ascii?Q?e4tBqeOl55Oevi6k3IXDdsnagGGIQzJuCfdXHIYIA0ORuf9XrFwQwzxY+hhj?=
 =?us-ascii?Q?aNIyx1YhTw3YbKDQ29E5Jmzj3b/vcNG1dsD11HPFn3sQuqrjlP4vr34Z1nKe?=
 =?us-ascii?Q?GDOqv8fJ0kHnoXHQKpRhFKMV9OLlS7HiFLeMTa2sQsV6CiaSmX17CCboXZ1M?=
 =?us-ascii?Q?7h+qRmqBdTPo/QYaXMLGkAqXXKYv+86bCsDG+9bP7dv9L4Xw9WAj4te6dwp6?=
 =?us-ascii?Q?PbjFRyrQNhgoDZQdg9JLjxWtnx0QnKmaGKhETU4AwXfN92yBqDUcaEYzSdkr?=
 =?us-ascii?Q?llK/0OYXtlMVdLXo6c9GowS7dTSKsPM9Qb9LL05AElKeMS+kHlk55wpQluMQ?=
 =?us-ascii?Q?pafJavxBED+ef9IYj0x3JW5Eud5IMgZY2cSZ5nuFMeDR70IelKeWkwXr6ms7?=
 =?us-ascii?Q?+w=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <D74BD76E8278A14D99B883179EC6FC69@namprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?NPDyHDQ6reIF0xlpo6LcAZ+SIwkw9++yC1xKq4Rf3ddkkNRit9C5ve++O+NE?=
 =?us-ascii?Q?bBZ8CB7KL1RqjsaP10H/Aq/XIOelKQRUo3gvJQSPCL+Alejgk+5Eyirbw052?=
 =?us-ascii?Q?YNuxMEPs9hLMfCn6W6N8DYVe7t7EOtwqCA4WEOt0N/6PA99zq2AU1y+Y7YFX?=
 =?us-ascii?Q?cyKCb4aFx42JaRLOawLCN5QqWnvv0az0iYZYzWsfdA/HvkMOrq/H76LLUca0?=
 =?us-ascii?Q?ibgXgSlf9N5b5cqJhYHT9ckXG8TGmach1tEozd1bd2jeVJ/0n68uofxlFveZ?=
 =?us-ascii?Q?0YaK0HjLDhpM48D9ZyNxGcmemp3ueMUX6CwlCJLwdJZB7op822bIhrj19+bl?=
 =?us-ascii?Q?cdS1dZputLRAdE5ltyd98UYU3D55YWqoRZ3Z1I0PYDG3u3c4v3biiLeAWGsu?=
 =?us-ascii?Q?nVzh78TDTKnB3n+qV1IEVaBuHShK4GVGQ/y4riWgpUbTKNJbKxXPu2mF1+BO?=
 =?us-ascii?Q?aSTdrZ/hDrpjCz6tosURHK1r3+ctOLMLEXVLiFhZXEYItYdQ/uJmMK59Uh6t?=
 =?us-ascii?Q?Ne6i7XnJpTU38726abM+eipKTuFxIyHRHzGWAsM83uCllOPg5olPvajK7GBW?=
 =?us-ascii?Q?4Y5WUysuJqsEFd7AN3ydfFpdA4+TuHBpSHLnm0EioNFar9231VADOMbMxm8h?=
 =?us-ascii?Q?g53ZGp5XjaJtvCUygCIMNl49jPZHkKaRZFATztCQuJ0Sq5yCXLGXJ4ct1p4p?=
 =?us-ascii?Q?TpI/osO3EVXpC5ghQ0uUtXo8LC1EOxFZjIYz4oE8b+mTdUhtsYaogPtiNEvT?=
 =?us-ascii?Q?T1O1uN8Gu8RRROy14yaakaDDbxLIAt9tLVvEI8fb17gjO7CmjaQnqhjL+9YR?=
 =?us-ascii?Q?9AsXj/FRXpLyUmriMjlWgTI59m7Szb/oemx3gQzCO0ms75mjA6re206rAfS9?=
 =?us-ascii?Q?0agf8URDIAvMRYSdxjoKsiFu90LUboz2xw/HWs1ggSjyVnzrPbTJwgG9OU/E?=
 =?us-ascii?Q?leSUW7hlA/9Nd0TYoQ82q9newgcAGgMAhum8faVDaoW2hWMxLuduhWId2CYP?=
 =?us-ascii?Q?TZDulBG6NJSf9Pvp09u9iYORJ1cJO9EopYyHVZhuY1dB3WY=3D?=
X-OriginatorOrg: wdc.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MN2PR04MB6272.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 94a70116-aa5d-481a-6c72-08db4cb2c6e3
X-MS-Exchange-CrossTenant-originalarrivaltime: 04 May 2023 15:18:12.7521
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: TN4cOb+0AxMNMB2yd0TlD3PjeaezerBvuSu8S6cqFMjt8wBKnx6jQha+BuMtrXeSs4dyEGoL0MviVXD/ZNhctQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR04MB6982
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,
        SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, May 04, 2023 at 09:06:20AM -0600, Keith Busch wrote:
> On Thu, May 04, 2023 at 10:12:46AM +0000, Niklas Cassel wrote:
> > On Thu, May 04, 2023 at 11:39:53AM +0200, Niklas Cassel wrote:
> > >=20
> > > Something is fishy here...
> > >=20
> > > (Perhaps the maintainer did a git revert instead of applying the fix.=
..
> > > and accidentally squashed the revert with a proper commit...
> > > But even that does not make sense, as there simply seems to be too ma=
ny
> > > lines changed in 2d55c16c0c54 ("dmapool: create/destroy cleanup") for=
 that
> > > to be the case...)
> >=20
> > It seems like the additional lines in
> > 2d55c16c0c54 ("dmapool: create/destroy cleanup") is explained by the
> > maintainer (probably accidentally) reverting additional patches in that
> > very same commit.
> >=20
> > It seems like that commit reverted all changes to mm/dmapool.c since v6=
.3:
>=20
> Spot on, thanks for confirming! Somehow a series revert was squahed into
> the final patch. :(
>=20
> We reached the same conclusion pretty late yesterday, so I'll wait for
> Andrew to suggest how to proceed. I think we have to rebase whole series
> with the correct final patch and resend the pull.
> =20
> > $ git log --oneline 2d55c16c0c54325bf15286cfa6ba6c268036b9e4 --not v6.3=
 mm/dmapool.c=20
> > 2d55c16c0c54 dmapool: create/destroy cleanup
> > a4de12a032fa dmapool: link blocks across pages
> > 9d062a8a4c6d dmapool: don't memset on free twice
> > 887aef615818 dmapool: simplify freeing
> > 2591b516533b dmapool: consolidate page initialization
> > 36d1a28921a4 dmapool: rearrange page alloc failure handling
> > 52e7d5653979 dmapool: move debug code to own functions
> > 19f504584038 dmapool: speedup DMAPOOL_DEBUG with init_on_alloc
> > 347e4e44c0a9 dmapool: cleanup integer types
> > 65216545436b dmapool: use sysfs_emit() instead of scnprintf()
> > 7f796d141c07 dmapool: remove checks for dev =3D=3D NULL

Hello Keith, Andrew,

Note that the first four patches were not part of Keith's series,
but they were reverted as well.


> Andrew actually squashed that fix into the original patch.

Ok, strange why there was a revert done at all then.


Kind regards,
Niklas=