Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Sender: Guenter Roeck <groeck7@gmail.com>
Message-ID: <670c3604-7287-ed7d-8e37-b0458ff28ca8@roeck-us.net>
Date:   Thu, 4 May 2023 08:27:31 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [PATCH v2 3/4] usb: typec: tcpci: clear the fault status bit
Content-Language: en-US
To:     Marco Felsch <m.felsch@pengutronix.de>
Cc:     andreas@fatal.se, jun.li@nxp.com,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Heikki Krogerus <heikki.krogerus@linux.intel.com>,
        Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Fabio Estevam <festevam@gmail.com>,
        NXP Linux Team <linux-imx@nxp.com>,
        linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org
References: <20230504-b4-v6-3-topic-boards-imx8mp-evk-dual-role-usb-v2-0-3889b1b2050c@pengutronix.de>
 <20230504-b4-v6-3-topic-boards-imx8mp-evk-dual-role-usb-v2-3-3889b1b2050c@pengutronix.de>
 <6a894ff0-3232-4ef0-5e26-95471cc33ed9@roeck-us.net>
 <20230504142708.l4xo4sbl7wzsrbql@pengutronix.de>
From:   Guenter Roeck <linux@roeck-us.net>
In-Reply-To: <20230504142708.l4xo4sbl7wzsrbql@pengutronix.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 5/4/23 07:27, Marco Felsch wrote:
> On 23-05-04, Guenter Roeck wrote:
>> On 5/4/23 06:46, Marco Felsch wrote:
>>> According the "USB Type-C Port Controller Interface Specification v2.0"
>>> the TCPC sets the fault status register bit-7
>>> (AllRegistersResetToDefault) once the registers have been reseted to
>>
>> cleared ? set ?
> 
> Sry. I don't get this.
> 

instead of "reseted" which isn't really a word.

>>> their default values.
>>>
>>> This triggers an alert(-irq) on PTN5110 devices albeit we do mask the
>>> fault-irq. Fix this gernally by writing a one to the correspondig
>>
>> generically ?
> 
> Sure, thanks.
> 
>> corresponding
> 
> Of course!
> 
>>> bit-7.
>>>
>>> Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
>>> ---
>>>    drivers/usb/typec/tcpm/tcpci.c | 5 +++++
>>>    include/linux/usb/tcpci.h      | 1 +
>>>    2 files changed, 6 insertions(+)
>>>
>>> diff --git a/drivers/usb/typec/tcpm/tcpci.c b/drivers/usb/typec/tcpm/tcpci.c
>>> index 8da23240afbe..15632d023e4c 100644
>>> --- a/drivers/usb/typec/tcpm/tcpci.c
>>> +++ b/drivers/usb/typec/tcpm/tcpci.c
>>> @@ -602,6 +602,11 @@ static int tcpci_init(struct tcpc_dev *tcpc)
>>>    	if (time_after(jiffies, timeout))
>>>    		return -ETIMEDOUT;
>>> +	regmap_read(tcpci->regmap, TCPC_FAULT_STATUS, &reg);
>>
>> Needs error check.
> 
> I will add this.
> 
>> Also, I am not sure if this is the correct place for this code. The alert
>> status is cleared after vendor initialization. Should the same be done
>> here ?
> 
> According the spec the bit must be cleared before the TCPC_ALERT is
> cleared. Of course the vendor-init can (re-)trigger the bit, therefore
> we should move behind the vendor init and right before the TCPC_ALERT
> clear.
> 
>> Also, why not just write the bit unconditionally, similar
>> to TCPC_ALERT ?
> 
> Thought about this too.. I will change it in the v3.
> 
> Thanks for the feedback,
>    Marco
> 
>>
>> Thanks,
>> Guenter
>>
>>> +	if (reg & TCPC_FAULT_STATUS_ALL_REG_RST_TO_DEFAULT)
>>> +		tcpci_write16(tcpci, TCPC_FAULT_STATUS,
>>> +			      TCPC_FAULT_STATUS_ALL_REG_RST_TO_DEFAULT);
>>> +
>>>    	/* Handle vendor init */
>>>    	if (tcpci->data->init) {
>>>    		ret = tcpci->data->init(tcpci, tcpci->data);
>>> diff --git a/include/linux/usb/tcpci.h b/include/linux/usb/tcpci.h
>>> index 85e95a3251d3..83376473ac76 100644
>>> --- a/include/linux/usb/tcpci.h
>>> +++ b/include/linux/usb/tcpci.h
>>> @@ -103,6 +103,7 @@
>>>    #define TCPC_POWER_STATUS_SINKING_VBUS	BIT(0)
>>>    #define TCPC_FAULT_STATUS		0x1f
>>> +#define TCPC_FAULT_STATUS_ALL_REG_RST_TO_DEFAULT BIT(7)
>>>    #define TCPC_ALERT_EXTENDED		0x21
>>>
>>
>>