Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230420165454.9517-1-jorge.lopez2@hp.com> <20230420165454.9517-10-jorge.lopez2@hp.com>
 <951adb9c-dd5c-4c40-a786-2025ebe1650f@t-8ch.de> <CAOOmCE-dVzSrjWDx=tcXP-f+4NuN-U_-sc_QaLRt1qjtjaVVGw@mail.gmail.com>
 <bb7ca13b-bef2-459a-aa11-bfbae1ee81bd@t-8ch.de>
In-Reply-To: <bb7ca13b-bef2-459a-aa11-bfbae1ee81bd@t-8ch.de>
From:   Jorge Lopez <jorgealtxwork@gmail.com>
Date:   Thu, 4 May 2023 10:51:48 -0500
Message-ID: <CAOOmCE8RQ5x2+eGSEZwBkoj1oQzY=VCrZf8vaWnY9+QT_P+tcg@mail.gmail.com>
Subject: Re: [PATCH v11 09/14] HP BIOSCFG driver - enum-attributes
To:     =?UTF-8?Q?Thomas_Wei=C3=9Fschuh?= <thomas@t-8ch.de>
Cc:     hdegoede@redhat.com, platform-driver-x86@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, May 3, 2023 at 3:10=E2=80=AFPM Thomas Wei=C3=9Fschuh <thomas@t-8ch.=
de> wrote:
>
> On 2023-05-03 14:42:37-0500, Jorge Lopez wrote:
> > On Sun, Apr 23, 2023 at 7:55=E2=80=AFAM Thomas Wei=C3=9Fschuh <thomas@t=
-8ch.de> wrote:
> > >
> > > On 2023-04-20 11:54:49-0500, Jorge Lopez wrote:
> > > >  .../x86/hp/hp-bioscfg/enum-attributes.c       | 543 ++++++++++++++=
++++
> > > >  1 file changed, 543 insertions(+)
> > > >  create mode 100644 drivers/platform/x86/hp/hp-bioscfg/enum-attribu=
tes.c
> > > >
> > > > diff --git a/drivers/platform/x86/hp/hp-bioscfg/enum-attributes.c b=
/drivers/platform/x86/hp/hp-bioscfg/enum-attributes.c
>
> <snip>
>
> > > > +/*
> > > > + * validate_enumeration_input() -
> > > > + * Validate input of current_value against possible values
> > > > + *
> > > > + * @instance_id: The instance on which input is validated
> > > > + * @buf: Input value
> > > > + */
> > > > +static int validate_enumeration_input(int instance_id, const char =
*buf)
> > > > +{
> > > > +     int ret =3D 0;
> > > > +     int found =3D 0;
> > > > +     int i;
> > > > +     int possible_values;
> > > > +
> > > > +     /* Is it a read only attribute */
> > > > +     if (bioscfg_drv.enumeration_data[instance_id].common.is_reado=
nly)
> > > > +             return -EIO;
> > > > +
> > > > +     possible_values =3D bioscfg_drv.enumeration_data[instance_id]=
.possible_values_size;
> > > > +     for (i =3D 0; i < possible_values && !found; i++)
> > > > +             if (!strcasecmp(bioscfg_drv.enumeration_data[instance=
_id].possible_values[i], buf))
> > >
> > > Is this also intentionally case-insensitive?
> >
> > Yes
>
> Why? It is surprising.
>
> The behavior differs from sysfs_match_string() and friends.
> Thinking about it, this function should be able to use
> __sysfs_match_string().
>
> (Same for the ordered list type)
>

I will not be able to use  sysfs_match_string() for the conditions on
how the possible values are read and allocated by hp-bioscfg driver.

1. sysfs_match_string() expects the array to be defined as  const char
* const  array.  This definition is possible if the values are
statically assigned but not when the values are dynamically allocated.

const char * const possible_values[] =3D {
         [VALUE1] =3D "Enable",
         [VALUE2] =3D "Disable",
};
...
ret =3D sysfs_match_string(possible_values, buf);

2. sysfs_match_string() returns error EINVAL if the string case does
not match.   sysfs_match_string() string comparison is case sensitive.

3. BIOS rejects data if the data is not case sensitive nor matches
either one of the reported possible values.


> <snip>