Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755180AbXJBQHQ (ORCPT ); Tue, 2 Oct 2007 12:07:16 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751684AbXJBQHE (ORCPT ); Tue, 2 Oct 2007 12:07:04 -0400 Received: from sovereign.computergmbh.de ([85.214.69.204]:47480 "EHLO sovereign.computergmbh.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751514AbXJBQHC (ORCPT ); Tue, 2 Oct 2007 12:07:02 -0400 Date: Tue, 2 Oct 2007 18:07:01 +0200 (CEST) From: Jan Engelhardt To: Joe Perches cc: Ingo Molnar , Willy Tarreau , Andrew Morton , Andy Whitcroft , linux-kernel@vger.kernel.org Subject: Re: [patch] printk: add KERN_CONT annotation In-Reply-To: <1191341018.13170.27.camel@localhost> Message-ID: References: <20070928105345.GC18163@shadowen.org> <20071001064448.GA4239@elte.hu> <20071001003007.4e90143b.akpm@linux-foundation.org> <20071002043408.GM10199@1wt.eu> <20071002051852.GC28345@elte.hu> <1191339692.13170.18.camel@localhost> <1191341018.13170.27.camel@localhost> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 733 Lines: 20 On Oct 2 2007 09:03, Joe Perches wrote: >On Tue, 2007-10-02 at 17:45 +0200, Jan Engelhardt wrote: >> always use printk("%s", var) > >You have to use indirect arguments to log something? No, you do not have to. >Don't you think that's a stupid rule? Not at all. var may contain format specifiers, which poses a certain security issue into people's hands. This is already important in userspace, so is probably even more in the kernel, even though user-supplied strings are less common. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/