Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <000000000000951c2505d8a0a8e5@google.com> <00000000000091b72905fae0eda2@google.com>
In-Reply-To: <00000000000091b72905fae0eda2@google.com>
From:   Aleksandr Nogikh <nogikh@google.com>
Date:   Thu, 4 May 2023 18:51:03 +0200
Message-ID: <CANp29Y6PHCKRWSQvhs2gKTMC3u95Zo8VLTmXRxP1=5X00EKh-w@mail.gmail.com>
Subject: Re: [syzbot] [can?] WARNING in j1939_session_deactivate_activate_next
To:     syzbot <syzbot+3d2eaacbc2b94537c6c5@syzkaller.appspotmail.com>
Cc:     davem@davemloft.net, edumazet@google.com, kernel@pengutronix.de,
        kuba@kernel.org, linux-can@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux@rempel-privat.de,
        mkl@pengutronix.de, netdev@vger.kernel.org,
        o.rempel@pengutronix.de, pabeni@redhat.com, robin@protonic.nl,
        socketcan@hartkopp.net, syzkaller-bugs@googlegroups.com,
        william.xuanziyang@huawei.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, May 4, 2023 at 6:47=E2=80=AFPM syzbot
<syzbot+3d2eaacbc2b94537c6c5@syzkaller.appspotmail.com> wrote:
>
> syzbot suspects this issue was fixed by commit:
>
> commit d0553680f94c49bbe0e39eb50d033ba563b4212d
> Author: Ziyang Xuan <william.xuanziyang@huawei.com>
> Date:   Mon Sep 6 09:42:00 2021 +0000
>
>     can: j1939: fix errant WARN_ON_ONCE in j1939_session_deactivate
>
> bisection log:  https://syzkaller.appspot.com/x/bisect.txt?x=3D10cf099028=
0000
> start commit:   fa182ea26ff0 net: phy: micrel: Fixes FIELD_GET assertion
> git tree:       net
> kernel config:  https://syzkaller.appspot.com/x/.config?x=3D796b7c2847a68=
66a
> dashboard link: https://syzkaller.appspot.com/bug?extid=3D3d2eaacbc2b9453=
7c6c5
> syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=3D1455e3b2880=
000
> C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=3D10296e7c88000=
0
>
> If the result looks correct, please mark the issue as fixed by replying w=
ith:
>
> #syz fix: can: j1939: fix errant WARN_ON_ONCE in j1939_session_deactivate

Looks correct.
#syz fix: can: j1939: fix errant WARN_ON_ONCE in j1939_session_deactivate

>
> For information about bisection process see: https://goo.gl/tpsmEJ#bisect=
ion
>
> --
> You received this message because you are subscribed to the Google Groups=
 "syzkaller-bugs" group.
> To unsubscribe from this group and stop receiving emails from it, send an=
 email to syzkaller-bugs+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgi=
d/syzkaller-bugs/00000000000091b72905fae0eda2%40google.com.