Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <Y/NmzouehvMWTPVZ@gmail.com> <ZErTyKxjGQvF6EqP@gmail.com>
 <CAHk-=wiDTLgf8LhigR4XKnjgkuhsoS-pXZckXU79J-EXiOj7Vw@mail.gmail.com>
 <ZEy9kUpwx/N3JEA/@gmail.com> <73dbeef4-cc39-4f09-5050-724c5b8dbd8c@intel.com>
In-Reply-To: <73dbeef4-cc39-4f09-5050-724c5b8dbd8c@intel.com>
From:   Linus Torvalds <torvalds@linux-foundation.org>
Date:   Thu, 4 May 2023 11:23:41 -0700
Message-ID: <CAHk-=whqdgepR+o844ePrRnvPh7-L9MYdOhbwmDfiTHSE8Oo9w@mail.gmail.com>
Subject: Re: [GIT PULL] locking changes for v6.4
To:     Andrzej Hajda <andrzej.hajda@intel.com>
Cc:     Ingo Molnar <mingo@kernel.org>, linux-kernel@vger.kernel.org,
        Peter Zijlstra <peterz@infradead.org>,
        Will Deacon <will@kernel.org>,
        Waiman Long <longman@redhat.com>,
        Boqun Feng <boqun.feng@gmail.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Andrew Morton <akpm@linux-foundation.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, May 4, 2023 at 10:30=E2=80=AFAM Andrzej Hajda <andrzej.hajda@intel.=
com> wrote:
>
> Later I have also showed/suggested Rust's approach [3][4]:
> - 'replace' for __xchg,
> - 'take' for fetch_and_zero

I don't think either of those are acceptable, and both are to me
*much* worse than the existing "fetch_and_zero()" that i915 uses.

That name just makes sense and explains what it does. There is no ambiguity=
.

I will not be taking a pull that makes a good name worse.

Naming matters, and "use a generic function" is not an excuse for
having bad names.

              Linus