Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Luck, Tony" <tony.luck@intel.com>
To:     Piyush Malgujar <pmalgujar@marvell.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
        "Williams, Dan J" <dan.j.williams@intel.com>,
        "xueshuai@linux.alibaba.com" <xueshuai@linux.alibaba.com>,
        "benjamin.cheatham@amd.com" <benjamin.cheatham@amd.com>,
        "bp@alien8.de" <bp@alien8.de>,
        "james.morse@arm.com" <james.morse@arm.com>,
        "lenb@kernel.org" <lenb@kernel.org>,
        "rafael@kernel.org" <rafael@kernel.org>
CC:     "jannadurai@marvell.com" <jannadurai@marvell.com>,
        "cchavva@marvell.com" <cchavva@marvell.com>
Subject: RE: [PATCH v2] ACPI: APEI: EINJ: EINJV2 support added
Thread-Topic: [PATCH v2] ACPI: APEI: EINJ: EINJV2 support added
Thread-Index: AQHZfoz/HoY7ASH3bUeV4msZv1/xf69KTa1QgABJGIA=
Date:   Thu, 4 May 2023 21:00:51 +0000
Message-ID: <SJ1PR11MB608326A6AC3FFE42699DDB40FC6D9@SJ1PR11MB6083.namprd11.prod.outlook.com>
References: <20230504133224.2669-1-pmalgujar@marvell.com>
 <SJ1PR11MB6083A266C4A869FC9AAA5A9AFC6D9@SJ1PR11MB6083.namprd11.prod.outlook.com>
In-Reply-To: <SJ1PR11MB6083A266C4A869FC9AAA5A9AFC6D9@SJ1PR11MB6083.namprd11.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?YBtoiZX92RFHSYGyEjyv+dcIrBcj3heBJ/FdVWI9MURSScN0GdpgmbLMrJVk?=
 =?us-ascii?Q?VcMGChqo0yWTfeNXZcOOCuwtDVxTaHQNfafY3Qb4axHNRS5uxIZEcK39pmld?=
 =?us-ascii?Q?RDW07oSq73wsw6vGoIpnR3dDPiOgZkMiLkuvuBJMRpA084jLuy6+hESAvqR2?=
 =?us-ascii?Q?ZbF8kK0B8zTnmRPOngR+hyURAPQhDvieW70nvL2ken9Us91XhqJvKbdRf5Sp?=
 =?us-ascii?Q?5/ZvGWDjG7CXpr7whtxfMuHClJS57wOxAkrONMwKz7zWqnW39iNikoKjruzT?=
 =?us-ascii?Q?XbRVleLgAkqe0M+iDJSoTdhyQBIN3D+YUKElGzjUMmQMQNJJGe5ESvq4svu7?=
 =?us-ascii?Q?DUy6WrtSjVEpgi1J8vIvj8OqErLEF2KfbLzJBmdb10axxjsnIvLGlDay5WC9?=
 =?us-ascii?Q?YvfpigGQnG/N1HXZcNVHJWXPlIK/WV2WxRjM0KjT4kpFg5L1aLDwx3CVPIQT?=
 =?us-ascii?Q?GUtx9Lb02EUMJv4iVzb9Q4ZqNhEE7XZB0dBX1LyC21R0rvD1//B42Uh/SbM0?=
 =?us-ascii?Q?qYmGTHKEuZi0QHDopDiI68CzAD7N6r/RHeBCebbCl16jjISHB4mid5O6a3BX?=
 =?us-ascii?Q?mO+xdg+mQZXq2eJ/zNc9PlQRJfqUxlgSUWoyxXofWS2YrcEY0QVpjySULXxA?=
 =?us-ascii?Q?BSBxYIcRLTtLVBQkwZs7/Q/BH/fPMRy02U5cAECxRMRb1xT62Mh0tqiRF4bN?=
 =?us-ascii?Q?qENYy/roI6C0Sjjw4d1JJX9BAw6E/IhVm9RsKUpEGb1qAyYeYmaGM3ULfcbX?=
 =?us-ascii?Q?YhUWDJuY/7BJYorMI3aRIkJOBQsuIbCm87aO6HPy3GP+R/OYtviCxItaGi2+?=
 =?us-ascii?Q?4Zd33T5nlpvG5h8Fr6oGKRtjbCT4yqM5FcVXpqJqRAhc23RNEClYJoMfApp4?=
 =?us-ascii?Q?qnLildXef6+lVjErJvoV8dDBqeFdQZOqpoW+Dy9GhjU3hcoJT7NdDx5wl3Kp?=
 =?us-ascii?Q?vTJTaf0VjZLRwg0aBBxMbNc3Ys4dZt7BLLj95iMRRfvnLPE/IOa6ue44TqKX?=
 =?us-ascii?Q?3eiZAT21xNhM85gRYWaR076J0zl/yhylSPJ+HMqjhuGLZI2NZmri2vfEuL/N?=
 =?us-ascii?Q?QxzGEF/6m/94eXl1dqRD824k9CNlREXKPdWBBk2YPO64io8KJ0SyC8Lc8hfk?=
 =?us-ascii?Q?/ryuIdJJO3AzbixrHlqBlYmimmfNcdrehw0ZGY0y0yuLRx39cohLlPNpofad?=
 =?us-ascii?Q?AeqFTfGWl8K3sNhVFbM1ObeBJGT8Uk7wsY+qaiZGOwmMfGMiT23OB2t7wJRi?=
 =?us-ascii?Q?KgUizwqopRDKxGBZyH3pVpeppRf6wPTGOrsNLfPv9p1Q++UfZvfk82mdeNQ6?=
 =?us-ascii?Q?OkPGWteUQJNx2bjDyDoCjhFpqwJJAEZOmkpFYnaRAsB2/58lXz3vPjggC0WQ?=
 =?us-ascii?Q?hNMHXdZqS9YUTNFNSxe26iwKlLIJJdvLMNqBY/yxFSXyxfJNllIe70+9H0rG?=
 =?us-ascii?Q?M50c1g2vEWNv+9qjhAsK2znQzRMLDzy8oqIXYGQjshktN6rFJZh0TYsfb23+?=
 =?us-ascii?Q?1rflmcfdu4drjLRUsrJ9oc7APfuoekk5YTadrLfa+hrP6eK/J8ux/HkT8Mtu?=
 =?us-ascii?Q?aZerEnL8Vd9bVCKpbL8=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SJ1PR11MB6083.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 56517d2b-bae1-4778-a9e4-08db4ce2a4f1
X-MS-Exchange-CrossTenant-originalarrivaltime: 04 May 2023 21:00:51.6609
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: gh6mZ7kipxT1QORS97ABiMJZmEs3ZEPfVfDK2+PIfOXyWu+UTPdDGDZPbM56Bjip5LdideMS7WWRSEDDQW6ylw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5564
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> +An error injection example::
> +
> +  # cd /sys/kernel/debug/apei/einj
> +  # cat available_error_type         # See which errors can be injected
> +  0x00000001 EINJV2 Processor Error
> +  0x00000002 EINJV2 Memory Error
> +  0x00000004 EINJV2 PCI Express Error
> +  # echo 0x2 > error_type
> +  # echo 0x5 > flags
> +  # echo 0x12345000 > param1
> +  # echo 0x2 > param5
> +  # echo 1 > error_inject
>
> Is the expectation that platforms that implement EINJV2 will not include =
legacy
> EINJ support?

I spoke to some BIOS folks here. They said that the ACPI 6.5 change is an
extension to the action table with new opcodes for GET/SET when EINJV2
is supported. The legacy actions are not deprecated. So platform firmware c=
ould
support both old and new injection formats.

So I'm going to double down on this:

> Maybe it would be better to change the top-level directory to:
>
>	/sys/kernel/debug/apei/einjv2

and say this isn't a "maybe". The EINJV2 interface files should go
in a new directory. The old files should continue to work (assuming
firmware still enumerates the old available types).

Simplifying the interface for EINJV2 in the new directory is an option.
I think we should take it ... the "paramN" files that mean different
things for different injection types were an evolution rather than a design=
.

-Tony