Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Mike Kravetz <mike.kravetz@oracle.com>
To:     linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        linux-fsdevel@vger.kernel.org
Cc:     Matthew Wilcox <willy@infradead.org>,
        Ackerley Tng <ackerleytng@google.com>,
        Sidhartha Kumar <sidhartha.kumar@oracle.com>,
        Muchun Song <songmuchun@bytedance.com>, vannapurve@google.com,
        erdemaktas@google.com, Andrew Morton <akpm@linux-foundation.org>,
        Mike Kravetz <mike.kravetz@oracle.com>
Subject: [PATCH 0/1] fix page_cache_next/prev_miss off by one error
Date:   Thu,  4 May 2023 16:38:57 -0700
Message-Id: <20230504233858.103068-1-mike.kravetz@oracle.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?KH+C5piD30r0Z+YvJnXXN3qfwo1LAQyTLzE6ttPXEgwHsfhTRNT9wvy9OJkw?=
 =?us-ascii?Q?0RqNq1Qkj3eeAcjs1UZGOCKuhqgqQVhEkwmXWnDyPqMkwxezqEqYsN2a/846?=
 =?us-ascii?Q?u7B4n7nQEPXCB+Yr3Cpn1WapAwG/gx2IL3RQFkJnoHj1rVhKmFIpYaMLJS5n?=
 =?us-ascii?Q?rIM8MeRMRaNuxZt5Ml2CVi4OE2CJqtlD3ia9OgLRGFAOqwcxDgzdFClGA7qP?=
 =?us-ascii?Q?ei/oTll8L78q+BmcnuDMsIc0vW917NFMT52taFSAjvAPjJ8h8d8lMddRiVj8?=
 =?us-ascii?Q?UV/k4L1Tei2zsbbTN2AsOeQ8wv2T3kZK3fZkXLNowo0Z+QcHXF3myMEBqw91?=
 =?us-ascii?Q?yFHVz4oLR47XhZgGKAPeXbP9VvEOc3Ea8L/V0Z42e+3qpJHq695wPgQrKAGL?=
 =?us-ascii?Q?NFdgUm7ba9qOVwMKKA3BiO4+baxpWbQicO7IULl0XZtqQlmFBu73YqYNRMK2?=
 =?us-ascii?Q?/sqZklkzKgNqkyUsKdgmeE2sFWq+Z8/Wib2gY+Yw78WoHrTBJDGF3kRcprnT?=
 =?us-ascii?Q?/rNKoxouJZzdrZ5hUZC6XZh+GJX+MCdhX/iPHHHFmqDrSIT9yHq+8MkvJ+xo?=
 =?us-ascii?Q?ii2PIXdTSQ0U/08iSUJF3pgdZnj7O3iGytyLIb7B9sactiIivbO+DXi7xiyz?=
 =?us-ascii?Q?4uLtDXLEEmBoYziIogoIyoS7UMwaE7o0/dEynw3l6FBR8LZVAJlQ/9NJ8g6i?=
 =?us-ascii?Q?we40YwMDg4NwPrbw5dMhrcmICq12QsSNTNHWHS2Siea7H8xPlYztyJU9N4yG?=
 =?us-ascii?Q?Sy5uAmah3fOKi1lEAsvJdIYRTRmYF5bSyi/aNjksPsiqG8pjgcWc0j4jmzTb?=
 =?us-ascii?Q?0UCSu9HOTn/CSFH+LvfXISh4/GQWFbP2a309GLgCGAb3uvuxzbS1CBf6s3qQ?=
 =?us-ascii?Q?TFm5LFY9VlJbBzr/JY4ZFMpMv26m+siieOc/yWDH45Lzb/w1P9/KWnGcvEMA?=
 =?us-ascii?Q?dhqeWUs7TgHpxqkFoFajqh9dxE8/ARyQaTPmTKPLgFXQlFFur5sBv/BKwYtz?=
 =?us-ascii?Q?Q++OWlhlSmKfn5e4asF9uIuk6bpfsjHQhoGfzHR31aFH7Ce+0wz1NfZSE3L9?=
 =?us-ascii?Q?aSoFuSgQh7w66W4gX8B1YWsGaYr4kX0lDOVsysHvdO47xgCz1vHailLH7gya?=
 =?us-ascii?Q?2PhP2TkxO6gbTenZCWfi7Gr3T5d5/yfrgyAcWxR4caUF6Aiz+8Dekh7LZK9R?=
 =?us-ascii?Q?h47rvgsz/dWf8pzUlsS9gsIhT26s3inqLR84zlBWszY5+GaQYmQDT0lN0BGy?=
 =?us-ascii?Q?Ds8wvs59UzzWf9nCrlzAZVSu2XsGBnTj/9CYgIxtOXY4iPjQKzVKgTezsSZ7?=
 =?us-ascii?Q?qgmfqaCtCJL1MVHqrms1SVIuqs4SMJ+0ScI7/wAgDY+xrY9pUYJA+ipwU1JX?=
 =?us-ascii?Q?gExHz7HC3xRmyvD93crKWdUrDHPRaERPLfxlMyLipHpav3xg3Hi4PgEOBKv9?=
 =?us-ascii?Q?cVTufGXOx70F67KlQXbT6vqUBLKGid5u8ZO9hJbYUlhlb90NihC2aJvRJT1X?=
 =?us-ascii?Q?r8coT4RrzkFH3goVzN7dmXuzvdTDETqA8PL5OPh5DPZj6eApu060TVgTUUDj?=
 =?us-ascii?Q?n4wxH96Q1KViMOf33XUGXtq507lruAfqLWB/3vFG?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?omc8i4qAHlCQNCDDe1wPobyJYrOWsutMBrrdoaV0AzWg1SEuPfZUAlauz1uM?=
 =?us-ascii?Q?zTHT71Z2tHaHs8j/Jrz5rQaW/FFrZ7xX/Ux0m5K+f4Javn/mBs81U3bKVqg3?=
 =?us-ascii?Q?KqFl9Qv2uTQ7tnuooxxP75YWnj93pFI1KhLHO/vrOEdSg0839K7jgSPLvyz1?=
 =?us-ascii?Q?Z8SsVz2Q59leAkZadWmbvRB1xsWJSzYdqnYcMOXRXLNhRzMbqp7vf48iv35B?=
 =?us-ascii?Q?ZVnOTU/rQOzZjmFCqzDQZWLRfj1NDVdK6t1ZyGwaRkaWyhRs/3I7TlJixstr?=
 =?us-ascii?Q?c9HjWvprybFdzNVZNuY/G9yvJERPE4N32zTw+eKbQHsIvBSAfN6z3KLxAxHT?=
 =?us-ascii?Q?/yCJ8D+6SUOC6/a2FkGXgTpkMzicA3QjBicyjyrCC0IgBc4UrnbbDLIGvBbh?=
 =?us-ascii?Q?58d51uelVeMAEGfXQlZa7ScYZZh9gstVrgao11V2a2ykSpEQFeJP5hO7z/LP?=
 =?us-ascii?Q?+5AerUqeqNfimVB8Lqq63f8j/IOqX0jnmzpJcIOOQv/0B6gZnwgr069kILZ6?=
 =?us-ascii?Q?CBlEmEUJhPeknGvNG8pY0rRnJtpV+bQC/CYlUt/LGgluCxU0GotH6O7J9T9p?=
 =?us-ascii?Q?Gf3mIJSSKYmCSDasv6ZZYg/qH+cCAoB1UlOB7MTpuHhnAuQ287Gx42BCDlK3?=
 =?us-ascii?Q?xuUSaPKz9TivTSP9aSe6xxcE04eeBgwOkUegsg5b6rO7Ldzu8dbRg8TEvzD4?=
 =?us-ascii?Q?1qL+ERGH0MeIYkEvXUVbTXmpgvo3jSbhx4dnaiGnrSmDuaqTiClIy+AhSQhE?=
 =?us-ascii?Q?zrqpm5sXKR+9visVW6NpK+McPTv6YhZoUqQ39AzajbTPUzrXXSsf3dDUxJtI?=
 =?us-ascii?Q?1FqhnJC8ObqMUdmf6k253/C7/Xfa0oGGMgzv7RSLbBi5AGegkXFBZp+05ZMn?=
 =?us-ascii?Q?ANUxL5gi1GQuDwTNBhysjdDawy49SatEyDSDy6cvsf2oOp3Z5HEgDXCVFm2x?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e1efc4ad-d0d8-4aea-1f80-08db4cf8bfc7
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2023 23:39:05.8620
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: sE0AmjSSn28ZhPe5ZyvUOc85i0zsvT3lj+QK73AoDw8OU7n4Flun99D3gFBaw9V5CPbVOHOAY5FPYpRqcehSEA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR10MB4706
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-05-04_14,2023-05-04_01,2023-02-09_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 malwarescore=0 adultscore=0
 suspectscore=0 mlxlogscore=999 phishscore=0 mlxscore=0 spamscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303200000
 definitions=main-2305040190
X-Proofpoint-ORIG-GUID: d5ZMGdwNyHUjklF-rr4dG08XuKHUc7aM
X-Proofpoint-GUID: d5ZMGdwNyHUjklF-rr4dG08XuKHUc7aM
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

A cover letter is not necessary for this single patch as all information
is present in the commit message.  However, I am not 100% comfortable in
this change and would REALLY like to get comments from Matthew.

When reporting this issue, Ackerley Tng suggested a solution by creating
a new filemap_has_folio() function[1].  I believe that would be an
acceptable way to proceed although we would also need to change the
other use of page_cache_next_miss in hugetlb.c.

When looking more closely, it looks like page_cache_next/prev_miss do
not work exactly as described.  The result is the following patch.

IIUC, prior to hugetlb use of page_cache_next/prev_miss, it was only
used by readahead code.  My patch does change the return value and has
potential to impact the readahead users.  That is why I am not 100%
comfortable with this.

In any case, this is broken in v6.3 so we need a fix.

[1] https://lore.kernel.org/linux-mm/cover.1683069252.git.ackerleytng@google.com/
Mike Kravetz (1):
  page cache: fix page_cache_next/prev_miss off by one

 mm/filemap.c | 26 ++++++++++++++++----------
 1 file changed, 16 insertions(+), 10 deletions(-)

-- 
2.40.0