Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e3083eab-ba85-3e9b-b3f2-f50816163f9f@amlogic.com>
Date:   Fri, 5 May 2023 10:37:41 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [PATCH V2] arm64: dts: add support for C3 based Amlogic AW409
Content-Language: en-US
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        linux-amlogic@lists.infradead.org, devicetree@vger.kernel.org
Cc:     Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will@kernel.org>,
        Neil Armstrong <neil.armstrong@linaro.org>,
        Kevin Hilman <khilman@baylibre.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
References: <20230427085859.793802-1-xianwei.zhao@amlogic.com>
 <36e7a445-7d19-911a-1a94-ffc30172e1a3@linaro.org>
From:   "xianwei.zhao" <xianwei.zhao@amlogic.com>
In-Reply-To: <36e7a445-7d19-911a-1a94-ffc30172e1a3@linaro.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VXpicTdVSDR5ZWtjZGZ2ZnVyNEhtUElmY2UvYXZUQWdxdmpjbGhmM083djFu?=
 =?utf-8?B?UEJTdjFUNXNDR01mbnBGT1RMRnhaeXZ0L0hhSkR1aXI2VE1TWTJoSE5Ybzk2?=
 =?utf-8?B?RDlDSXZhQ2dlMzJBNjlQNDFScS9vT1dDbStPRVo0QUkrRkozNTExeDRoeS9D?=
 =?utf-8?B?Q01FTFFMRHhOaWhJSnBIUW5ZVjBPUS9HMWFXWGhMdkR4V0VmeUFMSlhFYXVi?=
 =?utf-8?B?aVI3TEZCVWZrd2tnL2RYWG12RG5DV1EydU1GeCswM3NGREdjZ21PR1dMN1Vm?=
 =?utf-8?B?UHk5S2dTUFlCQTNZTW9CU08va3dJb2ROYnZlVUZHb3AxdWxWb3hta0RUQjI0?=
 =?utf-8?B?RzZ4OEIxbjRqdGJLbVA2bTE2bDJSa2xhVzVqUEFFVjhPaTZqODE3SjcwNU1R?=
 =?utf-8?B?akZOVVBPbFBXV2RteE92T05mdEN1SjQyZG4xR0hzZlAzR1ZrQVc1REo0ZGNP?=
 =?utf-8?B?WWgxV1ZvVGFmZHFIZnIzTGdaN3BKbjhCaHoyWlFrRUxrTzJGSnd5VStVR0ZP?=
 =?utf-8?B?VnVJT0xmbXdIU1cxV0FlZUxQdW56ZEZ4ZTdCRVFXMkpSdmdEdVd4WVp3dXFE?=
 =?utf-8?B?SDhXeTkrWnVSVVUwSHlBOTU4OWN4Y0dsa0lxWktmZjVveTZhTUJaSmF6WHpr?=
 =?utf-8?B?R0wzYk0xV0JrU05kblJmMzhZRytHcHhXNkhteVJ0QWJwNk8rNTVORk9SaDla?=
 =?utf-8?B?UkNXbUlRQ3c4dStyUkR0K0FHcFpMTVRwdE94NjBTV1ZHZXhuT1hzbHJpb0JN?=
 =?utf-8?B?WExvTE85ZFRRakJHY3Zram9VRnRvcVlnVE85UTdiZm9SaExpdUo3ZXlGRWhl?=
 =?utf-8?B?RUFPSWJnS1RpeEtDMUJRVDlTd3lnakM4REJYWXoyVEprS3lPU3kwUlkxbXJv?=
 =?utf-8?B?NnVzODZWQVV0dVcwanB5NExpUEFQeERIVDV3NVI4c0xOYlpOZTh3Z3FhN1Iw?=
 =?utf-8?B?a1B1VEJkS2NxNm5UcUtuVDJpS3M4QU5LQnphU0NNVlpYQ2F4ZDZpUmpQbk5m?=
 =?utf-8?B?L3BQZlBvN1BDQTM5d3NWenQ5OUlPM0Z0d0pGS1QyaVZRMHlvenpKUExBdDNC?=
 =?utf-8?B?N2R3Mk1naUNLVUtiaFZUdk5wdlQ0Nk9zaGY5WHQ5UFdMZysrbENVaCtqc2RD?=
 =?utf-8?B?UmxhV1RxaTVqTjhreXRtZjFPR3dBbWNtVkJXc1Era2lmTjUxVmxmNlZhNGpO?=
 =?utf-8?B?TGJDbEVHVWp4b0N0SHVaNGc1TzQ0VGZJK1J4NldpemhOMkRQOTQyU3M2ckNs?=
 =?utf-8?B?am5oVnR0WEEzNG9xREV6Z0pjSDdFOXp6d0xrZ0xRUjBvODN1clh6NGdtTVFl?=
 =?utf-8?B?K3lJM1RaUmtLeUtxZDE1Z2RYemFGMXIwL2FOakpjNXR5RTB0dHVJRGx6R213?=
 =?utf-8?B?WFlqb1lqbGpLTXRhV0diTTRlZnFXUFJRZFUzRnJLdEJETjZTTExhemJyakxC?=
 =?utf-8?B?YXFuZjBUclJrRm9GamNEWFdwd2EzL0NnRWY0YTdIbWNxOTJiV3dSYmJQVllx?=
 =?utf-8?B?cW8xaE0yamVaTDlWT1hGRXFpRXVlM3lCdlVrVU5iMkJKdnFWREM4RDJnZGVk?=
 =?utf-8?B?T2FMcDBQaFY2alBVQUFtOUFGcStjYVhqZUhLNkJ3RW9yUnZiL0JPellDNDcw?=
 =?utf-8?B?c0ZrdUVibjV5MjJhNUgvM1p4eWtCY2R2bWlJcXJFZjY5Z1R2OXlWeGhrSmZu?=
 =?utf-8?B?bXgzTy9WbW9JQkFLT00wYmVncWtYOTQ3K3o0MnFGZnR3L3grQnNWSHBrci9E?=
 =?utf-8?B?TGErVVhlL1BYakMrc0phYjRWRkJOK1FJVzlEWlMxRjFyR0p2VkRJVlB1enFH?=
 =?utf-8?B?SC9JSFZOV0lNZ0ZYaXhMZVQzcS90eHlGWWE2QUhVS3pLZlpQcG5RZ1NMM2RM?=
 =?utf-8?B?UDhocHN6djFpTlJ2UXA4OFVkVnBiOXRXZkdiZFE5V2lYM1J2bGlIZDdLamVz?=
 =?utf-8?B?NjdkZTYyZ3VsdFY3cDk0TkFOa3BDUm9MNGVFZVo0Nm9odGx5OEl2ZnlkOUxs?=
 =?utf-8?B?RDdwRVYySnJrSWFSZ2hzV01lZWRESmlYMmZ6aU5PY0g3VEk1TUMwZWZMWGly?=
 =?utf-8?B?VTlHVnNjUkRjdHVyZEZpaEVhSVZFbldnbUY3ZkpzSFRGcEhrR0praWx4VjhU?=
 =?utf-8?B?d0lxNjNJUHl5QkRaMzVLaUtwNWNaMFpnWVdaNmV0U1hQM1dNMjVaQUpaa1M2?=
 =?utf-8?B?bmc9PQ==?=
X-OriginatorOrg: amlogic.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4c2990ac-b739-4271-5425-08db4d11b54c
X-MS-Exchange-CrossTenant-AuthSource: SG2PR03MB2734.apcprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2023 02:37:45.8728
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 0df2add9-25ca-4b3a-acb4-c99ddf0b1114
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 7UWH5crrJnXvK6AY8tergQM/SErTlcfcOFe/aH5JCHd2UquAorvyKlQ4AIXRmldPlqI10qp6ysi/LURZ7+o9uRc2rgB37Zqrz3e533BNwbo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PUZPR03MB6104
X-Spam-Status: No, score=-6.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Krzysztof,
      Thank you for your reply.

On 2023/5/1 17:58, Krzysztof Kozlowski wrote:
> [你通常不会收到来自 krzysztof.kozlowski@linaro.org 的电子邮件。请访问 https://aka.ms/LearnAboutSenderIdentification，以了解这一点为什么很重要]
> 
> [ EXTERNAL EMAIL ]
> 
> On 27/04/2023 10:58, Xianwei Zhao wrote:
>> Amlogic C3 is an advanced edge AI processor designed for smart IP camera
>> applications.
>>
>> Add basic support for the C3 based Amlogic AW409 board, which describes
>> the following components: CPU, GIC, IRQ, Timer, UART. It's capable of
>> booting up into the serial console.
>>
>> Signed-off-by: Xianwei Zhao <xianwei.zhao@amlogic.com>
>>
>> ---
>> V1 -> V2: Remove new arch, and use ARCH_MESON;
>>            Modify node name, and delete superfluous blank lines.
>> ---
>>   arch/arm64/boot/dts/amlogic/Makefile          |  1 +
>>   .../amlogic/amlogic-c3-c302x-aw409-256m.dts   | 29 +++++++
>>   arch/arm64/boot/dts/amlogic/amlogic-c3.dtsi   | 86 +++++++++++++++++++
>>   3 files changed, 116 insertions(+)
>>   create mode 100644 arch/arm64/boot/dts/amlogic/amlogic-c3-c302x-aw409-256m.dts
>>   create mode 100644 arch/arm64/boot/dts/amlogic/amlogic-c3.dtsi
>>
>> diff --git a/arch/arm64/boot/dts/amlogic/Makefile b/arch/arm64/boot/dts/amlogic/Makefile
>> index cd1c5b04890a..bcec872c2444 100644
>> --- a/arch/arm64/boot/dts/amlogic/Makefile
>> +++ b/arch/arm64/boot/dts/amlogic/Makefile
>> @@ -74,3 +74,4 @@ dtb-$(CONFIG_ARCH_MESON) += meson-sm1-odroid-hc4.dtb
>>   dtb-$(CONFIG_ARCH_MESON) += meson-sm1-sei610.dtb
>>   dtb-$(CONFIG_ARCH_MESON) += meson-sm1-x96-air-gbit.dtb
>>   dtb-$(CONFIG_ARCH_MESON) += meson-sm1-x96-air.dtb
>> +dtb-$(CONFIG_ARCH_MESON) += amlogic-c3-c302x-aw409-256m.dtb
> 
> Looks wrongly ordered. 'a' is before 'm'.
Will do.
> 
>> diff --git a/arch/arm64/boot/dts/amlogic/amlogic-c3-c302x-aw409-256m.dts b/arch/arm64/boot/dts/amlogic/amlogic-c3-c302x-aw409-256m.dts
>> new file mode 100644
>> index 000000000000..edce8850b338
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/amlogic/amlogic-c3-c302x-aw409-256m.dts
>> @@ -0,0 +1,29 @@
>> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
>> +/*
>> + * Copyright (c) 2021 Amlogic, Inc. All rights reserved.
>> + */
>> +
>> +/dts-v1/;
>> +
>> +#include "amlogic-c3.dtsi"
>> +
>> +/ {
>> +     model = "Amlogic C302 aw409 Development Board";
>> +     compatible = "amlogic,aw409", "amlogic,c3";
> 
> Missing bindings.
> 
> Please run scripts/checkpatch.pl and fix reported warnings.
> 
The bindings committed by Neil, it is applied to 
https://git.kernel.org/pub/scm/linux/kernel/git/amlogic/linux.git 
(v6.5/arm64-dt),
bindings: 
https://lore.kernel.org/all/20230407102704.1055152-1-kelvin.zhang@amlogic.com/
> Best regards,
> Krzysztof
>