Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: i5ec1447f:Fastmail
Date:   Fri, 05 May 2023 16:36:10 +1200
From:   Luke Jones <luke@ljones.dev>
Subject: Re: [PATCH] platform/x86: asus-wmi: add support for ASUS screenpad
To:     =?iso-8859-2?q?Barnab=E1s_P=F5cze?= <pobrn@protonmail.com>
Cc:     platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org,
        acpi4asus-user@lists.sourceforge.net, hdegoede@redhat.com,
        corentin.chary@gmail.com, markgross@kernel.org, jdelvare@suse.com,
        linux@roeck-us.net
Message-Id: <AS46UR.T68QO79EHLHI3@ljones.dev>
In-Reply-To: <R0Q3UR.1AXX7YQ75CIN1@ljones.dev>
References: <20230503040207.257406-1-luke@ljones.dev>
        <_BfjSVwlhmByGevAd1Yo_jhipUa3r6y5HHSi34xdeaYqelyPe1PRnOEru21Yw76x0spJwAAs3jr0MJ0f_jUc8QY75Q1J1ovT5QPvm0p2WhY=@protonmail.com>
        <R0Q3UR.1AXX7YQ75CIN1@ljones.dev>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-2; format=flowed
Content-Transfer-Encoding: quoted-printable
Precedence: bulk


On Thu, May 4 2023 at 09:22:03 +1200, Luke Jones <luke@ljones.dev>=20
wrote:
>=20
>=20
> On Wed, May 3 2023 at 17:46:53 +0000, Barnab=E1s P=F5cze=20
> <pobrn@protonmail.com> wrote:
>> Hi
>>=20
>>=20
>> 2023. m=E1jus 3., szerda 6:02 keltez=E9ssel, Luke D. Jones=20
>> =7F<luke@ljones.dev> =EDrta:
>>=20
>>>  Add support for the WMI methods used to turn off and adjust the
>>>  brightness of the secondary "screenpad" device found on some=20
>>> =7F=7Fhigh-end
>>>  ASUS laptops like the GX650P series and others.
>>=20
>> Is it this one: https://www.asus.com/content/rog-screenpad-plus/ ?
>> Or is the "plus" version something different?
>>=20
>> If it's a "proper" screen, wouldn't it be better to add support for=20
>> it
>> in the respective subsystems? E.g. why not register a backlight=20
>> =7Fdevice?
>=20
> I think it is similar yes, likely the same thing.
>=20
> Adding as a proper backlight is what I wanted to do but at first=20
> blush I wasn't sure.
>=20
> Looking at include/linux/backlight.h + some examples it looks clear=20
> now. I'll try to
> work up a revised patch and get it tested by the folks with the=20
> actual laptop.
>=20
> My only possible issue would be how to handle the on/off part?
>=20
> Cheers,
> Luke.

This has now been addressed with "[PATCH v2 0/1] platform/x86:=20
asus-wmi: add support for ASUS screenpad" at=20
https://lkml.org/lkml/2023/5/5/9