Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Sender: Guenter Roeck <groeck7@gmail.com>
Message-ID: <49ea68fd-6468-c61a-fb7a-6ef2f0497542@roeck-us.net>
Date:   Thu, 4 May 2023 21:32:28 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [RFC 05/11] Documentation/hwmon: Revise PMBus core documentation
Content-Language: en-US
To:     Bagas Sanjaya <bagasdotme@gmail.com>, James Seo <james@equiv.tech>,
        Jean Delvare <jdelvare@suse.com>,
        Jonathan Corbet <corbet@lwn.net>
Cc:     linux-hwmon@vger.kernel.org, linux-doc@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20230504075752.1320967-1-james@equiv.tech>
 <20230504075752.1320967-6-james@equiv.tech> <ZFSFzaWZsS9qxmzz@debian.me>
From:   Guenter Roeck <linux@roeck-us.net>
In-Reply-To: <ZFSFzaWZsS9qxmzz@debian.me>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 5/4/23 21:27, Bagas Sanjaya wrote:
> On Thu, May 04, 2023 at 12:57:46AM -0700, James Seo wrote:
>> -[from pmbus.org] The Power Management Bus (PMBus) is an open standard
>> -power-management protocol with a fully defined command language that facilitates
>> -communication with power converters and other devices in a power system. The
>> -protocol is implemented over the industry-standard SMBus serial interface and
>> -enables programming, control, and real-time monitoring of compliant power
>> -conversion products. This flexible and highly versatile standard allows for
>> -communication between devices based on both analog and digital technologies, and
>> -provides true interoperability which will reduce design complexity and shorten
>> -time to market for power system designers. Pioneered by leading power supply and
>> -semiconductor companies, this open power system standard is maintained and
>> -promoted by the PMBus Implementers Forum (PMBus-IF), comprising 30+ adopters
>> -with the objective to provide support to, and facilitate adoption among, users.
>> +  The Power Management Bus (PMBus) is an open standard power-management protocol
>> +  with a fully defined command language that facilitates communication with
>> +  power converters and other devices in a power system. The protocol is
>> +  implemented over the industry-standard SMBus serial interface and enables
>> +  programming, control, and real-time monitoring of compliant power conversion
>> +  products. This flexible and highly versatile standard allows for communication
>> +  between devices based on both analog and digital technologies, and provides
>> +  true interoperability which will reduce design complexity and shorten time to
>> +  market for power system designers. Pioneered by leading power supply and
>> +  semiconductor companies, this open power system standard is maintained and
>> +  promoted by the PMBus Implementers Forum (PMBus-IF), comprising 30+ adopters
>> +  with the objective to provide support to, and facilitate adoption among,
>> +  users.
>> +
>> +    (from pmbus.org)
> 
> Seems like a candidate for attribution:
> 

Yes, and I do not feel comfortable removing it.

Guenter

> ---- >8 ----
> diff --git a/Documentation/hwmon/pmbus-core.rst b/Documentation/hwmon/pmbus-core.rst
> index 2f88a03446d2be..75404f088fd777 100644
> --- a/Documentation/hwmon/pmbus-core.rst
> +++ b/Documentation/hwmon/pmbus-core.rst
> @@ -21,7 +21,7 @@ Introduction
>     with the objective to provide support to, and facilitate adoption among,
>     users.
>   
> -    (from pmbus.org)
> +  -- (from pmbus.org)
>   
>   Unfortunately, while PMBus commands are standardized, there are no mandatory
>   commands, and manufacturers can add as many non-standard commands as they like.
> 
> Otherwise the formatting LGTM, thanks!
> 
> Reviewed-by: Bagas Sanjaya <bagasdotme@gmail.com>
>