Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp470419rwr; Thu, 4 May 2023 23:20:21 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ43F92jcabpqV4t+fbfWM1xRzitXc7//XfCmvfNbbiw1yXBitRvNnzt5AX7xkiYZtyMp129 X-Received: by 2002:a05:6a21:348b:b0:f2:e4c1:af7a with SMTP id yo11-20020a056a21348b00b000f2e4c1af7amr490829pzb.7.1683267621717; Thu, 04 May 2023 23:20:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683267621; cv=none; d=google.com; s=arc-20160816; b=J+oVR35yTY3ySnuE6Ay4jthlWSRkFaC9/o1Le4VtjdsEt5Gin2zeVaFsxgBO2Zzbk9 6UUkQsX/D2I5p7gnnwnpLDUX+En5pBINkHEtYbJZ7hblolOMVrQ1OD4SDWl5k3QO4LT3 qmHepYUBaCU3V/lVSoCg+71sz8LmD7iS9G9BEupwVr/EfFdkV+XzlmBZfx91lXQLjMyO O+gKqoa0sFM6ceGgO6M3nFbXxK2FpMkAVomP8uo50sRrZLEphCGjeRLuf2Nc2sSg4lsL Fz+96pz7B6ykUGpVNRGOXlO40PlITBvZcg0XDJilbrqqQhrpSbwHp2HnAJt25/7CMnQl dfSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=4DeFmeC/RVKYpI1DUBjLp/8O6Tz99hhW4POLRvqwKCc=; b=df7YoX5ktojtSRbfaZRu8j8AmqUP/x3e2iAk55QttXkXPGKnGQq9nNQRVYARYaGfF3 w3Fv5Rr/F8iuRU1PwtlOImmu4iNI0tGYHDOS3kl+wM2bPmCSnFj2FNUgZ4fVw6furPLT MoMXw2jS3cO9ynPXGKe3cHgSDgn0UVrz4qAXDHuZUaIvgxh6i36FdDHcPin7MDfkMY/V euOyrbNILjahmc9IUXSxRTUH+7/IvO865O9cBkIogT7AgyWt97Z80+q+UPfkv4uyP8bC 86PY93NXtyiQ9oqdlm/x9MjNNcZRA/Y3A/5vwPFdo0PvS+qKTcWMlfxgyK4VZhqfJGxN Nu4A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id bt8-20020a632908000000b00502f4fd0c16si1186336pgb.653.2023.05.04.23.20.06; Thu, 04 May 2023 23:20:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230123AbjEEGJu (ORCPT + 99 others); Fri, 5 May 2023 02:09:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42596 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229986AbjEEGJt (ORCPT ); Fri, 5 May 2023 02:09:49 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 22951150EC; Thu, 4 May 2023 23:09:46 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id 200BD68B05; Fri, 5 May 2023 08:09:42 +0200 (CEST) Date: Fri, 5 May 2023 08:09:41 +0200 From: Christoph Hellwig To: Matthew Wilcox Cc: Andreas Hindborg , Jens Axboe , Christoph Hellwig , Keith Busch , Damien Le Moal , Hannes Reinecke , lsf-pc@lists.linux-foundation.org, rust-for-linux@vger.kernel.org, linux-block@vger.kernel.org, Miguel Ojeda , Alex Gaynor , Wedson Almeida Filho , Boqun Feng , Gary Guo , =?iso-8859-1?Q?Bj=F6rn?= Roy Baron , Benno Lossin , open list , gost.dev@samsung.com Subject: Re: [RFC PATCH 01/11] rust: add radix tree abstraction Message-ID: <20230505060941.GA12147@lst.de> References: <20230503090708.2524310-1-nmi@metaspace.dk> <20230503090708.2524310-2-nmi@metaspace.dk> <87wn1ns7kt.fsf@metaspace.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 05, 2023 at 06:28:04AM +0100, Matthew Wilcox wrote: > But the radix tree API is simply a different (and worse) API to the > exact same data structure as the XArray. Using the XArray instead of > the radix tree is still an apples-to-apples comparison. And if he wants to do a 1:1 comparism, just convert null_blk to xarray, which would actually be more useful work than this whole thread..