Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Clark Wang <xiaoning.wang@nxp.com>
To:     broonie@kernel.org
Cc:     linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] spi: lpspi: disable lpspi module irq in DMA mode
Date:   Fri,  5 May 2023 14:35:57 +0800
Message-Id: <20230505063557.3962220-1-xiaoning.wang@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?a9pgBCE/Q6WE+xkqSw1J5/zXAVdEKP6ilgYzdvfO9koy3tdTCifbgVkjdiqq?=
 =?us-ascii?Q?q6f2QM91VrYyByDI9zUPKj+/AvB/8xTBpyvNXAAJUkZdoPz387wveSWcEqZp?=
 =?us-ascii?Q?0sbgOEnaatgLVLp5Sh+X1XfmKTvpwQ1nH080+OaB4HJYjMICSRyVC6JxayLC?=
 =?us-ascii?Q?x1rTEnS2nfMetXkx2ENNhOtK2/NG38tMLw+mvHwvDE/WoHc1XBwLaA4NTsp2?=
 =?us-ascii?Q?v6HBAVKVThAe4y76RIh90/W0oy98uEEWyV0rUGZx89sLWzjRHr/AsrqYji5C?=
 =?us-ascii?Q?L/OR918Q5JrfLF/cWiafE/HeKalsxRFmtrkvQNvu6jyNNmHCfHFYhvsa/0+9?=
 =?us-ascii?Q?SqUy7ot2C0zSQ6mIeve9jYheX5Z/3CSREYBI/G44bo5X/oaVxKG3XyyerOat?=
 =?us-ascii?Q?bv0lUr8KLoueVgiQBsIfXz23oJPQzOoIlWGlL1cq5nXrTlbHc++Pzwi8cqRJ?=
 =?us-ascii?Q?JWQh3KIFLHciSOR1BGHVjsTBOucdWRpO7XiD3IUBF2fywJ02L8YhegYlHBTj?=
 =?us-ascii?Q?raA3gFrVnmsckQMIYCfTdPUzDaje3e6ngOA1p8oU/70Y58WafuIR02+Jq69O?=
 =?us-ascii?Q?gPa5nd618rySd6EPLAzoiI651stkHTx9tZMLt9g1+rZpWei2h+62/29pVvxv?=
 =?us-ascii?Q?xApiw6OwnWGRLr6POHDoyC9ikfOOiieTq5zHHYDuRzJ+Zz5SXeKZsoG2wrP/?=
 =?us-ascii?Q?AvkhlyK98oG8wG2RnlMl8S+lvtdg7OKSwL/egXueyLSzCNy+oJ6z+NgCRsvL?=
 =?us-ascii?Q?3jAZZY1eMiAXq298l2Qh9UAF7Idjbx5p9Jdq9zpMLEZooxsR52Ac9lT8ht49?=
 =?us-ascii?Q?CJIi6AKVjR7Kspg3OqljCaATfU+QcH1olLhzGuR47udWsRXQRuVarij8QzMq?=
 =?us-ascii?Q?SBUaqd1ws4m+/LZWPqGG3bfPzlxBetGGcWm+uzrnlYvJLLE4xHoRVFTEx3CC?=
 =?us-ascii?Q?9fSirnROjGtn3j0/Pgkcyv3TOeNmEdu9kYBuOBAVBSKpuL8SNca8hznlzkCl?=
 =?us-ascii?Q?ljx+PpqyI0G/noGPk6fD3qgBrMqEL6e0xcSX85D72kWz9VG6BI/E4+8Yf0FS?=
 =?us-ascii?Q?kN2I0U3vv6d+uFLbvbxRiGxhKp/H58hO6bbO6RA0mIgo8NAi+puj5MAaxahx?=
 =?us-ascii?Q?CjCbyiPnuI8XaEWzhAIIN07TecG4yq1Wr/yvl7IPUk9VFCutR9XE/nIHzerw?=
 =?us-ascii?Q?RYprYxmG9L6IC/SFQJiTBMYr3gdPrfjPJDudKtbjS3BTOI36BlRqT2JoCFyG?=
 =?us-ascii?Q?QZF6HVoJHtaSGubaYrtzuU/5Ap3UsBBZPnj10JzAfJ9NCQUHRdOTAyjKfLvi?=
 =?us-ascii?Q?n80T9VyoXofan5x5POiTw94+g6YeJt1FWx2fnJxvpKZpoET3R2FlHfm4Vq58?=
 =?us-ascii?Q?zngT5B93DtHa79gvHYkIyL0eICTLp+3fWbSmUYwacCur6AAMgN4YIcOtvPyA?=
 =?us-ascii?Q?kV3zIPrf1/mWJAdhdXnAwt8K/r2s5BPc6UJp8i/2hzOO+hfObgtNfAV1Iu8R?=
 =?us-ascii?Q?8iuTZmNcEoEYQnEqkuge0sm95/gwopJfFo213lyeG4twELlpKRZoBYUIzePg?=
 =?us-ascii?Q?SniIn9fdTlldLi05THYLzejmx3XsZB9aROzSS02a?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0d95bc8f-6500-467b-9907-08db4d32faed
X-MS-Exchange-CrossTenant-AuthSource: DB7PR04MB5098.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2023 06:35:56.0684
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hanv0/v+vlUg1yk+ov7T7x/A00vssKTJAdt35AnBqwpBNaPNFvnK0KHVWZH9X9ivR2BbKLYVCoKvDOSZk2SBkQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB9132
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

When all bits of IER are set to 0, we still can observe the lpspi irq events
when using DMA mode to transfer data.

So disable irq to avoid the too much irq events.

Signed-off-by: Clark Wang <xiaoning.wang@nxp.com>
---
 drivers/spi/spi-fsl-lpspi.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/drivers/spi/spi-fsl-lpspi.c b/drivers/spi/spi-fsl-lpspi.c
index f2341ab99556..4b70038ceb6b 100644
--- a/drivers/spi/spi-fsl-lpspi.c
+++ b/drivers/spi/spi-fsl-lpspi.c
@@ -910,9 +910,14 @@ static int fsl_lpspi_probe(struct platform_device *pdev)
 	ret = fsl_lpspi_dma_init(&pdev->dev, fsl_lpspi, controller);
 	if (ret == -EPROBE_DEFER)
 		goto out_pm_get;
-
 	if (ret < 0)
 		dev_err(&pdev->dev, "dma setup error %d, use pio\n", ret);
+	else
+		/*
+		 * disable LPSPI module IRQ when enable DMA mode successfully,
+		 * to prevent the unexpected LPSPI module IRQ events.
+		 */
+		disable_irq(irq);
 
 	ret = devm_spi_register_controller(&pdev->dev, controller);
 	if (ret < 0) {
-- 
2.34.1