Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Clark Wang <xiaoning.wang@nxp.com>
To:     broonie@kernel.org
Cc:     linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] spi: lpspi: run transfer speed_hz sanity check
Date:   Fri,  5 May 2023 14:41:59 +0800
Message-Id: <20230505064159.3964473-1-xiaoning.wang@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?RTOQKrQ63Lqa1NmckLXpntbQl2TKGwGM7C4PRok9BSvQrY1UrpEGSt9rlQUy?=
 =?us-ascii?Q?1XkC90WIxBhs89eCb1wrj0Lbt9X5ZBLWH/e89u4q8HxtPTZN6oKeB5JtV3aM?=
 =?us-ascii?Q?g/yG8YDOYn5mX3zxVHA91HSp9yDPQO28INGByvh+PfN7By9tXJveVEuCHvJR?=
 =?us-ascii?Q?5VAz/aUjKRCyfZdG/9umaAwywZhMyB6YHl3gFg99JjSexHT4eqnpzjxnxDS9?=
 =?us-ascii?Q?j0kDkzc57hXLhN82mDMFSiU8aa4eyrt6upNje7jdTSytrTpZn3hPq4vnPxC1?=
 =?us-ascii?Q?ZSnkSwe70y2rnyl1gWP5e2gvtZB50Y1QzZwJlffaEsTJKKZ/CFPwtaCHkHuB?=
 =?us-ascii?Q?O9vivOWYkVDZydA+uWymFuEgMG+H4rEVCsLIorNb5ANBxzKRV01zWUP/yeVo?=
 =?us-ascii?Q?1pejAhzxBHrGIodDOPWGB/7uEEzFOO/83zYiRahk1ZAD3gO/HkG+OwDzx6nQ?=
 =?us-ascii?Q?Qiv2oe88UnAQ/Q+aaGYWHHyS9BZoXKv/ql4E6h4eFgXA8XOSc6I7LQvPn/jy?=
 =?us-ascii?Q?va4AANChoWTjPTIUzBPUwMcRgt/UbX4KfxVYYAfJ6SPz5WSKab8ETg27oooA?=
 =?us-ascii?Q?nnJ/cu3kfGCq4kowSAOMVJmd4V24hUlG5AyAO7eTLwi4uyPw0Fi1YSKHAUs8?=
 =?us-ascii?Q?HMXPk1jaW7BQ5BcKY9oiFj2CQX3QQtNA8WxR0P/CVFrtg/vfQnsqxv+N11Xq?=
 =?us-ascii?Q?bSb91n3QMqaErLgJUPJC1RSGYkA55ZXHY2WXJEtOQpyKpidy+fWzfrlcsNrn?=
 =?us-ascii?Q?JOlV63JTMF/AJaxwa1RMTHb2OMatJ8AK488IKAmU8iYugUhElOBoMO9akcDF?=
 =?us-ascii?Q?tMYLKR15kGbrh0kYXShSyGvYBSvV4fF8fSS1Rf71DJ/olhRgtgI5So07kaSX?=
 =?us-ascii?Q?NSaApCIaUC/GtJHQ5GkFg91K+kwu9YFGXfiPJVzEKex1CPYEo2aKZMNFDuFN?=
 =?us-ascii?Q?0mvVrArHMfc9D90ekAptYscMzrSvItCQgI/ylnmydk2SNG5skJYN1xMftutQ?=
 =?us-ascii?Q?cLCCU4h3/qio/wp0sJu/OxdpQF4O19KElUeMx02QwNM2VtZbv/5hseur1ZSI?=
 =?us-ascii?Q?hr0GvFCzm0/iBK3wOs6iXGiIMjDzmVVGFYDakEgTOJdBj+igzKALHAAE15QF?=
 =?us-ascii?Q?To9heRghClSYlBIJR16W9P6khZ4Qx3sbSves1aNg+xJ1+bTqRU8XaFXL9xIr?=
 =?us-ascii?Q?RnlHo6hCzZ5VEgItPDvT+O+CHqcsRKlfVPZPegSsqw5UBa/u80m1VoV4mjIF?=
 =?us-ascii?Q?gVOnA53pQo27T+3Qax+yOMlkzp6C0gpk+bLBsRUrL+58gE7vVf06HeWfvuZd?=
 =?us-ascii?Q?U19CkYokJ/cidfz/MGoZUMnYWemdqTtXkFbnGMUsq8r2kpWqaIoS/zwCYdvC?=
 =?us-ascii?Q?wYzXLjXf3VWxV8Poo5VRG3f4JFX9cJbz7MaKfG6AMazwGKF6rsuEvN44KJke?=
 =?us-ascii?Q?RTF7DF0Mwm9eET8C8oWGzgNcnW4O8nnyupn+kRkiLOUUGaIvBGft2JiyexsB?=
 =?us-ascii?Q?iLeweYK616SXZFb4T5Na0eGQAW/94JUDpVQRapZfzG9QGmgSvo7tyflPm/JP?=
 =?us-ascii?Q?vd7aH4R3GMD82trF/7x+TO3hcOXu3RVwSNk5ospi?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f5d5f23e-9653-438a-6422-08db4d33d112
X-MS-Exchange-CrossTenant-AuthSource: DB7PR04MB5098.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2023 06:41:55.2418
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: xWUugfgeM29P+r+iUIeSfz8k4mbjeWKgg4HitwTC8ytvk25Yg89qEJ3jwVPCqjx0aTrDQxttCe5N/7Gha7H1oQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB7309
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Avoid config.speed_hz is 0 when it is a divisor.

Signed-off-by: Han Xu <han.xu@nxp.com>
Signed-off-by: Clark Wang <xiaoning.wang@nxp.com>
---
 drivers/spi/spi-fsl-lpspi.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/spi/spi-fsl-lpspi.c b/drivers/spi/spi-fsl-lpspi.c
index 4b70038ceb6b..80f7367095ab 100644
--- a/drivers/spi/spi-fsl-lpspi.c
+++ b/drivers/spi/spi-fsl-lpspi.c
@@ -303,6 +303,12 @@ static int fsl_lpspi_set_bitrate(struct fsl_lpspi_data *fsl_lpspi)
 
 	perclk_rate = clk_get_rate(fsl_lpspi->clk_per);
 
+	if (!config.speed_hz) {
+		dev_err(fsl_lpspi->dev,
+			"error: the transmission speed provided is 0!\n");
+		return -EINVAL;
+	}
+
 	if (config.speed_hz > perclk_rate / 2) {
 		dev_err(fsl_lpspi->dev,
 		      "per-clk should be at least two times of transfer speed");
-- 
2.34.1