Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <04b2a566-ed83-1e47-1571-e3d5ae4d3323@amlogic.com>
Date:   Fri, 5 May 2023 14:43:18 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [PATCH V2] arm64: dts: add support for C3 based Amlogic AW409
Content-Language: en-US
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        linux-amlogic@lists.infradead.org, devicetree@vger.kernel.org
Cc:     Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will@kernel.org>,
        Neil Armstrong <neil.armstrong@linaro.org>,
        Kevin Hilman <khilman@baylibre.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
References: <20230427085859.793802-1-xianwei.zhao@amlogic.com>
 <36e7a445-7d19-911a-1a94-ffc30172e1a3@linaro.org>
 <e3083eab-ba85-3e9b-b3f2-f50816163f9f@amlogic.com>
 <d2ca44b1-71ab-093f-0dee-fa66e4aa378a@linaro.org>
From:   "xianwei.zhao" <xianwei.zhao@amlogic.com>
In-Reply-To: <d2ca44b1-71ab-093f-0dee-fa66e4aa378a@linaro.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Y1IzU1QrSm9Ta2N0QkJiMWVBMlJKVEN5WnIvRmJXc3BjblgwNDk2cmlEN1Ba?=
 =?utf-8?B?UDMwMm1JQWRJT0RKZ1A1Y0p6UVAxWVd4VDRPcWJsMGJBQ1Brc2V2aHQ1QzVl?=
 =?utf-8?B?TnlTV25yTUV3anBBRHhxMk9iRm43Zk9MdXBWd2dmSFZJMVJWVklWU1RoVTBF?=
 =?utf-8?B?bXNmMEFLZDBFcEFuM29acVVBdUZtQlJhMlN2NlFvNVFSOC9qbVhpNGNlYW9R?=
 =?utf-8?B?dmZxejlzU2pNUW95TjZ5SERNZEFEaDFpa1ovbjZGc1B1VForU0R1bFFaN05j?=
 =?utf-8?B?WXRxZDEyNzFzRWtTRTFjYWZnanZKeGZVdm9xL2x5SktWaE1EV1N3RXVwTWdv?=
 =?utf-8?B?NmtiU21QSkc0YytJeU5QVmRjOE1lU1FoYkdxL1ZKYTFTd0pQSmFEZ3dsTDVB?=
 =?utf-8?B?ajB4ZmZhU0I4cmFDMmZOVXpzang3MXNTdkljRERpNTkxcVpxbmpQQUMvU0R6?=
 =?utf-8?B?VUNqR3hZS1FMUm96Q3JBRmgzbktFNVJ3VzB4dnJMMGtheDBKK0lLdWlRR09a?=
 =?utf-8?B?VUNtNm1XOXhoT1hnMSt3MGlTOUFXTlFPbmdHWkZDQ2hSQ0RoNEYwMUFZVXN0?=
 =?utf-8?B?eUE4amZBd1NvaXRGcXlvSzY5WEhHK3FiT0NqMnpPbTdrYTZhOXBaaWJWMFlH?=
 =?utf-8?B?QmFSUFM0L21CM0VSNVBJWlE0Q2tncFg4RXFLOG15UXpWeHFET3JhRTBBaVgz?=
 =?utf-8?B?aW5GdXRHWUdDQkl2Wm9OenlBcDZHbEgxNzBQZlgvUGpXSUYrdmtmenByS1p4?=
 =?utf-8?B?OU0rQ1BkMFVML1R0cklQempYU1RqZXdWeVZ3ZUZEc0dybUROUWRqTEUrWXpo?=
 =?utf-8?B?MWM4c3NsczA5NHhBRVpQcjdkam1sbFRNaFBZSmNUZFVmcmZwa3FMY2FhODNm?=
 =?utf-8?B?OFZFN1U4a1BIK01wL1dWc1FzM2w1ZGt0ZEhNUWw0NFRDTVBGSDNnTjBlNTFG?=
 =?utf-8?B?Njh2bFRybE5tL29KS1VUVzNiTXFwSFpUSXZCSUk0QXBCTTZCaWRJaGJYaEYy?=
 =?utf-8?B?T2MyZXpLeDlvUzVPaWtMOW9wTDJibStsc2lJQ25abjhxQ2VHZEpJYTlXcWww?=
 =?utf-8?B?QW16bE5Cd2s2Nm4yaUdBWG9BenFPZ2hydW5xcnJZeWFObzRHWEhvSkRVUXAx?=
 =?utf-8?B?eUduQS93eStJSitLcE01eS9oTDhiTittb3p6K3ZQQVFjVXFMOExjZVk0ditO?=
 =?utf-8?B?enJWSHJzeHI3U2crb1UzbzBSVUkrcjFBQ2RabGNHVjV5ZmR3NENjblJaTlNG?=
 =?utf-8?B?NUVuL0UyQ0ZTOERZZkhjSWd5N2QxQm53V2hUQnVMK1J1Z29WaFRFSVphekw5?=
 =?utf-8?B?S0dJYmZvSlJIaHp4RmFkUldIb1VZT1ZlN2pabXE1ZVVaOXlwaXFmSzJaaVdq?=
 =?utf-8?B?NXI1SFhNQjNOY1ZEc3ZNMnNFYlhzSUMxQlptb0I0cFF3OHVsWVZ3WmZGaExT?=
 =?utf-8?B?S2ZoaExYVVFjQmZYTnpXTUFxSHF5RHdERlJNRFVrd0dtb3V4RlVIRkc3Qmpr?=
 =?utf-8?B?WWcrSkxCL0xOWHhWNFcrYXczYUxGTXlTUnEySzg5MVdGL2NXcldQbngvY0pt?=
 =?utf-8?B?cHNYWjduSFlJbG1xM01aOUV5bUJCTnkyck9Cb1pzbzNzYVJHUW1kMC9Kb1Bi?=
 =?utf-8?B?NGgyNFhUSlhCU2tNTlpQMlZkVE04YlA4eHlnRXcwQ2NCVkJUcnY1RkY3QWlO?=
 =?utf-8?B?Q21hZFFtaHFKNDhGeWpMMHlIeTc1Q09nRWR2ZWdlQk9iaVhUZXNXOHJSOFlz?=
 =?utf-8?B?Ui9XRkhVWWdpVkNYcTZwWktybW1xcGVoSTNwRGhvQXFZWDRwOGEvMERpNm9a?=
 =?utf-8?B?YmNHOWdBbzJQTkFUeFFwY0VHZzNwSktCUUc1NFJCK0pBWGxRNWMvOUVhNk5R?=
 =?utf-8?B?aWc2V0d1UnF5ZkR1YVU3azlEeVcvWVgxbngwaG9UYS9mQk5aRXhld2xBOHpF?=
 =?utf-8?B?THJGdTI5L2RmS2drdWZnMzg2VnhKcDJGb2Zlb3FwSFdwLzRTU1hQeEhGNGdU?=
 =?utf-8?B?WlhCZEdhd1k0WGp0R1FTeTk0b3NuVUpQalJJeVhvdnQyc215SG40WWpMRnRN?=
 =?utf-8?B?YVRucVhJaEp5RUwyL1F3RnRtQzZKSERpZE1GWU5mOUNEaHIvZllhems5Mms0?=
 =?utf-8?B?d1JTNHN2eW43Wm85RzMzTHdNSVpLZVNGMTlwL2ZjTFBQd1NhRUhWV1FnUWR5?=
 =?utf-8?B?R1E9PQ==?=
X-OriginatorOrg: amlogic.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0b725ff9-9552-414a-91a3-08db4d34cff6
X-MS-Exchange-CrossTenant-AuthSource: SG2PR03MB2734.apcprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2023 06:49:03.9287
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 0df2add9-25ca-4b3a-acb4-c99ddf0b1114
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: WoB1wNEGGVWom+X08Aq2uKEOELGAC4ISsUsLfKsrLqiiZWQC+uEC0QIgc1te1tV43lF/Ewe/bZWKDCrolMCDNvGC2PzwQQE2du/56Cn7kEU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEYPR03MB7250
X-Spam-Status: No, score=-6.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 2023/5/5 14:34, Krzysztof Kozlowski wrote:
> [ EXTERNAL EMAIL ]
> 
> On 05/05/2023 04:37, xianwei.zhao wrote:
>> Hi Krzysztof,
>>        Thank you for your reply.
>>
>> On 2023/5/1 17:58, Krzysztof Kozlowski wrote:
>>> [你通常不会收到来自 krzysztof.kozlowski@linaro.org 的电子邮件。请访问 https://aka.ms/LearnAboutSenderIdentification，以了解这一点为什么很重要]
>>>
>>> [ EXTERNAL EMAIL ]
>>>
>>> On 27/04/2023 10:58, Xianwei Zhao wrote:
>>>> Amlogic C3 is an advanced edge AI processor designed for smart IP camera
>>>> applications.
>>>>
>>>> Add basic support for the C3 based Amlogic AW409 board, which describes
>>>> the following components: CPU, GIC, IRQ, Timer, UART. It's capable of
>>>> booting up into the serial console.
>>>>
>>>> Signed-off-by: Xianwei Zhao <xianwei.zhao@amlogic.com>
>>>>
>>>> ---
>>>> V1 -> V2: Remove new arch, and use ARCH_MESON;
>>>>             Modify node name, and delete superfluous blank lines.
>>>> ---
>>>>    arch/arm64/boot/dts/amlogic/Makefile          |  1 +
>>>>    .../amlogic/amlogic-c3-c302x-aw409-256m.dts   | 29 +++++++
>>>>    arch/arm64/boot/dts/amlogic/amlogic-c3.dtsi   | 86 +++++++++++++++++++
>>>>    3 files changed, 116 insertions(+)
>>>>    create mode 100644 arch/arm64/boot/dts/amlogic/amlogic-c3-c302x-aw409-256m.dts
>>>>    create mode 100644 arch/arm64/boot/dts/amlogic/amlogic-c3.dtsi
>>>>
>>>> diff --git a/arch/arm64/boot/dts/amlogic/Makefile b/arch/arm64/boot/dts/amlogic/Makefile
>>>> index cd1c5b04890a..bcec872c2444 100644
>>>> --- a/arch/arm64/boot/dts/amlogic/Makefile
>>>> +++ b/arch/arm64/boot/dts/amlogic/Makefile
>>>> @@ -74,3 +74,4 @@ dtb-$(CONFIG_ARCH_MESON) += meson-sm1-odroid-hc4.dtb
>>>>    dtb-$(CONFIG_ARCH_MESON) += meson-sm1-sei610.dtb
>>>>    dtb-$(CONFIG_ARCH_MESON) += meson-sm1-x96-air-gbit.dtb
>>>>    dtb-$(CONFIG_ARCH_MESON) += meson-sm1-x96-air.dtb
>>>> +dtb-$(CONFIG_ARCH_MESON) += amlogic-c3-c302x-aw409-256m.dtb
>>>
>>> Looks wrongly ordered. 'a' is before 'm'.
>> Will do.
>>>
>>>> diff --git a/arch/arm64/boot/dts/amlogic/amlogic-c3-c302x-aw409-256m.dts b/arch/arm64/boot/dts/amlogic/amlogic-c3-c302x-aw409-256m.dts
>>>> new file mode 100644
>>>> index 000000000000..edce8850b338
>>>> --- /dev/null
>>>> +++ b/arch/arm64/boot/dts/amlogic/amlogic-c3-c302x-aw409-256m.dts
>>>> @@ -0,0 +1,29 @@
>>>> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
>>>> +/*
>>>> + * Copyright (c) 2021 Amlogic, Inc. All rights reserved.
>>>> + */
>>>> +
>>>> +/dts-v1/;
>>>> +
>>>> +#include "amlogic-c3.dtsi"
>>>> +
>>>> +/ {
>>>> +     model = "Amlogic C302 aw409 Development Board";
>>>> +     compatible = "amlogic,aw409", "amlogic,c3";
>>>
>>> Missing bindings.
>>>
>>> Please run scripts/checkpatch.pl and fix reported warnings.
>>>
>> The bindings committed by Neil, it is applied to
>> https://git.kernel.org/pub/scm/linux/kernel/git/amlogic/linux.git
>> (v6.5/arm64-dt),
>> bindings:
>> https://lore.kernel.org/all/20230407102704.1055152-1-kelvin.zhang@amlogic.com/
> 
> It's not in the next, so please always link them. We expect them always
> together, so if you decide to do otherwise, it's your job now to keep us
> informed. Otherwise how can we know that you sent bindings or you didn't?
> 
Will add link in V3,thanks.
> Best regards,
> Krzysztof
>