Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b9ceed26-bf64-6314-3ec5-562542b2b1c6@amd.com>
Date:   Fri, 5 May 2023 10:22:09 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [PATCH] dma-buf/sync_file: Use fdget()
Content-Language: en-US
To:     ye.xingchen@zte.com.cn, sumit.semwal@linaro.org
Cc:     gustavo@padovan.org, linux-media@vger.kernel.org,
        dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org,
        linux-kernel@vger.kernel.org
References: <202305051103396748797@zte.com.cn>
From:   =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
In-Reply-To: <202305051103396748797@zte.com.cn>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MGZVMkJmYlhIUXgya3NxN3UwN1NlRGhGNGtoYnRWSFNLRU9rUU95aVVzeEUw?=
 =?utf-8?B?VDFOZm9ERXhqT21jZ3YyV0pvaXk4T0NOMnY1RERiWGNtcWxjeG9xNVBMeW1j?=
 =?utf-8?B?cVRwdWxuSHpqT0M2cExQbTNKQTlpZXJPa0k1MEh2UTRXbVI5cFRWME50ZXVn?=
 =?utf-8?B?REZYZkNQOXp1aHZ4NFloRUt4Wmt5dDg2SmozREhOaGUvT0xYUzNvNWR5VTFG?=
 =?utf-8?B?NUM1QnJ2V0lqZk5BSzJPNmhuUmQ2cjVBWTZvOE1hbi8zTUViUGMxRENBSkMw?=
 =?utf-8?B?NDVFbnNOTFhBRWtDSzNjWkhLVDV6ZUx1eE1kV0E5VG81VDVRMHl6UnhmWTJX?=
 =?utf-8?B?em9LdVdOUjYzTnJDY3J2RE5lWkwrTUdCaXlQbnh5RVpOdzIvMFhFdzVyNy9G?=
 =?utf-8?B?Uml2VEIrMXowWDBDRHl3emtsQ2RVSHkrckhPWW9YQklqZFI1dXR4aVRpU1hW?=
 =?utf-8?B?L2FXandlc04xZDJJKzBiWE8yWkJVVlZIQ0d2eGZNWGc3K3U3V0FKWmNzWlJD?=
 =?utf-8?B?V0RTYk5mVjdOMHhoNjZndk53dDhmZmh0MDdxQXlTbmpxZjFjOGwvd0hsM1Rn?=
 =?utf-8?B?OW42QWpmS2JMeDNzc1ovbDlhd0hKd2tMQUc5ZElRM0dueEFaNzJFMklLRTZi?=
 =?utf-8?B?SHNCNmM0bStTaXNIRzNrNHNWZVRSV1JUUDJ1RlBZTVlkbUhkYzB6TGxWdzBD?=
 =?utf-8?B?VHBqNURldkJ5aUdjb3F5UWQ0SVRIbnY3QnRWQmZhMzZGVnhiNTdpUVZEYUVH?=
 =?utf-8?B?bDVoaTQySGdraGUwck9WM0tTTUFabVVWbkZHSm1FTUFwY2NOVE9xQ3pSYitI?=
 =?utf-8?B?aHFhQk0yMWhSV08xYk1jUTFKQUFSSUtxSGZnQzB4UEpZREU5SEQyVlR4bXU3?=
 =?utf-8?B?cVlaSVRBMUcwSWtGY3o5ZU9ZMjQwcGFzcEJscXgzOXZrU2tUOFB1MXlVVFRT?=
 =?utf-8?B?NlhFTU1rWVdQT1ZCYWZNWEoyQUJKY2ZvYitEM2NITEhURmxvSHA4MDJCUDRt?=
 =?utf-8?B?elNDZ2hsRVlIZjJCeVA5UHVFNFM4TXQxVWRLWWJLOWdRVVVmVmtOc1FDVTlM?=
 =?utf-8?B?SlVZZE9qTmszV3VEZkdOUVFGcFdhb1VVVVRyaGYvWHV5RFJjUHFIa3BycjEv?=
 =?utf-8?B?VlpuTHBqSHpSSUdzT3pJMUhocU9JT1NRcXhrWmpqTVVKOHRQRlNHMmc0ZVBX?=
 =?utf-8?B?cTNJOGZHWUZwbnFFOU5rQlluc292Um83K3dncTUrNWNETFNScktFenBLWXdk?=
 =?utf-8?B?V2piRDV2YVdkVFBsYWVySWhWVThRQkNvNG0vZEhMS0ZBengxLzk1bHZkMktP?=
 =?utf-8?B?RXBBcUQvZjVKVFJhR2ZhZlp1M1ZMRHVUdEgwSENqNXZWN3J1V3RPejRKUkhr?=
 =?utf-8?B?Y0FBcHc5U3BjRkNZQ2MydTIvaGxtemtGWHNBdDR3Mzk0ajRJZWhJNDB4ajRw?=
 =?utf-8?B?a01hUm1vbFRudWdNNjZ2cU1DTnh2anVlR01oSW12Y2tTU2hPM3ZnTGRVWkFS?=
 =?utf-8?B?aFcxNkkwZkJ5NTgwcmVTV0NVZTBOZjdYNkJMVE5mdERmV3R1OEsyMXg1SUY5?=
 =?utf-8?B?ei9MRzBlaTdxNzArcUwvMVY4a2tTUzJZSDhIc3FMYW5FQTVrM2NwVWhsV2pa?=
 =?utf-8?B?OE92c0FNVzViQWFrOGhKRkJ2RVl0MXNTQU5aREdlVktpcW5aL3RLOE9RTUtC?=
 =?utf-8?B?Z2VlUEVQbjVWTmh5OXZodWFpbGFHUHNKd0hwSVEvNnA1UW8xN1NFTGliVngv?=
 =?utf-8?B?T2NneTMyL2c3TXRDdkVEWG01Q1pNKzFmK3JLNVhsaFZVdmcrZWFhS204YXJC?=
 =?utf-8?B?NUd0QkRGWWxnOWZsMlFyT0FhRC8ySmcrdE4yYVJsdDFKNisrWHNxZjllTHVG?=
 =?utf-8?B?QTRhVno2RW40MCtmeURXMEM0eU50aGZ1R1pSdzRSUnZueWgreW1sVGxKNjk1?=
 =?utf-8?B?WnovSDFBQm5tUEd5T1FFbGxpUTdKaUYrekZsOTllWTlZZjN0MVFuMXlaOGZY?=
 =?utf-8?B?RGhFTnV4TURnU0ZGUFZVbDhqVlV4QmJ3UnMrWUt5QjN5ZE40T0l1M3pwRkdT?=
 =?utf-8?B?OFg5N04xUzZMTHlGbXF0TWdab0c4UWlNL0hqR3Z5citRVkVKbUJsbjFOVEEw?=
 =?utf-8?B?WHlNY1V6RzZ1QjNaYklmbDBHbVI3ZWhjWTlKYittdzdBZEtsN0Ftd1kvQ2Fu?=
 =?utf-8?Q?whLVLAvovFDMXawGaGBrQvhHGroyh1uuAlpzKmtAro/q?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 923dfff2-fdc9-46d4-015f-08db4d41d504
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3587.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2023 08:22:14.6999
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: vImxtc28Vz0Alcwdog5Pe6zz5xBXM8fvJLAesKSNI4sA9ueGv4+8co25bbTfvvNN
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR12MB5396
X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am 05.05.23 um 05:03 schrieb ye.xingchen@zte.com.cn:
> From: Ye Xingchen <ye.xingchen@zte.com.cn>
>
> convert the fget() use to fdget().

Well the rational is missing. Why should we do that?

Christian.

>
> Signed-off-by: Ye Xingchen <ye.xingchen@zte.com.cn>
> ---
>   drivers/dma-buf/sync_file.c | 10 +++++-----
>   1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/dma-buf/sync_file.c b/drivers/dma-buf/sync_file.c
> index af57799c86ce..222b13b1bdb8 100644
> --- a/drivers/dma-buf/sync_file.c
> +++ b/drivers/dma-buf/sync_file.c
> @@ -78,18 +78,18 @@ EXPORT_SYMBOL(sync_file_create);
>
>   static struct sync_file *sync_file_fdget(int fd)
>   {
> -	struct file *file = fget(fd);
> +	struct struct fd f = fdget(fd);
>
> -	if (!file)
> +	if (!f.file)
>   		return NULL;
>
> -	if (file->f_op != &sync_file_fops)
> +	if (f.file->f_op != &sync_file_fops)
>   		goto err;
>
> -	return file->private_data;
> +	return f.file->private_data;
>
>   err:
> -	fput(file);
> +	fdput(f);
>   	return NULL;
>   }
>