Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <41bb29b4-979b-3851-a7ea-5399f1edfe95@amlogic.com>
Date:   Fri, 5 May 2023 17:11:38 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [PATCH V3] arm64: dts: add support for C3 based Amlogic AW409
Content-Language: en-US
To:     neil.armstrong@linaro.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org,
        devicetree@vger.kernel.org
Cc:     Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will@kernel.org>,
        Kevin Hilman <khilman@baylibre.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
References: <20230505071254.2571429-1-xianwei.zhao@amlogic.com>
 <ca4c87f4-c496-7fa6-2945-45e4fd9c2020@linaro.org>
From:   "xianwei.zhao" <xianwei.zhao@amlogic.com>
In-Reply-To: <ca4c87f4-c496-7fa6-2945-45e4fd9c2020@linaro.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cVRIUFJTMUpxVk80UE82ZTdjc2Q3cHVXTnBlcGpEYnZtU1RGL3JSSmdHM21W?=
 =?utf-8?B?Z0ZBKzcxSExvZno3V1ROSjExZnlqa3B6Mkw2bHowOS8wb1VRbEREK2tqTXMx?=
 =?utf-8?B?bGd4Q2VVRGo4R2ltSW1zaVFNWTRscjVJUnhMWXh6bjFNTHBSL3BseStKSDdy?=
 =?utf-8?B?RmVZYkNVdEdLdW9zSld2UWlRRFZiWTJVQ0x3MFkrMXU2SVFYNVhPMDZNSjda?=
 =?utf-8?B?Qks1QnN0Z3Z4cENvU1ZmN1NpTC84c08rUWc3d0lvR1hXUitWcmY0Q2haU0Z2?=
 =?utf-8?B?S0tQZVFWZlM1S1JXemVTSFAwMFFqK2FJS05QT3lMRmFzR29Uc2JTRzNsUmxF?=
 =?utf-8?B?S2h4MTdGVm15NUFCUnk0cXNGTmxYcDVIQmJTSjZPRW1aeU5nSUpaMkQrT0Rj?=
 =?utf-8?B?MnkxVEhYRDB4aUlrUitPZ2J0TEpuMFlOUUk0MU00b2JSdzlrR2pNVjgxTXNP?=
 =?utf-8?B?NnFyRS8ycUdWN3BDeFNCdFBSMEFsL08zT3gyYjFmTlhTbXpaZ29CK0lqaFFT?=
 =?utf-8?B?d1ZHZlFDaHMvdmJXRzhrK0xyV3dnZEFaN1dzeTZUbFlrMHljcEtIeHRKTHJn?=
 =?utf-8?B?eDdsbzhMMDA2dHJ6RzJNSUNnTWpySDdJcWw3VHNLb21BNlpidTAxT21qUVRP?=
 =?utf-8?B?aTJ1ZzNRWGVwMHJpRUdsSFF3cldIUEZyRDB2a25ldVpZenlSQ3FrVldHZEda?=
 =?utf-8?B?TVVSRGE1WjdYbWx1SDdBZXFzNlVSakZReTF1cndocjdTUFFESnhPZy83NFFX?=
 =?utf-8?B?aUtrYmtvRVNsV054Wlg2UDdEcmpZdEZ5Rlgwb2diYmdWK3VPZW5zUk5tSnNn?=
 =?utf-8?B?Tmc1RWo3YnhVc2FiNjFaQ1FibmJNYmI1dndMc3VRbE50bDF5WERxWUdCRjhr?=
 =?utf-8?B?ak5hS2JoMGV3dmVjUnREZy9KLzlQblo4NUhnQW5RYU5yVjZEYytpb3NDY01Z?=
 =?utf-8?B?Y3BMTVdHalhsSGF3MXdIU1JPQk45Wnk5RWoycHRWYmVRRll2MkFQL3ZUeTZ6?=
 =?utf-8?B?S04xRGdOLzh3a2VjUEJzM1FLa1d6bUVnT1N0V0ppZGQrYzJrOVV1ZU5WcGR0?=
 =?utf-8?B?ZUlpZlBRMzdWNDRPd0c2TllKcXlmQVliTWVSZm53b0ZRU041UlNuNE1CaTZi?=
 =?utf-8?B?dzEwbGtkQkp3ckF0MVRlT0Y3Z2lNYjZtR1A1ckpCRFltNHVocWhSN0xiMjJ6?=
 =?utf-8?B?RWN1MWpjN0hFU1lkaml1Y05ZQTFVdXcyN1NSWjZuL1VLNTYrSmE0WnpGTWFh?=
 =?utf-8?B?Q1FxWERDVThtaXovOGFFc2NaaUZYcE1iajFuSFdnU1NpcmZ1MktGVTZ2QTVv?=
 =?utf-8?B?TE9FQkkrYmViQTZ6QlB4RERqZkM4SjhjSjJWWmF4M1luN0Nmc1A4UVNUVkJK?=
 =?utf-8?B?d3ZKYy92dlZ1dU4zbzA0elBMajdNZUR4R2xTaDlwdUl4dUg2YmlwSEZMbm5u?=
 =?utf-8?B?ai9zZVJEVWxrZTlLVVBZaUkyZnhEeEd5ZlU3UE5pcHZ6UzVQOWhwVkJOWjRp?=
 =?utf-8?B?VVVJUTlxQ0dnR2lPdk1ldFRvWDRXYkpIRWxDQk12bDBYNHYvUWJBWGovdXZF?=
 =?utf-8?B?OTBuTGxtSzJ6RjZMZGZ5YXVYTkJEc0Qyd1ZjUGVteklxU2l1dytZcG9OeGlm?=
 =?utf-8?B?WVdtbTZNeDRlNkNqOFgxdXdoM05FcFZRSzVUTmVXMkkwL05qMnBTSDJOTDNR?=
 =?utf-8?B?cjBGdnp5Y0tDb2NzN1NSUVY5aTRFQzhJaHZLV0w3Sk9IMThIeTUzb0hZdlFN?=
 =?utf-8?B?Z1d2RFNDS1dWdm5reGJnQk1zVWRMR0ZOdldaZWhZLyt4Z0RGb2YzaUVpWnlS?=
 =?utf-8?B?K2g3SWZGYllyaTZNM0I5OEF3aU1sMCs1UDZJR0s5bUJZd2VqOFllSDRVbTB6?=
 =?utf-8?B?UGgxbml1cGVqenJMek5xc1MrR3pRMkNkQmRPYkI2b1RhSklBbTg4d2t3b2Ns?=
 =?utf-8?B?b3NEYnE1YUt6Y2Nwb3ZuUUZ2QUxmN21Vb3JKaENWQ1hQSWVkWk94Um15QUls?=
 =?utf-8?B?N0g3MnZQKysvZW5XbnN3VFhUQUhWZnpFRUNBK2gxZ01GN1FTa2kyTytPMjhK?=
 =?utf-8?B?SVdPQllvU0ZySHBSK2FtQXdFWEZQSmZLaUk4RVU2QnJiKyt0T2RBYWhRSGJ4?=
 =?utf-8?B?TjBlUURzYTJDb1YwUDMvZHp5Q3hKSDJvai9Od00rbG1LOHI5YzJnN3VGOG9T?=
 =?utf-8?B?a1E9PQ==?=
X-OriginatorOrg: amlogic.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7126d30f-2c16-4f44-ec29-08db4d48bdf0
X-MS-Exchange-CrossTenant-AuthSource: SG2PR03MB2734.apcprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2023 09:11:42.6527
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 0df2add9-25ca-4b3a-acb4-c99ddf0b1114
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ergoPd0qpTyBImLK6hQiMrwcyrwukAfMsSU/B6kFjC2zju/jHHIkqKku7yeksnH2h2osiwtPfVC9F3EAgQ3OjAYqVr8PcWSd+INmN4RZv/0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYZPR03MB5200
X-Spam-Status: No, score=-6.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 2023/5/5 17:05, Neil Armstrong wrote:
> [ EXTERNAL EMAIL ]
> 
> On 05/05/2023 09:12, Xianwei Zhao wrote:
>> Amlogic C3 is an advanced edge AI processor designed for smart IP camera
>> applications.
>>
>> Add basic support for the C3 based Amlogic AW409 board, which describes
>> the following components: CPU, GIC, IRQ, Timer, UART. It's capable of
>> booting up into the serial console.
>>
>> Signed-off-by: Xianwei Zhao <xianwei.zhao@amlogic.com>
>> Link: 
>> https://lore.kernel.org/all/20230407102704.1055152-1-kelvin.zhang@amlogic.com
>> Link: 
>> https://lore.kernel.org/all/20230307222651.2106615-2-martin.blumenstingl@googlemail.com
> 
> What are those links ? If they are dependencies, please add them under 
> the --- before the changelog.
>
Will do, thanks.
> Thanks,
> Neil
> 
>> ---
>> v2 -> V3: Remove '256m' from filename;
>>            Keep alphabetical order of Makefile.
>> V1 -> V2: Remove new arch, and use ARCH_MESON;
>>            Modify node name, and delete superfluous blank line.
>> ---
>>   arch/arm64/boot/dts/amlogic/Makefile          |  1 +
>>   .../dts/amlogic/amlogic-c3-c302x-aw409.dts    | 29 +++++++
>>   arch/arm64/boot/dts/amlogic/amlogic-c3.dtsi   | 86 +++++++++++++++++++
>>   3 files changed, 116 insertions(+)
>>   create mode 100644 
>> arch/arm64/boot/dts/amlogic/amlogic-c3-c302x-aw409.dts
>>   create mode 100644 arch/arm64/boot/dts/amlogic/amlogic-c3.dtsi
>>
>> diff --git a/arch/arm64/boot/dts/amlogic/Makefile 
>> b/arch/arm64/boot/dts/amlogic/Makefile
>> index cd1c5b04890a..6f61798a109f 100644
>> --- a/arch/arm64/boot/dts/amlogic/Makefile
>> +++ b/arch/arm64/boot/dts/amlogic/Makefile
>> @@ -1,4 +1,5 @@
>>   # SPDX-License-Identifier: GPL-2.0
>> +dtb-$(CONFIG_ARCH_MESON) += amlogic-c3-c302x-aw409.dtb
>>   dtb-$(CONFIG_ARCH_MESON) += meson-a1-ad401.dtb
>>   dtb-$(CONFIG_ARCH_MESON) += meson-axg-jethome-jethub-j100.dtb
>>   dtb-$(CONFIG_ARCH_MESON) += meson-axg-jethome-jethub-j110-rev-2.dtb
>> diff --git a/arch/arm64/boot/dts/amlogic/amlogic-c3-c302x-aw409.dts 
>> b/arch/arm64/boot/dts/amlogic/amlogic-c3-c302x-aw409.dts
>> new file mode 100644
>> index 000000000000..edce8850b338
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/amlogic/amlogic-c3-c302x-aw409.dts
>> @@ -0,0 +1,29 @@
>> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
>> +/*
>> + * Copyright (c) 2021 Amlogic, Inc. All rights reserved.
>> + */
>> +
>> +/dts-v1/;
>> +
>> +#include "amlogic-c3.dtsi"
>> +
>> +/ {
>> +     model = "Amlogic C302 aw409 Development Board";
>> +     compatible = "amlogic,aw409", "amlogic,c3";
>> +     interrupt-parent = <&gic>;
>> +     #address-cells = <2>;
>> +     #size-cells = <2>;
>> +
>> +     aliases {
>> +             serial0 = &uart_b;
>> +     };
>> +
>> +     memory@0 {
>> +             device_type = "memory";
>> +             reg = <0x0 0x0 0x0 0x10000000>;
>> +     };
>> +};
>> +
>> +&uart_b {
>> +     status = "okay";
>> +};
>> diff --git a/arch/arm64/boot/dts/amlogic/amlogic-c3.dtsi 
>> b/arch/arm64/boot/dts/amlogic/amlogic-c3.dtsi
>> new file mode 100644
>> index 000000000000..93b335aef605
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/amlogic/amlogic-c3.dtsi
>> @@ -0,0 +1,86 @@
>> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
>> +/*
>> + * Copyright (c) 2021 Amlogic, Inc. All rights reserved.
>> + */
>> +
>> +#include <dt-bindings/interrupt-controller/irq.h>
>> +#include <dt-bindings/interrupt-controller/arm-gic.h>
>> +#include <dt-bindings/gpio/gpio.h>
>> +
>> +/ {
>> +     cpus {
>> +             #address-cells = <2>;
>> +             #size-cells = <0>;
>> +
>> +             cpu0: cpu@0 {
>> +                     device_type = "cpu";
>> +                     compatible = "arm,cortex-a35";
>> +                     reg = <0x0 0x0>;
>> +                     enable-method = "psci";
>> +             };
>> +
>> +             cpu1: cpu@1 {
>> +                     device_type = "cpu";
>> +                     compatible = "arm,cortex-a35";
>> +                     reg = <0x0 0x1>;
>> +                     enable-method = "psci";
>> +             };
>> +     };
>> +
>> +     timer {
>> +             compatible = "arm,armv8-timer";
>> +             interrupts = <GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(4) | 
>> IRQ_TYPE_LEVEL_LOW)>,
>> +                          <GIC_PPI 14 (GIC_CPU_MASK_SIMPLE(4) | 
>> IRQ_TYPE_LEVEL_LOW)>,
>> +                          <GIC_PPI 11 (GIC_CPU_MASK_SIMPLE(4) | 
>> IRQ_TYPE_LEVEL_LOW)>,
>> +                          <GIC_PPI 10 (GIC_CPU_MASK_SIMPLE(4) | 
>> IRQ_TYPE_LEVEL_LOW)>;
>> +     };
>> +
>> +     psci {
>> +             compatible = "arm,psci-1.0";
>> +             method = "smc";
>> +     };
>> +
>> +     xtal: xtal-clk {
>> +             compatible = "fixed-clock";
>> +             clock-frequency = <24000000>;
>> +             clock-output-names = "xtal";
>> +             #clock-cells = <0>;
>> +     };
>> +
>> +     soc {
>> +             compatible = "simple-bus";
>> +             #address-cells = <2>;
>> +             #size-cells = <2>;
>> +             ranges;
>> +
>> +             gic: interrupt-controller@fff01000 {
>> +                     compatible = "arm,gic-400";
>> +                     #interrupt-cells = <3>;
>> +                     #address-cells = <0>;
>> +                     interrupt-controller;
>> +                     reg = <0x0 0xfff01000 0 0x1000>,
>> +                           <0x0 0xfff02000 0 0x2000>,
>> +                           <0x0 0xfff04000 0 0x2000>,
>> +                           <0x0 0xfff06000 0 0x2000>;
>> +                     interrupts = <GIC_PPI 9 (GIC_CPU_MASK_SIMPLE(4) 
>> | IRQ_TYPE_LEVEL_HIGH)>;
>> +             };
>> +
>> +             apb4: bus@fe000000 {
>> +                     compatible = "simple-bus";
>> +                     reg = <0x0 0xfe000000 0x0 0x480000>;
>> +                     #address-cells = <2>;
>> +                     #size-cells = <2>;
>> +                     ranges = <0x0 0x0 0x0 0xfe000000 0x0 0x480000>;
>> +
>> +                     uart_b: serial@7a000 {
>> +                             compatible = "amlogic,meson-g12a-uart";
>> +                             reg = <0x0 0x7a000 0x0 0x18>;
>> +                             interrupts = <GIC_SPI 169 
>> IRQ_TYPE_EDGE_RISING>;
>> +                             status = "disabled";
>> +                             clocks = <&xtal>, <&xtal>, <&xtal>;
>> +                             clock-names = "xtal", "pclk", "baud";
>> +                     };
>> +
>> +             };
>> +     };
>> +};
>>
>> base-commit: ae68fb187b59bc8645974320808ab2d7c41b1833
>