Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 5 May 2023 12:27:47 +0300
From:   Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To:     Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc:     mchehab@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de,
        kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com,
        linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org, Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH] media: nxp: remove unneeded semicolon
Message-ID: <20230505092747.GU4551@pendragon.ideasonboard.com>
References: <20230505060617.5327-1-jiapeng.chong@linux.alibaba.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20230505060617.5327-1-jiapeng.chong@linux.alibaba.com>
Precedence: bulk

Hi Jiapeng,

Thank you for the patch.

On Fri, May 05, 2023 at 02:06:17PM +0800, Jiapeng Chong wrote:
> No functional modification involved.
> 
> ./drivers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c:226:2-3: Unneeded semicolon.
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4868
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>

I'll update the subject line to

media: nxp: imx8-isi: Remove unneeded semicolon

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  drivers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c b/drivers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c
> index b5ffde46f31b..f7447b2f4d77 100644
> --- a/drivers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c
> +++ b/drivers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c
> @@ -223,7 +223,7 @@ static int mxc_isi_crossbar_init_cfg(struct v4l2_subdev *sd,
>  		route->sink_pad = i;
>  		route->source_pad = i + xbar->num_sinks;
>  		route->flags = V4L2_SUBDEV_ROUTE_FL_ACTIVE;
> -	};
> +	}
>  
>  	routing.num_routes = xbar->num_sources;
>  	routing.routes = routes;

-- 
Regards,

Laurent Pinchart