Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Oleksandr Natalenko <oleksandr@natalenko.name>
To:     Alex Williamson <alex.williamson@redhat.com>
Cc:     linux-kernel@vger.kernel.org, Eric Auger <eric.auger@redhat.com>,
        =?ISO-8859-1?Q?C=E9dric?= Le Goater <clg@redhat.com>,
        Jason Gunthorpe <jgg@ziepe.ca>,
        Abhishek Sahu <abhsahu@nvidia.com>,
        Kevin Tian <kevin.tian@intel.com>,
        Cornelia Huck <cohuck@redhat.com>, Bo Liu <liubo03@inspur.com>,
        "K V P, Satyanarayana" <satyanarayana.k.v.p@intel.com>,
        kvm@vger.kernel.org
Subject: Re: [PATCH] vfio/pci: demote hiding ecap messages to debug level
Date:   Fri, 05 May 2023 12:01:51 +0200
Message-ID: <2680715.mvXUDI8C0e@natalenko.name>
In-Reply-To: <20230504170111.70a7f639.alex.williamson@redhat.com>
References: <20230504131654.24922-1-oleksandr@natalenko.name>
 <20230504170111.70a7f639.alex.williamson@redhat.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hello.

On p=C3=A1tek 5. kv=C4=9Btna 2023 1:01:11 CEST Alex Williamson wrote:
> On Thu,  4 May 2023 15:16:54 +0200
> Oleksandr Natalenko <oleksandr@natalenko.name> wrote:
>=20
> > Seeing a burst of messages like this:
> >=20
> >     vfio-pci 0000:98:00.0: vfio_ecap_init: hiding ecap 0x19@0x1d0
> >     vfio-pci 0000:98:00.0: vfio_ecap_init: hiding ecap 0x25@0x200
> >     vfio-pci 0000:98:00.0: vfio_ecap_init: hiding ecap 0x26@0x210
> >     vfio-pci 0000:98:00.0: vfio_ecap_init: hiding ecap 0x27@0x250
> >     vfio-pci 0000:98:00.1: vfio_ecap_init: hiding ecap 0x25@0x200
> >     vfio-pci 0000:b1:00.0: vfio_ecap_init: hiding ecap 0x19@0x1d0
> >     vfio-pci 0000:b1:00.0: vfio_ecap_init: hiding ecap 0x25@0x200
> >     vfio-pci 0000:b1:00.0: vfio_ecap_init: hiding ecap 0x26@0x210
> >     vfio-pci 0000:b1:00.0: vfio_ecap_init: hiding ecap 0x27@0x250
> >     vfio-pci 0000:b1:00.1: vfio_ecap_init: hiding ecap 0x25@0x200
> >=20
> > is of little to no value for an ordinary user.
> >=20
> > Hence, use pci_dbg() instead of pci_info().
> >=20
> > Signed-off-by: Oleksandr Natalenko <oleksandr@natalenko.name>
> > ---
> >  drivers/vfio/pci/vfio_pci_config.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >=20
> > diff --git a/drivers/vfio/pci/vfio_pci_config.c b/drivers/vfio/pci/vfio=
_pci_config.c
> > index 948cdd464f4e..dd8dda14e701 100644
> > --- a/drivers/vfio/pci/vfio_pci_config.c
> > +++ b/drivers/vfio/pci/vfio_pci_config.c
> > @@ -1643,7 +1643,7 @@ static int vfio_ecap_init(struct vfio_pci_core_de=
vice *vdev)
> >  		}
> > =20
> >  		if (!len) {
> > -			pci_info(pdev, "%s: hiding ecap %#x@%#x\n",
> > +			pci_dbg(pdev, "%s: hiding ecap %#x@%#x\n",
> >  				 __func__, ecap, epos);
> > =20
> >  			/* If not the first in the chain, we can skip over it */
>=20
> Looks fine to me, though I might adjust that next line to keep the
> previous alignment.

Sure, but if you want me to send v2 with this, please let me know.

Thanks.

> In general this has certainly caused more
> confusion than insightful information, so demoting it to debug is a
> good idea.  Thanks,
>=20
> Alex
>=20
>=20


=2D-=20
Oleksandr Natalenko (post-factum)