Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <202305051706416319733@zte.com.cn>
In-Reply-To: <202305051706416319733@zte.com.cn>
From:   Eric Dumazet <edumazet@google.com>
Date:   Fri, 5 May 2023 12:37:25 +0200
Message-ID: <CANn89iK8c5S3P8s9mfoaa9J=Pt1zXyjdRPPMp8nFV1eqYZovDQ@mail.gmail.com>
Subject: Re: [PATCH] net: socket: Use fdget() and fdput()
To:     ye.xingchen@zte.com.cn
Cc:     davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, May 5, 2023 at 11:06=E2=80=AFAM <ye.xingchen@zte.com.cn> wrote:
>
> From: Ye Xingchen <ye.xingchen@zte.com.cn>
>
> By using the fdget function, the socket object, can be quickly obtained
> from the process's file descriptor table without the need to obtain the
> file descriptor first before passing it as a parameter to the fget
> function.
>

net-next is currently closed.

There are good reasons we have sockfd_lookup() and sockfd_lookup_light(),
you probably should take a deeper look at the difference between them.


> Signed-off-by: Ye Xingchen <ye.xingchen@zte.com.cn>
> ---
>  net/socket.c | 9 ++++-----
>  1 file changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/net/socket.c b/net/socket.c
> index a7b4b37d86df..84daba774432 100644
> --- a/net/socket.c
> +++ b/net/socket.c
> @@ -528,19 +528,18 @@ EXPORT_SYMBOL(sock_from_file);
>
>  struct socket *sockfd_lookup(int fd, int *err)
>  {
> -       struct file *file;
> +       struct fd f =3D fdget(fd);
>         struct socket *sock;
>
> -       file =3D fget(fd);
> -       if (!file) {
> +       if (!f.file) {
>                 *err =3D -EBADF;
>                 return NULL;
>         }
>
> -       sock =3D sock_from_file(file);
> +       sock =3D sock_from_file(f.file);
>         if (!sock) {
>                 *err =3D -ENOTSOCK;
> -               fput(file);
> +               fdput(f);
>         }
>         return sock;
>  }
> --
> 2.25.1