Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <56979ac8-f27a-801a-dca3-3e1ff63bb005@axis.com>
Date:   Fri, 5 May 2023 13:03:30 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.0
Subject: Re: [PATCH v2 1/2] regulator: Add bindings for TPS6287x
Content-Language: en-US
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Mark Brown <broonie@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
CC:     <linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <kernel@axis.com>
References: <20230502-tps6287x-driver-v2-0-fb5419d46c49@axis.com>
 <20230502-tps6287x-driver-v2-1-fb5419d46c49@axis.com>
 <dfd3498c-62ab-92d3-22d6-21729dc619fa@linaro.org>
 <c42a721c-13a4-16a1-efe6-002c76f5c69b@axis.com>
 <1f62d6dd-1ab8-a8e8-c881-da03ad9bfbd9@linaro.org>
From:   =?UTF-8?Q?M=c3=a5rten_Lindahl?= <martenli@axis.com>
In-Reply-To: <1f62d6dd-1ab8-a8e8-c881-da03ad9bfbd9@linaro.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OWZrZC9EMHdQMzd1N2FuSFNJSmc4SEFZSW54cFRjOGFNd3RTK1hhSWlObVBG?=
 =?utf-8?B?SndOamJiTXBKa0krTVVWS2JmeHROYmRGenpHSnZNbkZDeUxKVU1XOEZZMlBt?=
 =?utf-8?B?OGRJeUN5c294bVQ5eGExZm5tMTM3QWhUUFIvQ0VVODNBUGQ0QTBqWGwrWWE4?=
 =?utf-8?B?M294bGY2MExWb1dyZmhuOGF2Y1dTN09DZ0hCWGZrTktZV1p2K2VGNE92RzlZ?=
 =?utf-8?B?WTVEY0RoQk9SYkYza2VseStzWnBBbEx6TDRWV2tHTHMwWWFEWndhNHNvTHdR?=
 =?utf-8?B?azI3V0lKZElDVURtekcvT1VXVCt2SHRsRlU0ZGJUM1JuS1RCNjIwdUZBM0RC?=
 =?utf-8?B?S2xNWGRKWlhLZVZrcnZTMStNbDc4bXcwK1E2OVRiU2NyTnZnRjR2WHM3d0I4?=
 =?utf-8?B?cGNuSS94aFI2VWQvTFkvM0d3TmVCcndnczlubDNKZGxWREZOZXdLc1lodUdV?=
 =?utf-8?B?R29LN0FRNXRmRlRKSFUxb1VRRWIvT0ROK2VON014c2RBcTN5S21uOHZES3Fi?=
 =?utf-8?B?U252aURNUW1sNzVEbGlvRnlqSVRFWVF6M1ZyOGRZL21DOEhhUlk2dUJmZXl0?=
 =?utf-8?B?c0h1bUNwWmpRaVhDZEk1aXRUL015ZHpqMzZKMTRnTGtQZis2Y0tMcHJmdFc3?=
 =?utf-8?B?V0dMcWl3SWNveHNqZ1FDWExFVjN4S2JOdkxheEZocTFWQmx6eVlCcjVIQ2tv?=
 =?utf-8?B?RFJyRkFIN09LL01ZWXBVQkdIT0Q4RFdvZXFGaHJ0MVJTUkxJaXRIOHd6ZGMy?=
 =?utf-8?B?eTFaTGJ5dmliU0VMTWZGN1hhZElJV3ZXR2I0c3grMFNFbG03bHo5SmRxSzNG?=
 =?utf-8?B?RWZ4blZwUEVXTDhtM1RmZ3hoc21YZmJOSDF0VkZsVXkxQzluK045NUhpQlMx?=
 =?utf-8?B?VEtMQm9LY1JZN2pHK2x0RUZOdVp2Sy9sQXNUMEhLcWF5MGZzeW9MQlRrY1JM?=
 =?utf-8?B?YnFYVW9RZ2xpK21DaldrWndoUnAxalZlK3dxWjdMeENualNPdi9Sb25nQUV6?=
 =?utf-8?B?NUVoYTBFQlFpSEZCOHZOY1VNMXVuY2hNYkJOWTFCMjRDeFArMFJZOEpyOVkv?=
 =?utf-8?B?NUdtTnhtSzRGQXpYLzZrTkhXRm5IdTNLOEYzMVpUdGdEUHROcm5kbE9PMUZQ?=
 =?utf-8?B?L3VUWkRmbFNOQnc2MzhwMFc4QlZiTDlxWFZLOUduYWMxemp5dWoxaXF3aGow?=
 =?utf-8?B?QXVTTURSZDlaa2VnVFhsbkJXTGtSMnZZOTJ6bXJBTW03aytIa0Mvb0czRWFz?=
 =?utf-8?B?VENEdE9TS0Z2alllY1NaZUlXSTNiMFU2aVZnWS9hMjdZNEVFYXcrVjh3RUx5?=
 =?utf-8?B?N3E0dWJ0T3hGTldwck5pVnNtS3c3Q2p0ZTVDa2Q0VVpXK3Z4ZUQrT2VOMTkw?=
 =?utf-8?B?bm1LTWtsR0llVk1FWU1vVC90bXcyMkJPeVZjZ25KS3VydlBEcXFFRFA2UDlu?=
 =?utf-8?B?czdGL0R3Y05icXpVcU5JNHhQNVp0ZGJxV2p4dEhDUnlxOUdIQVNjSTh2SlRm?=
 =?utf-8?B?QTFwZDEvQzc3RUpYM0dmS0tGV25BWHdHem4veTdFWHVDT0R1MFhVNlJTR0R1?=
 =?utf-8?B?azZpT3dJSjVUekFhbEFHQ1RFSUJobzhITmtqckI0SGFJMjBBdER2b2IxSGpN?=
 =?utf-8?B?dm0vOE9DUXlsZEVvRzJodFBlZWNFQVBYZGkxMkFxRWtZN1B6S1NveTZldEgx?=
 =?utf-8?B?S0lRRjk2Z01aSDBBd1k1VklJQzZickp0U2FWSzR6QTVnUXpyWHRLRTI4OXBj?=
 =?utf-8?B?VThRYjhaK2hpUmVhZkdlbUF0WUZtRHhITlRva2ZET09wSUtkdFFuZmZoYnFu?=
 =?utf-8?B?T21Tc0xmZ1diOHFzM2lYRHowZ3BMbWppOGV4NnFET0JvajdtVW95QVczbTcy?=
 =?utf-8?B?U01zZDNpVGg1am1vNGVXcW02VzVoZnJCemRLSjF0dHQwUThEN3ZML3c0ekMx?=
 =?utf-8?B?WkxUSjB2ZnNlSjd4ckV2YmdBU1ZsRElaME1wbTdkbzU1NUhUYXZNYm5zWkY0?=
 =?utf-8?B?SW9BaStTOExoL0Q3MGo1MVpWMWdUSWltUWI4b2RXa2xZY3BUSXJlaFhYSzB3?=
 =?utf-8?B?NkRoVDFoN1NkeXA0TlFxc1FVN1AySENETERHcFY0Uk1ld1BTVmN0MDlzcThK?=
 =?utf-8?Q?5AXwbyS7kEGsSCqjpnE2PAgps?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 681d86e7-0ed8-4e35-bf0e-08db4d585d41
X-MS-Exchange-CrossTenant-AuthSource: AS8PR02MB9529.eurprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2023 11:03:32.1253
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 78703d3c-b907-432f-b066-88f7af9ca3af
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Xmb8nkrV+dceVL6fBStSuNNdPkQhJg5pX6dxrn8ZygpppedL17/JSDjC3iRiM2ev9CCAu8eSefWDbS1BIutp0Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR02MB6909
X-Spam-Status: No, score=-8.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_MED,
        SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 5/4/23 17:11, Krzysztof Kozlowski wrote:
> On 04/05/2023 17:08, Mårten Lindahl wrote:
>> Hi Krzysztof!
>>
>> On 5/4/23 11:34, Krzysztof Kozlowski wrote:
>>> On 04/05/2023 10:30, Mårten Lindahl wrote:
>>>> Add bindings for the TPS62870/TPS62871/TPS62872/TPS62873 voltage
>>>> regulators.
>>>>
>>> Use subject prefixes matching the subsystem (which you can get for
>>> example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
>>> your patch is touching).
>>>
>>> Just a hint - I in general ignore all the emails without dt-bindings prefix.
>> Ok, I'll prefix it "dt-bindings: regulator:"
> You got command to run, so run it.  This semi-automated response is made
> longer for the purpose to help you, not to be quickly scrolled and
> ignored. When you run it you will see the order is opposite, regulator
> followed by dt-bindings.
>
> You can apply such habit for other subsystems where maintainers also
> expect certain prefixes.

Hi! Sorry, I did run the command and followed the latest commit I could 
see (1ba7dfb905b3) as the result is mixed with prefixes.

But I will of course do as you request: "regulator: dt-bindings: ".

>
>
>>>> Signed-off-by: Mårten Lindahl <marten.lindahl@axis.com>
>>>> ---
>>>>    .../devicetree/bindings/regulator/ti,tps62870.yaml | 62 ++++++++++++++++++++++
>>>>    1 file changed, 62 insertions(+)
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/regulator/ti,tps62870.yaml b/Documentation/devicetree/bindings/regulator/ti,tps62870.yaml
>>>> new file mode 100644
>>>> index 000000000000..32f259f16314
>>>> --- /dev/null
>>>> +++ b/Documentation/devicetree/bindings/regulator/ti,tps62870.yaml
>>>> @@ -0,0 +1,62 @@
>>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>>>> +%YAML 1.2
>>>> +---
>>>> +$id: http://devicetree.org/schemas/regulator/ti,tps62870.yaml#
>>>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>>>> +
>>>> +title: TI TPS62870/TPS62871/TPS62872/TPS62873 voltage regulator
>>>> +
>>>> +maintainers:
>>>> +  - Mårten Lindahl <marten.lindahl@axis.com>
>>>> +
>>>> +properties:
>>>> +  compatible:
>>>> +    enum:
>>>> +      - ti,tps62870
>>>> +      - ti,tps62871
>>>> +      - ti,tps62872
>>>> +      - ti,tps62873
>>>> +
>>>> +  reg:
>>>> +    maxItems: 1
>>>> +
>>>> +  regulators:
>>>> +    type: object
>>>> +
>>>> +    properties:
>>>> +      "vout":
>>> Drop quotes.
>>>
>>> Why do you need entire "regulators" node for one regulator? Why do you
>>> need child at first place. Drop it entirely.
>> I will remove the regulators node. I think the vout node is needed to
>> get the of_get_regulator_init_data.
> Hmmm, how other simple regulators deal with it? Like all the fixed ones
> and few other one-regulator-devices?

Ok, I added of_get_regulator_init_data to the driver probe and then it 
works fine. I'll drop the child node.

Thanks!

Kind regards

Mårten

>
>
> Best regards,
> Krzysztof
>