Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <1681311127-6891-1-git-send-email-manikanta.guntupalli@amd.com>
In-Reply-To: <1681311127-6891-1-git-send-email-manikanta.guntupalli@amd.com>
From:   Linus Walleij <linus.walleij@linaro.org>
Date:   Fri, 5 May 2023 13:56:42 +0200
Message-ID: <CACRpkdYb9iy8Fs2w9p7-64h6bMx3W9=JFHT08yYPaeggenDmcw@mail.gmail.com>
Subject: Re: [PATCH] gpio: zynq: fix zynqmp_gpio not an immutable chip warning
To:     Manikanta Guntupalli <manikanta.guntupalli@amd.com>
Cc:     michal.simek@xilinx.com, michal.simek@amd.com, git@amd.com,
        shubhrajyoti.datta@xilinx.com, srinivas.neeli@xilinx.com,
        brgl@bgdev.pl, linux-gpio@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        srinivas.goud@amd.com, manion05gk@gmail.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Manikanta,

thanks for your patch!

On Wed, Apr 12, 2023 at 4:52=E2=80=AFPM Manikanta Guntupalli
<manikanta.guntupalli@amd.com> wrote:

> Make the struct irq_chip const and flag it as IRQCHIP_IMMUTABLE to fix
> "gpio gpiochip1: (zynqmp_gpio): not an immutable chip" warning.
>
> Signed-off-by: Manikanta Guntupalli <manikanta.guntupalli@amd.com>

Don't you need to also add
gpiochip_disable_irq() in the .irq_mask() callback and
gpiochip_enable_irq() in the .irq_unmask() callback as we
do in most other conversions?

Example:
https://lore.kernel.org/linux-gpio/20230414-immutable-irqchips-2-v1-3-6b59a=
5186b00@linaro.org/

Yours,
Linus Walleij