Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <4950083e-0469-4110-0a2c-17b806a35493@amd.com>
Date:   Fri, 5 May 2023 07:14:58 -0500
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.1
Subject: Re: [PATCH 0/4] pinctrl: amd: Adjust handling for firmware
 misconfigurations
To:     Linus Walleij <linus.walleij@linaro.org>,
        Mario Limonciello <mario.limonciello@amd.com>
Cc:     linux-gpio@vger.kernel.org, nakato@nakato.io, korneld@chromium.org,
        richard.gong@amd.com, Shyam-sundar.S-k@amd.com,
        Basavaraj.Natikar@amd.com, linux-kernel@vger.kernel.org
References: <20230421120625.3366-1-mario.limonciello@amd.com>
 <CACRpkda6zyvQ6a4ycEyyi=k5dTZo2Ecm6t6w_9e8hf3gih3qGA@mail.gmail.com>
Content-Language: en-US
From:   "Limonciello, Mario" <mlimonci@amd.com>
In-Reply-To: <CACRpkda6zyvQ6a4ycEyyi=k5dTZo2Ecm6t6w_9e8hf3gih3qGA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YkhmUkt2NERuNjQ3Vk51bW1wVWdsQUpoYWtHMTNERjRzZFZ6L3hOTEZ6ZzBi?=
 =?utf-8?B?WGIzaStYMzI0UjBqL05LeTR3cnZ0RW5iUmFhc1NpenhkUjZIWEtUTXQ5Tkx0?=
 =?utf-8?B?NzhYWFJFcjRyeDVxT2FGQTVid0plR1ZMempuaVRGOXpCRnJEMDR4R2ZFelVM?=
 =?utf-8?B?aXBQbXJHY1FLbCtROG53TitnVld0TjV2ekNjL2Y0K0MzYTFQUWgxNllwNzc3?=
 =?utf-8?B?ZHozdFptUUNTRnVzQnN4REd0SHZNcUJPOEpjZktkd2NSeU4vK2dTbDBoWDBh?=
 =?utf-8?B?Z1BRRDlpRUVUNmhkMHk2djBlMjZKaXhXZVppci8zY0lkSzkrRTl3ZVBFNnNX?=
 =?utf-8?B?NWVjRVpTUzIzaTZHRk1hRG1FNkZFV1NVbHVWZXVXY0QzZFVlcml1YkQydy9C?=
 =?utf-8?B?UXpreXFhNWgvS2FBZkEvdW5vREZOUGlEclU1M0krY0RYalB2WDQvVTl6eER1?=
 =?utf-8?B?MEIyOGI3Q3NqL1lyM0x0ZGlFbEdiY004WFdmYzlCUERTY3I5Tld4WCtQQ2FY?=
 =?utf-8?B?OHJBMndxN28xczRkYUJKaVZuTXpGYitVeFo5Y1lDOHpBV2JJOEJ3R1AzS2R0?=
 =?utf-8?B?UktFNzdCU1FJUEhWZDJTSU5OKzVKdGRGbmVqd1dyLzN4c1BsWTUxVTVsTVZ3?=
 =?utf-8?B?NDdTWkJHaHo2TFVsK3lmUlJpTmZtaWlsUjM4clc5YXZPdWx3RnVDTlFZQjVs?=
 =?utf-8?B?UFhBZHo1WVlKSWtYY1QwV0pvclRjT2o0V0ZoRkhrVHV2SGtJSEFnT0I0Smty?=
 =?utf-8?B?SVMzakE5aVVCQkpTRWJ3NFY1d294WU8zUm54Wkhtd3VpK0hiV3VZL1pLeVBX?=
 =?utf-8?B?ZE5OS01ySUVVdVFQOU5KWkd2UExxdEoxYktvM29IZVEyM2tvcGlWalhhSmJy?=
 =?utf-8?B?V1lZQlVQQzF1YjB2SmRNZ1Vpd0ZRUkFCVGpSTDNmejhvVHVwMnZ6MExqWEF2?=
 =?utf-8?B?TTI5WjB6bko3VzZESHhJRDFUVDhIdXlxTkdoZ0M3d3paNWYzSncvbUo3elBR?=
 =?utf-8?B?TjVOQTRoV2owT0w1M0NrVTZaUUYvZGg5cHk0Yldjb2ttai9oY2JvditsRFdH?=
 =?utf-8?B?OTU3ZzRMd0hqZ1Z0QlJVcU03dEhZdkZEemtwTVNnSUt1SDNGYk1Sc2hleEgv?=
 =?utf-8?B?VDVzdy9zQ0YwZndUMmVQRDJ3VXdnM0haOXQ2ZkxIblJVNzFhTHJueGpyVEpi?=
 =?utf-8?B?cWxXbEt5dUJMS0l2d3RLc0FrYlBXRjkvZk9uaHIrajdlYi96WDNuVnZWUWtH?=
 =?utf-8?B?d3pRVkdBdzhDc1JmaUZjc0cvM0FBOFZWbW9ZRDlIbk1ybVkwNVViTXIzZmhG?=
 =?utf-8?B?RFMyQWUrRkl6MExzWVo4Zk41RWltVUE5Y0Q3M2NQbjZHcnNzVG8rMzczL2JW?=
 =?utf-8?B?T3MrMUEvaytHbzhMZjBzOWhJOGNvYVhvRy8vQXRRcmNYaXhCZ3lYZzdoN0wy?=
 =?utf-8?B?MVVpZlVrdlRtbjMvd3RqVkhpNkcrZmp5QTNRanpna3habnhXQzdlb0lCK0Fr?=
 =?utf-8?B?dWVvSXo4cFIrcWl4SldZZ2U5Tk0yNU8wWFlKRldlNXA2S3JxSlhkR1oxTCt0?=
 =?utf-8?B?VWxDdGl2TlZWVUMxWVpQTExDTElIUHNrd2FxK3FNTVEwaS9Wb3BaV000Wm53?=
 =?utf-8?B?ZFJveko2UXM1bU05VDFkaUw5TWMyTkRuekJ6aTlneHc5eXplWUN3dVkzb0pB?=
 =?utf-8?B?Z1VJbkVVbmRJNjhIYkRJc1lEbG94c0ZNVW9JQjQ4SnFWWFR0bFVMMnhCYWcw?=
 =?utf-8?B?UHYwMGFRUWlIU0FVeFRxWTZqTTE0dVVIb3JrcEd5KzcrTXUvek4raXhqQXkz?=
 =?utf-8?B?NDQzazJBc3RoWHlNYTJPNFJ1ZmNXa2ZVUUwweFE4M2RLL3EyazZtWWljakxQ?=
 =?utf-8?B?S1Y5eUNodkx5TFh2QkVhTGV4S1BHM3E0eTdzNU9TR0VoM0dVYXdsaVJ4SzBN?=
 =?utf-8?B?NGZQR1BjUmNVdjZ3bUV6ejVPZ3d6VExkamJLQU1SOW9Nc0MxZStRZW9Wd2hm?=
 =?utf-8?B?OWhqMkJsYmp0YkY0SUplekk0WjJ1SkVhcWJ3SlhLN0ROVjV2eTlUUzZ3UHlv?=
 =?utf-8?B?SlJXaWFEWUFSL0ZEazhnVG0yTVg2ak5QOHhsVVUzcEIybDF0K0FUUkpuM1VC?=
 =?utf-8?Q?1mf1wy4fFr3jKU/7BeWNAowtj?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2d6487a6-fcf9-46bf-1247-08db4d625998
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2023 12:15:01.0646
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: EwcoGaKoa4rkHLyjTaNXCGcEpgBXPX4liiPuyFfdKsJ549RaZVbZuBKsHwyHQPZb7Up8XPzNQjWoqTadKaJb9Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB7375
X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 5/5/2023 6:43 AM, Linus Walleij wrote:
> On Fri, Apr 21, 2023 at 2:06 PM Mario Limonciello
> <mario.limonciello@amd.com> wrote:
>
>> commit 4e5a04be88fe ("pinctrl: amd: disable and mask interrupts on probe")
>> had intended to work around firmware problems on a Microsoft Surface
>> device but actually masked other real bugs in firmware and the driver.
>>
>> Before this commit, "wake on lid" doesn't work properly on a number of
>> systems, but this is because debounce handling was improperly configured
>> in the driver and due to a bug in this commit it gets configured a
>> different way.
>>
>> commit b26cd9325be4 ("pinctrl: amd: Disable and mask interrupts on
>> resume") attempted to build on top of this to mask issues on resume, but
>> it happened to "fix" the bug in commit 4e5a04be88fe ("pinctrl: amd:
>> disable and mask interrupts on probe") which "broke" wake on lid since
>> the debounce handling was programmed differently.
>>
>> This was reverted in commit 534e465845eb ("Revert "pinctrl: amd: Disable
>> and mask interrupts on resume"") which fixed the wake on lid.
>>
>> To fix this series of unfortunate events and prevent them in the future
>> this series corrects the GPIO0 debounce handling and reverts commit
>> 4e5a04be88fe ("pinctrl: amd: disable and mask interrupts on probe"). A new
>> patch that is safer is included that will fix spurious interrupt handling
>> and is expected to fix the issues that both
>> commit 4e5a04be88fe ("pinctrl: amd: disable and mask interrupts on probe")
>> and
>> commit b26cd9325be4 ("pinctrl: amd: Disable and mask interrupts on
>> resume") attempted to fix in a more scalable way.
> I applied the series for the next kernel cycle (becoming v6.5).
>
> If it gets urgent to get this in we can move it into the fixes (for v6.4 and
> stable) but at least this way we get some rotation in linux-next and wide
> testing of the patches.
>
> I will push it once v6.4-rc1 is out.
>
> Yours,
> Linus Walleij

Thanks!  Especially given the regression we were dealing with before I 
think this is the right
approach.