Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Jonathan Corbet <corbet@lwn.net>
To:     Hongyan Xia <hongyan.xia2@arm.com>
Cc:     Hongyan Xia <hongyan.xia2@arm.com>,
        Qais Yousef <qyousef@layalina.io>,
        Vincent Guittot <vincent.guittot@linaro.org>,
        linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sched/documentation: elaborate on uclamp limitations
In-Reply-To: <20230505152440.142265-1-hongyan.xia2@arm.com>
References: <20230505152440.142265-1-hongyan.xia2@arm.com>
Date:   Fri, 05 May 2023 09:30:52 -0600
Message-ID: <878re2n6c3.fsf@meer.lwn.net>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

Hongyan Xia <hongyan.xia2@arm.com> writes:

> The story in 5.2 about util_avg abruptly jumping from 300 when
> Fmax/Fmin == 3 to 1024 when Fmax/Fmin == 4 hides some details about how
> clock_pelt works behind the scenes. Explicitly mention it to make it
> easier for readers to follow.

So this is a nit, but...

> +Although running at Fmin reduces the rate of rq_clock_pelt() to 1/3 thus
> +accumulates util_sum at 1/3 of the rate at Fmax, the clock period
> +(rq_clock_pelt() now minus previous rq_clock_pelt()) in:
> +
> +::
> +
> +        util_sum / clock period = util_avg

This can be written as:

  ...previous rq_clock_pelt()) in::

       util_sum / clock period = util_avg

reducing the markup clutter and making the document a little more
readable.

Thanks,

jon