Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp1075109rwr; Fri, 5 May 2023 08:48:28 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4TNjAgzqtIgS5boolU2nmU+zChoSISSU2VVTX7li0BT/QefhocjJtDEtt6VC+kbXQMcfNV X-Received: by 2002:a05:6a20:2584:b0:f6:9492:93b2 with SMTP id k4-20020a056a20258400b000f6949293b2mr2584609pzd.23.1683301708155; Fri, 05 May 2023 08:48:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683301708; cv=none; d=google.com; s=arc-20160816; b=SL8L/rSlLeJfg11tgBGBZLvJJiu9uY39lOXjr4jQRpErwcjnBw0eVaz3d93dNNyA38 RZrB+YPsfsuoz+WNIff/FUq9xvOmcBuWW0p1m7IMJzfOBEXmke3rZuFtM4I8SQ3FkV2t oA50NSwlHFoDmw9eAiHRXb4wbMh4qzrp/gBrson28GcWyrncIuwi9PaY196jnsKwzE2X lIW3CKZ2QZ1F2yN8PO02UrCV3Nnjc7D0eU9+5kKLArFYDN6bH3P99mt+/pVyAZ5Vp+pb t/7Lm6LtiaXV0D6dY6xKCvx1Ro2+QCT4Mb97Vtx5ro9rVDgSjCkZ9FBrH11XL6fqYxL1 uT3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:sender:dkim-signature; bh=QrpziiuRPJpNoKcFlKlNDYP3hr3GKLDf970mOGtKvuc=; b=GBtgvsydLD1WMV3aBEZO8TMNRWE0Wk0bYlLQNGkV7GuvGBkstwBnP3Js01Z+WSGr3H 3Rl/DxU2hecdjCe47eygQ2RPKzrRLH7WedREm5kukHLJ+gYp8Wf2epdgd5ukZletBxvb +UW3hSXVZMMYBrcIowAOzGSm8LkiOnuesVckRR2ksgeTSOAmSm1eawkOkBxajeqHLgfc HeQFZmWcWyc9GeRsd5Iiy45r67LX+YEyhO6t5dCmhOvbjY4YrYw9oW+ud+3KAfMrAplR GPcvsHshLzzKm8Kq65L6ud6wKdhL1HNQCT0cS6LWdneL5xJWoMn5Itn4wDPEjfbmvxZq ZDOg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=Fj4FzNjR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u11-20020a6540cb000000b0051ace49ded1si2117304pgp.886.2023.05.05.08.48.04; Fri, 05 May 2023 08:48:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=Fj4FzNjR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232307AbjEEPTQ (ORCPT + 99 others); Fri, 5 May 2023 11:19:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52098 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231941AbjEEPTP (ORCPT ); Fri, 5 May 2023 11:19:15 -0400 Received: from mail-pf1-x433.google.com (mail-pf1-x433.google.com [IPv6:2607:f8b0:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 334924C26; Fri, 5 May 2023 08:19:14 -0700 (PDT) Received: by mail-pf1-x433.google.com with SMTP id d2e1a72fcca58-63b5ce4f069so2082646b3a.1; Fri, 05 May 2023 08:19:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683299953; x=1685891953; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:sender :from:to:cc:subject:date:message-id:reply-to; bh=QrpziiuRPJpNoKcFlKlNDYP3hr3GKLDf970mOGtKvuc=; b=Fj4FzNjR0Oz19A6ZjISxtRCIB+gQ3mormqowoEF1ln4EAGyvrsBXyRSKbqhyQLC+in o5fjKNvQ/yN0VkIUe2FBxZQFo8CuBxoJ2BHDLSjYh8+HdnZ3QVP+E3dS2Plzshy/p0pl Hf+Ipbvxtcy7Hi/3cT8d8Gb8J4VkAhSsEMdiy5ZKUcaPh932ZSd20eO3fYebZugEA49X mUUklW5aR3Rdjne/IP0kOlzyLqAlnitsZ0Nl/BTITfGcIQAdz5oicdNCa7j+DyuEkA1C Vd0a06+ACDVmjHz4Tb9Av8qWUmDjShH/SvaPwFsAA9tTqizN1m3Qn5TBxTXirG2Ivak4 dJgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683299953; x=1685891953; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:sender :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QrpziiuRPJpNoKcFlKlNDYP3hr3GKLDf970mOGtKvuc=; b=hrOZW/YFg5kxhx+/9L/A8X5HRIqkxVQUDLrPr0jCrpd2/yV4o4b+JuEpnuN1akukFH kpr2PX3iarMyqjc8owWSji8SQi+JcYMZzrq0ovxJ7442tjB6Xw5KXQfVLMOSlOT8ZSL8 b5+CgSkDiHd9P4zFZhFcJJGkJZ7iqV/EhjzYm71+gh1D3ejZ5ZyQS4eT7NHSFGx1prVO HLevuO/rdTstnPYH/Zjfn7RPwlb9lKD97rOjrDYUMS14/KlSB+srcmmH4oC/bsphtHSk S8nJ7nnnnftFXYwEhLeWEfDj5QKYeLQlD07fKgjABFmQvFpXdguahU2C4ZSVHbqKLzno ugaA== X-Gm-Message-State: AC+VfDylVPKYFLvygS8BCOBYdCLwtvk0YwME+8I3pV/w8DHq3DL936KS cLY1p4ZBRc0YfAOFjA9x9Ig= X-Received: by 2002:a05:6a20:1583:b0:f2:3c0e:99fa with SMTP id h3-20020a056a20158300b000f23c0e99famr2447784pzj.26.1683299953266; Fri, 05 May 2023 08:19:13 -0700 (PDT) Received: from localhost (2603-800c-1a02-1bae-a7fa-157f-969a-4cde.res6.spectrum.com. [2603:800c:1a02:1bae:a7fa:157f:969a:4cde]) by smtp.gmail.com with ESMTPSA id t9-20020a170902b20900b001960706141fsm1939802plr.149.2023.05.05.08.19.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 May 2023 08:19:12 -0700 (PDT) Sender: Tejun Heo Date: Fri, 5 May 2023 05:19:11 -1000 From: Tejun Heo To: Yosry Ahmed Cc: Alexander Viro , Christian Brauner , Johannes Weiner , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , Andrew Morton , Jan Kara , Jens Axboe , Michal =?iso-8859-1?Q?Koutn=FD?= , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v5 2/5] memcg: flush stats non-atomically in mem_cgroup_wb_stats() Message-ID: References: <20230421174020.2994750-1-yosryahmed@google.com> <20230421174020.2994750-3-yosryahmed@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230421174020.2994750-3-yosryahmed@google.com> X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 21, 2023 at 05:40:17PM +0000, Yosry Ahmed wrote: > The previous patch moved the wb_over_bg_thresh()->mem_cgroup_wb_stats() > code path in wb_writeback() outside the lock section. We no longer need > to flush the stats atomically. Flush the stats non-atomically. > > Signed-off-by: Yosry Ahmed > Reviewed-by: Michal Koutn? > Acked-by: Shakeel Butt Acked-by: Tejun Heo Thanks. -- tejun