Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <55343361-d991-c157-4a88-843947aa45ff@intel.com>
Date:   Fri, 5 May 2023 09:42:36 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [tip: perf/core] x86/cpu: Add helper function to get the type of
 the current hybrid CPU
Content-Language: en-US
To:     linux-kernel@vger.kernel.org, linux-tip-commits@vger.kernel.org
Cc:     Ricardo Neri <ricardo.neri-calderon@linux.intel.com>,
        "Peter Zijlstra (Intel)" <peterz@infradead.org>,
        Tony Luck <tony.luck@intel.com>,
        Len Brown <len.brown@intel.com>, Borislav Petkov <bp@suse.de>,
        x86@kernel.org
References: <1618237865-33448-3-git-send-email-kan.liang@linux.intel.com>
 <161891560955.29796.10811256921836669612.tip-bot2@tip-bot2>
From:   Dave Hansen <dave.hansen@intel.com>
In-Reply-To: <161891560955.29796.10811256921836669612.tip-bot2@tip-bot2>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 4/20/21 03:46, tip-bot2 for Ricardo Neri wrote:
> +#define X86_HYBRID_CPU_TYPE_ID_SHIFT	24
> +
> +/**
> + * get_this_hybrid_cpu_type() - Get the type of this hybrid CPU
> + *
> + * Returns the CPU type [31:24] (i.e., Atom or Core) of a CPU in
> + * a hybrid processor. If the processor is not hybrid, returns 0.
> + */
> +u8 get_this_hybrid_cpu_type(void)
> +{
> +	if (!cpu_feature_enabled(X86_FEATURE_HYBRID_CPU))
> +		return 0;
> +
> +	return cpuid_eax(0x0000001a) >> X86_HYBRID_CPU_TYPE_ID_SHIFT;
> +}

Hi Folks,

Sorry to dredge up an old thread.  But, where does this information
about "If the processor is not hybrid, returns 0." come from?

What is there to keep cpuid_eax(0x0000001a) from having 0x0 in those
bits?  Seems to me like 0 is theoretically a valid hybrid CPU type.  Right?