Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <3af0c3a9-70b8-4c2b-8ab9-dd43c531b3b6@linaro.org>
Date:   Fri, 5 May 2023 18:48:18 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.1
Subject: Re: [PATCH v4 1/3] dt-bindings: iio: pressure: Support Honeywell
 mprls0025pa sensor
Content-Language: en-US
To:     Andreas Klinger <ak@it-klinger.de>, linux-iio@vger.kernel.org,
        devicetree@vger.kernel.org
Cc:     Jonathan Cameron <jic23@kernel.org>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Angel Iglesias <ang.iglesiasg@gmail.com>,
        linux-kernel@vger.kernel.org
References: <ZFUC6Tsku+aWod/+@arbad>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <ZFUC6Tsku+aWod/+@arbad>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 05/05/2023 15:21, Andreas Klinger wrote:
> Honeywell mprls0025pa is a pressure sensor series. There are many
> different models with different pressure ranges, units and transfer
> functions.
> 
> The range and transfer function need to be set up in the dt. Therefore
> new properties honeywell,pmin-pascal, honeywell,pmax-pascal,
> honeywell,transfer-function are introduced.
> 
> Add dt-bindings.
> 
> Signed-off-by: Andreas Klinger <ak@it-klinger.de>
> ---
>  .../iio/pressure/honeywell,mprls0025pa.yaml   | 104 ++++++++++++++++++
>  1 file changed, 104 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/iio/pressure/honeywell,mprls0025pa.yaml
> 
> diff --git a/Documentation/devicetree/bindings/iio/pressure/honeywell,mprls0025pa.yaml b/Documentation/devicetree/bindings/iio/pressure/honeywell,mprls0025pa.yaml
> new file mode 100644
> index 000000000000..84a61721b597
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/pressure/honeywell,mprls0025pa.yaml
> @@ -0,0 +1,104 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/pressure/honeywell,mprls0025pa.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Honeywell mprls0025pa pressure sensor
> +
> +maintainers:
> +  - Andreas Klinger <ak@it-klinger.de>
> +
> +description: |
> +  Honeywell pressure sensor of model mprls0025pa.
> +
> +  This sensor has an I2C and SPI interface. Only the I2C interface is
> +  implemented.
> +
> +  There are many models with different pressure ranges available. The vendor
> +  calls them "mpr series". All of them have the identical programming model and
> +  differ in the pressure range, unit and transfer function.
> +
> +  To support different models one need to specify the pressure range as well as
> +  the transfer function. Pressure range needs to be converted from its unit to
> +  pascal.
> +
> +  The transfer function defines the ranges of numerical values delivered by the
> +  sensor. The minimal range value stands for the minimum pressure and the
> +  maximum value also for the maximum pressure with linear relation inside the
> +  range.
> +
> +  Specifications about the devices can be found at:
> +    https://prod-edam.honeywell.com/content/dam/honeywell-edam/sps/siot/en-us/
> +      products/sensors/pressure-sensors/board-mount-pressure-sensors/
> +      micropressure-mpr-series/documents/
> +      sps-siot-mpr-series-datasheet-32332628-ciid-172626.pdf
> +
> +properties:
> +  compatible:
> +    const: honeywell,mprls0025pa
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  reset-gpios:
> +    description:
> +      Optional GPIO for resetting the device.
> +      If not present the device is not resetted during the probe.
> +    maxItems: 1
> +
> +  honeywell,pmin-pascal:
> +    description:
> +      Minimum pressure value the sensor can measure in pascal.
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +
> +  honeywell,pmax-pascal:
> +    description:
> +      Maximum pressure value the sensor can measure in pascal.
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +
> +  honeywell,transfer-function:
> +    description:

Here you need | to preserve formatting.

> +      Transfer function which defines the range of valid values delivered by the
> +      sensor.
> +      1 - A, 10% to 90% of 2^24 (1677722 .. 15099494)
> +      2 - B, 2.5% to 22.5% of 2^24 (419430 .. 3774874)
> +      3 - C, 20% to 80% of 2^24 (3355443 .. 13421773)
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +
> +  vdd-supply:
> +    description: provide VDD power to the sensor.
> +
> +required:
> +  - compatible
> +  - honeywell,pmax-pascal
> +  - honeywell,pmin-pascal
> +  - honeywell,transfer-function
> +  - reg
> +  - vdd-supply

Keep the same order as they appear in properties:.

Rest looks good, so with these fixes:


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>


---

This is an automated instruction, just in case, because many review tags
are being ignored. If you do not know the process, here is a short
explanation:

Please add Acked-by/Reviewed-by/Tested-by tags when posting new
versions, under or above your Signed-off-by tag. Tools like b4 can help
here. However, there's no need to repost patches *only* to add the tags.
The upstream maintainer will do that for acks received on the version
they apply.

https://elixir.bootlin.com/linux/v5.17/source/Documentation/process/submitting-patches.rst#L540

Best regards,
Krzysztof