Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 5 May 2023 10:19:29 -0700
From:   Colin Foster <colin.foster@in-advantage.com>
To:     Maxime Chevallier <maxime.chevallier@bootlin.com>
Cc:     Mark Brown <broonie@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "Rafael J . Wysocki" <rafael@kernel.org>,
        Lee Jones <lee@kernel.org>, linux-kernel@vger.kernel.org,
        thomas.petazzoni@bootlin.com, alexis.lothore@bootlin.com
Subject: Re: [PATCH] regmap: don't check for alignment when using reg_shift
Message-ID: <ZFU6oepWPoYDJczo@euler>
References: <20230420150617.381922-1-maxime.chevallier@bootlin.com>
 <ZEKwxhJJNkuX7VTr@colin-ia-desktop>
 <bb836be3-456c-48fd-9b19-62279fee6b8d@sirena.org.uk>
 <20230428093010.07e61080@pc-7.home>
 <20230428094745.63677228@pc-7.home>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230428094745.63677228@pc-7.home>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?d++YK+JzZOCY8wSMdIYI4kkJqbDsSnLQun/+GW5WwgCGDB04UDfdRuo746dN?=
 =?us-ascii?Q?TSV02wrrYswjVu46n1j5c81Jy9Xif03xdYjTKVag2rB3VjpSG09VQzKYJEqs?=
 =?us-ascii?Q?SXmovflo3naL3K83lPoGCN7GKxpijzITvxy1l4EdkV0j85xO5W1rfDw2bMVN?=
 =?us-ascii?Q?3gRBWBPYmxBNt+t/UzcLiAXJaJ1G20P6YnkG2z17Py7UVKhhhsBbUdTthMlR?=
 =?us-ascii?Q?t5yjOnDVqXyM/T1WTSlAs6s4ph0sDga4uHUyqGUTenyyfXoQa2roRkN/q8oM?=
 =?us-ascii?Q?vIFX6xU/cuGtK0c1NhwBSOfiHz1T4qE12CdsHRkILFJZrOm5RbzbTFGLi5Ut?=
 =?us-ascii?Q?W3vYveZcLuuxZ1TI7FXz34l/FAtrWjrp2cOn6TREetWn4QmTHn3vjxw+HPLm?=
 =?us-ascii?Q?VycbbqztOFNcfCUoUG/XmWJDz3TeDoKayudC/sCBRSJ7yCXJxn9SZeW2YOqI?=
 =?us-ascii?Q?MZG5y2NzieADisEXClDA0npEsrFA5RU1EdyKTH6xHP9mJqmNEjFPBAK4SGxt?=
 =?us-ascii?Q?TIhgHHMbw9s9uFJMKl9v+FHBPARkTpaiy/YY6fON8csvrkWZSrvQEeXOI4f5?=
 =?us-ascii?Q?J6HWYzwUSAmwq8ZOssdJ1fV6LSiY1bNVZ7qYEQoxJBQV+MCb2G8zstbxWkrn?=
 =?us-ascii?Q?2QB83clScPLVGHQEeqxyJ98iOiN8hXNYwSnrgSOmCCnpjXPL1sjgKExL6OBB?=
 =?us-ascii?Q?NC28g90vWwOX/to7IawSH4GnOyJgnINbmR7ND8JKaRoCvdbM6fig1WV5blYP?=
 =?us-ascii?Q?53kkLKS/KT12GXxhEO5qC3YA5Q+iPLnl6qfj1rPL500bVZ3DO3zxKmIn/yQr?=
 =?us-ascii?Q?uy0qqdA7v+FNY4y6uwsRu+VaOx5fShzY+ipvkuXZH6fWx1VlvWezULHuxpKd?=
 =?us-ascii?Q?0m6PG2ohJT3CtvKtxh/2+fXVX0d08InIuFCJbEDpbn4BPYXgGQvBfw838CZi?=
 =?us-ascii?Q?+X6GA5agLomuHxRmoEwL/fDkCMr9z9w4Ksfav7q3uZTydRauCJ2zXL5GHCk4?=
 =?us-ascii?Q?Kclr5YfTIQJj9aiqZy193rvg/tyP0DJyxeMXS/VoaJt5N1zIkJiZqWF6zPMg?=
 =?us-ascii?Q?WEj5z/Vjt+vOR3z2+otDtiGMpgGdx0CPSo+3sfn7keoJFb+KSLbsuPVJ2VdV?=
 =?us-ascii?Q?MqT0+dFvdWRips90gZmYmH1DknT8kyIIqmejZvVqpc5ee5f1f0LAQlU/PbxN?=
 =?us-ascii?Q?CGSS/NqKIY/+Xg7qfhInhSpPzMzvCAQj94sh4AU5LH7c0nOi01cKiRZzk5e2?=
 =?us-ascii?Q?WHZTuyLunz5bOZb6tYHT7CpBFgW7Sb9zjh3z1BW7kOcxBG+HFYpV5bi/svA1?=
 =?us-ascii?Q?jyY2519+sEvEHkwvNDmEZdcVVnGtB7HwWN9/kZC2ZYFWkBDOrY/V0mmktprx?=
 =?us-ascii?Q?YNrCkddc0TyYVAE1saB7HHuOEmYNlzVr9YxzQ2LwpmvrYIFbzZevavq+aHzn?=
 =?us-ascii?Q?bQuiuPxm9mLyIBmVDKTjx65dNgczZMRqSr4p1WvOjod1g+cKdbPRuVH0n4pt?=
 =?us-ascii?Q?JosjdwVNY2Pwb6QwZOWHnMwtc3nT6qORNxe3cvc3EAGwE91CBm+Z902SEvhu?=
 =?us-ascii?Q?Sw2qjit2LM3Bb9EQepMIfN88N/IFXykYqKt9u7w1mTalaBOlqjefnkcfHqZE?=
 =?us-ascii?Q?uA=3D=3D?=
X-OriginatorOrg: in-advantage.com
X-MS-Exchange-CrossTenant-Network-Message-Id: abe37dbc-9aa6-4409-d734-08db4d8ce444
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2351.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2023 17:19:32.7375
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 48e842ca-fbd8-4633-a79d-0c955a7d3aae
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hvakP1Ze8F/I4Q4bWHalc+3MaYuqDUgrD1CprVKGi9fhiImQe5GNgHKVoZxLuTW8K5HXtJUwtl4wzq8FHq/F8LZ2NBLXdcNYlgXX/jGI5is=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR10MB7217
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Maxime,

On Fri, Apr 28, 2023 at 09:47:45AM +0200, Maxime Chevallier wrote:
> On Fri, 28 Apr 2023 09:30:10 +0200
> Maxime Chevallier <maxime.chevallier@bootlin.com> wrote:
> 
> > Hello Mark, Colin,
> > 
> > On Tue, 25 Apr 2023 13:56:23 +0100
> > Mark Brown <broonie@kernel.org> wrote:
> > 
> > > On Fri, Apr 21, 2023 at 08:50:30AM -0700, Colin Foster wrote:  
> > > > On Thu, Apr 20, 2023 at 05:06:17PM +0200, Maxime Chevallier
> > > > wrote:    
> > >   
> > > > > On regmap consumers that require address translation through
> > > > > up/downshifting, the alignment check in the regmap core doesn't
> > > > > take the translation into account. This doesn't matter when
> > > > > downshifting the register address, as any address that fits a
> > > > > given alignment requirement will still meet it when downshifted
> > > > > (a 4-byte aligned address will always also be 2-bytes aligned
> > > > > for example).    
> > >   
> > > > > However, when upshifting, this check causes spurious errors, as
> > > > > it occurs before the upshifting.    
> > >   

Sorry for a really delayed response, but I just got back around to
thinking about this. Crazy busy times for me.

What about an explicit parameter in regmap_config that will disable
alignment checks? That seems like it might be a welcome feature
addition.


Colin Foster