Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Liam R. Howlett" <Liam.Howlett@oracle.com>
To:     Andrew Morton <akpm@linux-foundation.org>
Cc:     maple-tree@lists.infradead.org, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org,
        "Liam R. Howlett" <Liam.Howlett@Oracle.com>,
        "Liam R . Howlett" <Liam.Howlett@oracle.com>
Subject: [PATCH v2 08/36] maple_tree: Change RCU checks to WARN_ON() instead of BUG_ON()
Date:   Fri,  5 May 2023 13:41:36 -0400
Message-Id: <20230505174204.2665599-9-Liam.Howlett@oracle.com>
In-Reply-To: <20230505174204.2665599-1-Liam.Howlett@oracle.com>
References: <20230505174204.2665599-1-Liam.Howlett@oracle.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?BaFQDCkdvGgyx0BHFUXcXLlwJgHldSLPxgIQArM0B6xBW5AHqnREzvzHjDog?=
 =?us-ascii?Q?V1+1YXDRsqQa6xkoJvS0a12K50+58Y+A133QtnuG2Vjw7xDRG1Zyyjvv0K7c?=
 =?us-ascii?Q?S0/PTqMZwJni7Ivo9GckLv3I3xeC1be58UUkaZHk9PgcCd6f90LTVLpCcJHQ?=
 =?us-ascii?Q?iO22rU8Q5X81tPhz12n679w9bk9gBMD/ad55n9NGbgMC+b45TG896lrCVIL2?=
 =?us-ascii?Q?N+fuNucQNIB27cl4kIgSvH/aL0PxU//SLosHgFq5O5f0gXAUF+blU02Z2VWh?=
 =?us-ascii?Q?zfCtFwyS/AZbPC37I3FJRzL+fmBe86WZ1nD+h0moJmhcWdLCzBwprTlbEdCq?=
 =?us-ascii?Q?NXFhBVYGaVj3Pz5ikpt+J9h+e6m3hu4EgKy9jkIiTsV7WScK7GZ0ptHwo5FQ?=
 =?us-ascii?Q?FYMNimXKioD7kmv/dy24fTNNOz5XUI6T9VJpIrs4NPwXH1YtPCeR1zGiZjkv?=
 =?us-ascii?Q?ac7rEbXxWgCfiHZ/cq2wVCL69DU3uBA6b44xynV7svB+m7qnvIQ3c/3b2jAG?=
 =?us-ascii?Q?jIcoCsqf1phCAteKdla/LAMVAU6K8BxAhAPOePVgbGbLv94AVnHaQ+5OwJMu?=
 =?us-ascii?Q?7G/vKX+389w6gIQ3zViTMX6j4Uwun9s4C1Y1NRcSTu+MEzALvi6pXx5ecLn+?=
 =?us-ascii?Q?9Lf0MNMXSbxOFeLjI9SzhzNBUsz/nxlMmW+tq8kAXhs8C2W0HkB/t+3/sNj4?=
 =?us-ascii?Q?JFQbxYjrwwjaJ0D6o4rKcDD0h6AtsVWDPwUM4pnAhqelPx9LNV86n2QIzd4n?=
 =?us-ascii?Q?m7wy65dmbQDLIaxsUCFtpEmdD8GsCFucQzM/Te9FniwKX+CmxbNFB8t6PHuc?=
 =?us-ascii?Q?btitz94s4uYeYDWl3Xmiqt/bmlUU2nN73VW611nIONOt1f8K3DYbHqqiMTrv?=
 =?us-ascii?Q?eGg7f4Jq0OGXdPVBTN9+LzZgbzBCZ0s/LQspMtYQLRc+VY8Ht7H9CVeNu0WL?=
 =?us-ascii?Q?IMy8v1IzTa3HxYrUQNsJz/gR+njrXU8SvKeLwJWa6gIqhwE45Bgz5dztlirD?=
 =?us-ascii?Q?hbEXKNS75u2qB3LsJ2sD96OrSQC4dyJ0ccGsnITL2+xUIUtOrCCe+1Ic7jGs?=
 =?us-ascii?Q?lOTs426JgGvnYNMef2NUJDwqH+gK5pIFSOd6A+7v22NMnAOD8fxuh+kS84pE?=
 =?us-ascii?Q?tyl1MKithJCaixdhxd7LuaUQZQfb37nhJoa6RPikwRWL2IxStg9QdpNuMBxL?=
 =?us-ascii?Q?UDzcNQYkFZdefCmzQ2btwiBaexoju/D20z823drrnAsPblOf9vZtD3Xd1DZD?=
 =?us-ascii?Q?5kazgA+uVCPL2N6q/lwe0mCX2YnLCy/avePZvFQVv2jhPvGSnxmnMXP9JOjq?=
 =?us-ascii?Q?2Innrpb0NmtVcUsNxpTD4aj6trlEuxrYM3OE/jxVuwSeWQAVfOeJP7CBR+lQ?=
 =?us-ascii?Q?WjvN/kRRkpz0beh2PtPoWl5z3Rp6TFp6X2sRtPNxp1HPv+aUNqSND/cTD7JC?=
 =?us-ascii?Q?lKw0U+tFHve4LlckD3uNnE+b0m1e9s7xCL+KQJ+aBfuyKehPXj7d7RaNJB2y?=
 =?us-ascii?Q?CtaGZLSQeQlhODyh6Y5vs0RvFpDNiwRebS7MEGsDPTg8Bkzlx+zHsdua/ilm?=
 =?us-ascii?Q?QXEnV/ANu4TcFMcKHVpdL7lb9E+ZGfthUuMbCWk/JX+NaK9kZoJ5o/V7A23c?=
 =?us-ascii?Q?Sg=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: prYBFNYLuddNwBT7bPBmSR5bFn0V5dSUiXQNv4jak3avRiNcfLcR1S2II+xL7u/INEqkDRQvSpOdJi8RMPfM5q4fUQJGO3U+yfBjbwlD4QADATniFBzXbhhx981MMV4xBB9BvhWRZggCBDfMwtc7yPSv4H5ZxIViap6zO0R9vVQyaPLgIEv8ALEHX3Opah7pkNWfNI1QKRdLiZ5/WdX7WFroi5jJLRvbouRNYdJM6vO/3jY+OrSDusL2D7+fJihqOdj6jy9ioh4X4WYa3CnQhWART6OtKU1ChDR91xU4koRt0ZJ2dd8LpcQ+vrfvoVryXQh85nXlfTYbJccQ918m3mPRp1Dq5rBlkj961vMAGWyzTH60vv8aDjyigxm1AaTbH1AHjwpR69Ab6bXQi1Y8BxxLpgvx1KXed47MRH3pBx0aQPPJ8qyTWaKOvgAaK0XJVncdiARcju1KZ3fwj7moSbp0xUOHQO4QemLk0Xryw2cUmWoZ+C/o9Iv9DPXLEqaNytr8syz4Z/hIMwQn1rKvLjDOLC7hn6KiZkaGk3ydr/FmCZBnshXnXBzAr/+qdNLgoqYnn2X6P6giGfVhgDUI8Dn57SwwjQMuBWzj0UAKRK1Dc/2RDgwpCsulY6v69WX74MPL+Y3II/bJoWyGhrHl+MCdLvVR7W1JX+Ri6xqMgmnO0gi3IzEr6FqNYHo4KWD1e0/11ApHyd6EaLg9dKmKSgaQxtA/iieub5QxwOO5+ebUDeokjYIZIhVlDXUraAP1eQltdRWxCh//j1prJD5+I0DnswPNWnU0znPq0V8oPG7d65Exh3QpPoKJEEDGDEpEXjnImRYpEGtaTGTvQklZvE2DN8UaTb8kqHNSM2ebw9HFGV9K1zz7j2LDUFqRpdIPa1FvtT5Ajx3ihW12mOf/uA==
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 902de8eb-59db-4565-3005-08db4d904ea8
X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB3022.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2023 17:43:59.4541
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 9B4GKTkRymNlPT0CCMCPBmnUgYAziN8daov0Eg4PtDoyusqnvGeQAz/Ivm+O3ploK6CldBTmOSIR6xuvyy0lHQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR10MB6089
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-05-05_24,2023-05-05_01,2023-02-09_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0
 mlxlogscore=999 spamscore=0 phishscore=0 adultscore=0 mlxscore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2303200000 definitions=main-2305050146
X-Proofpoint-GUID: SsO2WRPHfTzJBXWP9TYV7fuokPEnX2Wz
X-Proofpoint-ORIG-GUID: SsO2WRPHfTzJBXWP9TYV7fuokPEnX2Wz
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: "Liam R. Howlett" <Liam.Howlett@Oracle.com>

If RCU is enabled and the tree isn't locked, just warn the user and
avoid crashing the kernel.

Signed-off-by: Liam R. Howlett <Liam.Howlett@oracle.com>
---
 include/linux/maple_tree.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/linux/maple_tree.h b/include/linux/maple_tree.h
index 204d7941a39ec..ed92abf4c1fb5 100644
--- a/include/linux/maple_tree.h
+++ b/include/linux/maple_tree.h
@@ -616,7 +616,7 @@ static inline void mt_clear_in_rcu(struct maple_tree *mt)
 		return;
 
 	if (mt_external_lock(mt)) {
-		BUG_ON(!mt_lock_is_held(mt));
+		WARN_ON(!mt_lock_is_held(mt));
 		mt->ma_flags &= ~MT_FLAGS_USE_RCU;
 	} else {
 		mtree_lock(mt);
@@ -635,7 +635,7 @@ static inline void mt_set_in_rcu(struct maple_tree *mt)
 		return;
 
 	if (mt_external_lock(mt)) {
-		BUG_ON(!mt_lock_is_held(mt));
+		WARN_ON(!mt_lock_is_held(mt));
 		mt->ma_flags |= MT_FLAGS_USE_RCU;
 	} else {
 		mtree_lock(mt);
-- 
2.39.2