Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <5d02d54b-60a0-fc43-7340-238b910e22b4@intel.com>
Date:   Fri, 5 May 2023 10:47:18 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.10.1
Subject: Re: [PATCH v4 0/7] x86/resctrl: Miscellaneous resctrl features
Content-Language: en-US
To:     "Moger, Babu" <Babu.Moger@amd.com>,
        "corbet@lwn.net" <corbet@lwn.net>,
        "tglx@linutronix.de" <tglx@linutronix.de>,
        "mingo@redhat.com" <mingo@redhat.com>,
        "bp@alien8.de" <bp@alien8.de>
CC:     "fenghua.yu@intel.com" <fenghua.yu@intel.com>,
        "dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
        "x86@kernel.org" <x86@kernel.org>, "hpa@zytor.com" <hpa@zytor.com>,
        "paulmck@kernel.org" <paulmck@kernel.org>,
        "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
        "quic_neeraju@quicinc.com" <quic_neeraju@quicinc.com>,
        "rdunlap@infradead.org" <rdunlap@infradead.org>,
        "damien.lemoal@opensource.wdc.com" <damien.lemoal@opensource.wdc.com>,
        "songmuchun@bytedance.com" <songmuchun@bytedance.com>,
        "peterz@infradead.org" <peterz@infradead.org>,
        "jpoimboe@kernel.org" <jpoimboe@kernel.org>,
        "pbonzini@redhat.com" <pbonzini@redhat.com>,
        "chang.seok.bae@intel.com" <chang.seok.bae@intel.com>,
        "pawan.kumar.gupta@linux.intel.com" 
        <pawan.kumar.gupta@linux.intel.com>,
        "jmattson@google.com" <jmattson@google.com>,
        "daniel.sneddon@linux.intel.com" <daniel.sneddon@linux.intel.com>,
        "Das1, Sandipan" <Sandipan.Das@amd.com>,
        "tony.luck@intel.com" <tony.luck@intel.com>,
        "james.morse@arm.com" <james.morse@arm.com>,
        "linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "bagasdotme@gmail.com" <bagasdotme@gmail.com>,
        "eranian@google.com" <eranian@google.com>,
        "christophe.leroy@csgroup.eu" <christophe.leroy@csgroup.eu>,
        "jarkko@kernel.org" <jarkko@kernel.org>,
        "adrian.hunter@intel.com" <adrian.hunter@intel.com>,
        "quic_jiles@quicinc.com" <quic_jiles@quicinc.com>,
        "peternewman@google.com" <peternewman@google.com>
References: <168177435378.1758847.8317743523931859131.stgit@bmoger-ubuntu>
 <d0e72b31-1865-9e23-51c9-5c43cd71084e@intel.com>
 <MW3PR12MB455312E6A33BA29FD355745595729@MW3PR12MB4553.namprd12.prod.outlook.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <MW3PR12MB455312E6A33BA29FD355745595729@MW3PR12MB4553.namprd12.prod.outlook.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Kzh0Wi9rd3MxekFzczVBODdjYWxpNGE2MmlySU5vSlpWNGVGNE56NXBHTG9K?=
 =?utf-8?B?MlF1YXFKVUhwaGR4SXdQL2p0RE1oRGlEQ3BLaGdlbThEaHB6M2liSFUwVkx2?=
 =?utf-8?B?TU1aY25EWStJZmJLa3M1ZmNkVFVUVFNHUUxxZEErcXdDMTRJTTJwMVJMRDRQ?=
 =?utf-8?B?K1VtSnptdE5QNDU4eExlVnMrRFBub3ZPUVVMQTh6ZUNvN2pEU2p6V00xQkZj?=
 =?utf-8?B?UjVoN09ZOExzVGdxaUNMUm5KMXdOQjJ1UUYzcTNnOUlmdTlUOWx0cXVQcVhC?=
 =?utf-8?B?bUNZUHQyN2NSNVdqQkZOZ2N2N1QxMUFBaStVYnhteFBtMk1NV0Ryc2FwQWpB?=
 =?utf-8?B?VUFhbXpsUmNaTGg4eVRDYVlUbzQ1WFBhN0dlZGZSMW53SXExaXJIUzkweEh5?=
 =?utf-8?B?OTB6WVBNK2FDN2FSWGI1VUxkdlZvRXlxcXJtUkFBNEV4RGxQZnRyNGNnLzJo?=
 =?utf-8?B?V3pHYjl4WVNGaFpkVUhVUHN4VjhCNVArRXJpQ0tPUms0dnFLUS8vMldZbHBI?=
 =?utf-8?B?SnN5UERRV25HbGtvY0wrRHdoMUlpbFFuYnptdXRQcUxIbVpNRVhjVFJIZ0U5?=
 =?utf-8?B?VURCTXltTEdGalowUkRtK0c2d003bHRKaitPOVprS2FUSmFIQkd0OXlmWDQ2?=
 =?utf-8?B?bCt3OE9xNXRLejc2eDJRaUk2cC94cTlYOEwrMzZVZnlZN1dGWXQvZ0t0OW1G?=
 =?utf-8?B?N0JWV25YVmsvdko4Z3ZTQzgzaWltTDVFWE92K01rb002eTBRQ0FXY0dUTjQ5?=
 =?utf-8?B?WTdlWUhwRy9USlRSL2hxeWpoUi9QSUNtZEM1Y2dsL080OHY2Y3VKLzd2SlBo?=
 =?utf-8?B?VkI4elRCSWJtdGF6emVuRGdXdUZVKzhzY3BvZ0NxT3IyQmNsWE5CRitHMitX?=
 =?utf-8?B?Zis5ei83R3dpUGVtMHhITmFLVFRINEphRHZGZ28zNFIxM1dHdzJsazZ0TmR1?=
 =?utf-8?B?QnZybFRob1psZHpsOFNuQ1JDK0ZsYnNYRUVwUlhmVjFJcURBVFdZTkMzL1Vu?=
 =?utf-8?B?SzZOUXBaam4vdUNVelBVbVdjd1A5WFJCMHhxTy9xd3RoRHZIM1hlSlpnUmJ6?=
 =?utf-8?B?WWJQa3VQdUVtM1NHdmhTSmxnRFZQeU5mSUhXTWpsa0p1emhKWmsxU3gxV0ZQ?=
 =?utf-8?B?aHhZcmhJVzdoMlhUemE0ZE40OGIzSkZ2dzVDbU1jRitPeFBsTDVweWUvaDFX?=
 =?utf-8?B?UEptcEt5bjhLWGx4SHQ3YU9Fd3BlWTYvaWJIOUNYeVVIR0crcUdxMHV4Q250?=
 =?utf-8?B?WlRsZlg5L1QwNVc0NVdXWllIQjlKQmJXbDNJVjV5cWo4T1d4dzBKSFZwUFpj?=
 =?utf-8?B?MHpSMS9UaWJMM2UyUnVkaDg4UDl1cVBmdHZCQXVwM3V1QnI1NC9DUjdEWU1C?=
 =?utf-8?B?ZHNZWWxuQWNoVXVvajNXY2ZmNkZrOXpJTjAyMjVYUEJTaDZncUZ3VTJFUzNr?=
 =?utf-8?B?V2xaT1EvaFR1MjNnWGo4WlNKTkRBRCtyWWRoa3p4RVMweWdPcTFTWEF5eWY1?=
 =?utf-8?B?WCtadjdjRGZzS0hlTno2U0hiYU50YW9jSy9zNllDL0NjTGVzSTJwTlR3VVMy?=
 =?utf-8?B?YWl3K3JWaDc3R1FCdEkzd2FlZi9wd1J1d0xGL3ViSXVZdi9ka29hd3lPcTVr?=
 =?utf-8?B?ejd0QndDU090ZXo1SGVkN1paay9oeGlEK20xKzBoTWJ0WFVsOHh6TWhDN1RQ?=
 =?utf-8?B?M3FGY1ZIQWFQR1JLQjVrT21yVUFRRGpRY2ZYdWY3bThCNHNnRHFZTVBQTnE1?=
 =?utf-8?B?ZXVIVGt4cHBQOXJET1VoZGZnVlc1MVZSM3ZCODVZSUVadkdGSmhDUFpqalNW?=
 =?utf-8?B?NHBONmR5bDF3WlJRMjBROS96NVpQOUV6MDJZSCsrV0o5bnhNeHFvZkQ1b2l6?=
 =?utf-8?B?WjNQaUtpbENxR2RDcG9lUGRnNTNKNG0vcDVnZVdUdElaK2RNeG1NVU4xcFc2?=
 =?utf-8?B?VWREQnBVeUdUQU8ybXorakh1MHY3ZktJSi9iOEZPL01lcjFXMnpGTXViVmdR?=
 =?utf-8?B?K3RzdkxabUhmdUt5dTJKMnhvRDdPMWJNeHdvWkd6cG96UkgyeFBQNnBIYkpC?=
 =?utf-8?B?YlNEQ2s3ODF2TGJSQU5TYitoMjRmTWE2WjIwWStURGdHWEpxWnBSRGdQdTNS?=
 =?utf-8?B?YWpYRGRIaUxvN2lKcVNHVzJXQnF2QzA3SGJkVHNCbGxYODZNQ0RzWkZ0TEVz?=
 =?utf-8?B?OXc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 2d6b0578-5f5d-4730-d5d6-08db4d90c6ac
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2023 17:47:20.8371
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: PP89wW7pDr7p7o04uYJY4UoEknc2AdWKhdu41+jC9BB6v18MruZkz94fxFTeqgXE4EHzyQvpq/KGBitmHEna9iXnNzTt5r/26LE/ndpf++U=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB8547
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-8.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Babu,

On 5/5/2023 8:43 AM, Moger, Babu wrote:
> [AMD Official Use Only - General]
> 
> Hi Reinette,
> 
>> -----Original Message-----
>> From: Reinette Chatre <reinette.chatre@intel.com>
>> Sent: Thursday, May 4, 2023 1:54 PM
>> To: Moger, Babu <Babu.Moger@amd.com>; corbet@lwn.net;
>> tglx@linutronix.de; mingo@redhat.com; bp@alien8.de
>> Cc: fenghua.yu@intel.com; dave.hansen@linux.intel.com; x86@kernel.org;
>> hpa@zytor.com; paulmck@kernel.org; akpm@linux-foundation.org;
>> quic_neeraju@quicinc.com; rdunlap@infradead.org;
>> damien.lemoal@opensource.wdc.com; songmuchun@bytedance.com;
>> peterz@infradead.org; jpoimboe@kernel.org; pbonzini@redhat.com;
>> chang.seok.bae@intel.com; pawan.kumar.gupta@linux.intel.com;
>> jmattson@google.com; daniel.sneddon@linux.intel.com; Das1, Sandipan
>> <Sandipan.Das@amd.com>; tony.luck@intel.com; james.morse@arm.com;
>> linux-doc@vger.kernel.org; linux-kernel@vger.kernel.org;
>> bagasdotme@gmail.com; eranian@google.com; christophe.leroy@csgroup.eu;
>> jarkko@kernel.org; adrian.hunter@intel.com; quic_jiles@quicinc.com;
>> peternewman@google.com
>> Subject: Re: [PATCH v4 0/7] x86/resctrl: Miscellaneous resctrl features
>>

...

>>>     Tried to address Reinette's comment on patch 7. But due to current code
>> design
>>>     I could not do it exact way. But changed it little bit to make it easy debug
>>>     file additions in the future.
>>
>> Could you please elaborate? It actually looks like you may be headed there next
>> according to:
>> https://lore.kernel.org/lkml/933d8ae2-d8b7-7436-5918-
>> f639405c9ecb@amd.com/
> 
> Sorry, I was talking about this comment.
> https://lore.kernel.org/lkml/fef12c9e-7d6f-bcd4-f92e-e776eb9e673b@intel.com/
> 
> I tried to address it here. 
> https://lore.kernel.org/lkml/168177451010.1758847.568218491528297451.stgit@bmoger-ubuntu/
> 
> This may not be the exact way you mentioned.  Reason is, adding the
> flags before rdtgroup_add_files cannot be done. It does not update
> the resctrl root filesystem. These files have to added by calling
> rdtgroup_add_file and kernfs_activate in rdt_enable_ctx.
I think what you are referring to is files not appearing in the default
resource group? From what I can tell the files should appear when new resource
groups are created. Could the default resource group's files not also
be added on resctrl mount (moved from rdtgroup_setup_root() to rdt_get_tree())?
I do not see why the files belonging to the default group are required to be
added before resctrl mount and with the move the resctrl_debug flag can
continue to be set in rdt_enable_ctx() and available to rdtgroup_add_files()
when adding the default resource group's files.

To me this sounds simpler since there is no duplicate file add/remove code,
and the debug files are just another file type.

Reinette