Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <efd45c71-2241-e0b8-e1c0-6fcc1e95b321@intel.com>
Date:   Fri, 5 May 2023 11:54:06 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.10.1
Subject: Re: [PATCH v4 2/7] x86/resctrl: Remove unnecessary rftype flags
Content-Language: en-US
To:     "Moger, Babu" <Babu.Moger@amd.com>,
        "corbet@lwn.net" <corbet@lwn.net>,
        "tglx@linutronix.de" <tglx@linutronix.de>,
        "mingo@redhat.com" <mingo@redhat.com>,
        "bp@alien8.de" <bp@alien8.de>
CC:     "fenghua.yu@intel.com" <fenghua.yu@intel.com>,
        "dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
        "x86@kernel.org" <x86@kernel.org>, "hpa@zytor.com" <hpa@zytor.com>,
        "paulmck@kernel.org" <paulmck@kernel.org>,
        "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
        "quic_neeraju@quicinc.com" <quic_neeraju@quicinc.com>,
        "rdunlap@infradead.org" <rdunlap@infradead.org>,
        "damien.lemoal@opensource.wdc.com" <damien.lemoal@opensource.wdc.com>,
        "songmuchun@bytedance.com" <songmuchun@bytedance.com>,
        "peterz@infradead.org" <peterz@infradead.org>,
        "jpoimboe@kernel.org" <jpoimboe@kernel.org>,
        "pbonzini@redhat.com" <pbonzini@redhat.com>,
        "chang.seok.bae@intel.com" <chang.seok.bae@intel.com>,
        "pawan.kumar.gupta@linux.intel.com" 
        <pawan.kumar.gupta@linux.intel.com>,
        "jmattson@google.com" <jmattson@google.com>,
        "daniel.sneddon@linux.intel.com" <daniel.sneddon@linux.intel.com>,
        "Das1, Sandipan" <Sandipan.Das@amd.com>,
        "tony.luck@intel.com" <tony.luck@intel.com>,
        "james.morse@arm.com" <james.morse@arm.com>,
        "linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "bagasdotme@gmail.com" <bagasdotme@gmail.com>,
        "eranian@google.com" <eranian@google.com>,
        "christophe.leroy@csgroup.eu" <christophe.leroy@csgroup.eu>,
        "jarkko@kernel.org" <jarkko@kernel.org>,
        "adrian.hunter@intel.com" <adrian.hunter@intel.com>,
        "quic_jiles@quicinc.com" <quic_jiles@quicinc.com>,
        "peternewman@google.com" <peternewman@google.com>
References: <168177435378.1758847.8317743523931859131.stgit@bmoger-ubuntu>
 <168177445556.1758847.5029687867896978170.stgit@bmoger-ubuntu>
 <4275aa91-5834-2c03-f455-f1d3d666fec7@intel.com>
 <MW3PR12MB4553E65A5D5DE6E27045766595729@MW3PR12MB4553.namprd12.prod.outlook.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <MW3PR12MB4553E65A5D5DE6E27045766595729@MW3PR12MB4553.namprd12.prod.outlook.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?amJBdmtNR25VUG1GUktvdTBmSHA0TTc1QlF3S3NSQ2hXL0o3SGtxMUhXZ0tZ?=
 =?utf-8?B?bHFLSCtsaVMvK2VqUEpKRkFUUVVIYUFieE1ERGwxTnJYOHptUlJiZEQ0ZEY5?=
 =?utf-8?B?K294SmsyZCs5RTVQN2J5NkV6RndIc3dGNUpUK2M5UTlvUHdZOWpEdE9seCs3?=
 =?utf-8?B?Wit4aXBrRUlkeEhJM3VMREM4MkpyL3p1ZE5DSzRFRHYrOEYzaFdINlhkandY?=
 =?utf-8?B?NjRTZk9ZZHpmQzc3OWdjeFlIUEE0NGlZZzEyWURVbGRKbTBoRUNDSjlxVEpR?=
 =?utf-8?B?U2YzZ2sxY2ViTHFaWUNub3pvZ1RkS0VMaFFTd013dWxLTXRMKzRpU2hwWE5t?=
 =?utf-8?B?dkt6Mm40cFVkdDVPQUxiSnVsZHdUZzVsZm9nVG91aHNiOExtRTJvR0pwMnRq?=
 =?utf-8?B?dC9HbmpEdDVoeVJvcnRkWmsxRW9xZUorcHk0MDRlQ2JHcWVIeDRTTlhTRnFs?=
 =?utf-8?B?RGx1OUtPNTYvd2hTS3VGT3dPczV5T0FjRlpJQXF5MkVFSDBDMTcvanM4YlRr?=
 =?utf-8?B?OWVGVUFGejU2dlUyN2kwUE14clVsM0FZaXdnWEZjSzdKaUF4cU5tNnFKazZa?=
 =?utf-8?B?UktORmc4U2hVVng2a2ROVFNlazI1aWovY2pYZ3daVUxIUmQxNDFjV2g3azNE?=
 =?utf-8?B?aFhLMlNFMXBJM3NpMjBLYVc3NHdLeUxqcnJjY1haU2hJK01jSXIwZHV1TjVJ?=
 =?utf-8?B?YXdSSGtoWWRUOHczemxIbnI2YmxOcHdFdXlPN0Z4b3ZjNEFjbFI4QmRYTTRU?=
 =?utf-8?B?dnlMQ1A2VXg1MFZKbmhaUG1xayt0S3NNZWxzRHJrRlkvSUVXdWJoR1M5bjkr?=
 =?utf-8?B?RExBcW5hQjRyVCtJQlp6UmhlS3dpNG5RNTQ0OUtYTTFqbzlPcFNycVdtNTJa?=
 =?utf-8?B?bVk3alFscVU3OG1QdXc4d2s4bjI2cWp3RTJrV01TSjZteXpWaWJIYU5vWkNk?=
 =?utf-8?B?VTU3UXlQZU8yQ240RHFQS2NwZ1g3NVdvYVRsTkhKczhBbXdkTEh3WmE1U0F5?=
 =?utf-8?B?QkkycVovZUt5cXRkV3ExSnpuc21sSDVvcUZGa25heGRhTzFhbm1XQy9RSDg5?=
 =?utf-8?B?Y0tOWHRxSzRVaENjWW1BcXhyWG9paWVaUmtTNmh1QmJDbTNaZUYzU09VeXQz?=
 =?utf-8?B?NXM5Zkd3QnArYUJsTnpNczF5SDN5Q2R5UzZNeG05TUx0eTAzR0Nnb294TllJ?=
 =?utf-8?B?QTU2Wk93SXErZGlRRUxURkpXTlJFd0N0dU9sOU4xNnZ4TUhsa0UxcTdxdTV4?=
 =?utf-8?B?ZGJvUm1tem52bFNKZ2ZLTGFuR2RidFdsZU5aNitLcHV0Z2U2bHhuTmpuSWdT?=
 =?utf-8?B?SlFBWVJOQ3dYays2T0hBUnI1elZQY1FLNmljNlF6RDBuTkRsNWhVTU9qOFBi?=
 =?utf-8?B?aWJHcWhWR1JsUXhpRCtLc3Q3anlIUGdPVEpHTFlkMEUwSGR6OG5icHhzdVpE?=
 =?utf-8?B?MmdMTEpaT0RDVENPV3hqL0FWbFBJVFFubTZiSS9Lb0dabXJMS0ZmbFoySmtz?=
 =?utf-8?B?RSs1YVpMdFlvcDFKZlZZS3lwcVhDQ0hYYkQrOWZ4M1VoRHA4RktiKzRvZGpS?=
 =?utf-8?B?UzFTS2hVTFhLT3NyK2kvZDdMNFp1bDM2cmM3OTFMemxGd1RXSGxRNDgzeHl0?=
 =?utf-8?B?ZnE0OUdZN2tnbDVlSlR4WHFSdGhJbCtlT2pHTCs4SS9DbnVTWk9DY3ladVVB?=
 =?utf-8?B?QjV0ZFdCendiRWJZMGdNVWwrZWc4c3BEVGcyNlhhUitJTzlDM0hLczkwWHpW?=
 =?utf-8?B?NnVvSExwcWJ6bW9hRHpiU3RWTWdQTEp3VDBwYURreHYrcUhBVE4vNHNwOWZG?=
 =?utf-8?B?WjdIMDBrMmR2QmREcTdIZ05udDFTN1AybXRtaWY4Q2ZBRnJwaVJtb2xpQzRU?=
 =?utf-8?B?T1ZEaFU2eVU5aStRNHl2Wjd4YzFRUHJKaGZBYUxMRkhRV3cyUE9YWDZ2ZkIw?=
 =?utf-8?B?RTdSRFZmU2l2TTBiM3kxNzd6dk1KN0NicVFlRWF1dGZvMDlZeWt6YU5mSS9L?=
 =?utf-8?B?UnRGeDBseFFGcHBCLytZcWQ4UEtUMFhTcVZKYUVHakd1Nk5uRmlTd0pKeE9h?=
 =?utf-8?B?OXp0eTdHbmg3OHQ5eVpwU0owVVNJQUI5KzN0VGE4dm5OSFN4VWdhYTZNL2hN?=
 =?utf-8?B?M3JHREN1SkNMSEJUdm42NjdnMUJMMjRiUXpXb0I0K2ZHUWcyT3NmeTFaeDg3?=
 =?utf-8?B?M1E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 08cc7d64-ca47-441c-6d93-08db4d9a1bfa
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2023 18:54:09.4443
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6yA7iwQ5mL83L06BXkE0vpMRvsWj3KoT24odIctSd5Y8yI1UsNU8jJY72qyOsh1NiiUuGulNAmffWVDfQFHRbNc4jTYrKp5SKQDyrhbEhGc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR11MB7354
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-8.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Babu,

On 5/5/2023 11:31 AM, Moger, Babu wrote:
> [AMD Official Use Only - General]
> 
> Hi Reinette,
> 
>> -----Original Message-----
>> From: Reinette Chatre <reinette.chatre@intel.com>
>> Sent: Thursday, May 4, 2023 1:59 PM
>> To: Moger, Babu <Babu.Moger@amd.com>; corbet@lwn.net;
>> tglx@linutronix.de; mingo@redhat.com; bp@alien8.de
>> Cc: fenghua.yu@intel.com; dave.hansen@linux.intel.com; x86@kernel.org;
>> hpa@zytor.com; paulmck@kernel.org; akpm@linux-foundation.org;
>> quic_neeraju@quicinc.com; rdunlap@infradead.org;
>> damien.lemoal@opensource.wdc.com; songmuchun@bytedance.com;
>> peterz@infradead.org; jpoimboe@kernel.org; pbonzini@redhat.com;
>> chang.seok.bae@intel.com; pawan.kumar.gupta@linux.intel.com;
>> jmattson@google.com; daniel.sneddon@linux.intel.com; Das1, Sandipan
>> <Sandipan.Das@amd.com>; tony.luck@intel.com; james.morse@arm.com;
>> linux-doc@vger.kernel.org; linux-kernel@vger.kernel.org;
>> bagasdotme@gmail.com; eranian@google.com; christophe.leroy@csgroup.eu;
>> jarkko@kernel.org; adrian.hunter@intel.com; quic_jiles@quicinc.com;
>> peternewman@google.com
>> Subject: Re: [PATCH v4 2/7] x86/resctrl: Remove unnecessary rftype flags
>>
>> Hi Babu,
>>
>> On 4/17/2023 4:34 PM, Babu Moger wrote:
>>> Remove unnecessary rftype flags to avoid multiple indirection.
>>
>> Could you please elaborate what makes these flags unnecessary?
> 
> Yea. Probably should not say unnecessary.
> How about this ?
> "rftype flags have two prefixes, RFTYPE_ and RF_. Remove the flag names with suffix RF_ and avoid indirection."

I do not think that having a different prefix is a motivation
for a flag to be removed. Having a different prefix could
rather be a motivation for a flag to be renamed to a consistent
name.

Could you please describe the problem being solved?
That will help to clarify if this patch is really needed.

Reinette