Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp1331219rwr; Fri, 5 May 2023 12:23:13 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6Tjip/ncStU8MkC/cCKIFgOB1RuVjtqKPEtqgOLcZTjGDkj2/xULiY43Gd0Yw/hY46DrMR X-Received: by 2002:a17:902:db04:b0:1ac:2b37:5ac1 with SMTP id m4-20020a170902db0400b001ac2b375ac1mr3354482plx.6.1683314592912; Fri, 05 May 2023 12:23:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683314592; cv=none; d=google.com; s=arc-20160816; b=v8uNAqJsTnmNkg55sDZaLBcr/gbNHzYuyFTXSDGh8Vm5ZRiy5uzR72RYAbEXIghp+G Su5RzbUq9sNYV1+KjILZrTyaWo0K6Y+/RU1abI2Eq69Gz2w/+w4qCVt/55DLJwP6QAem zoAUcFFCyODPvh/Y3YbwPnHuEdxjhq/lO+7BnYEItisQwNAlDDwQ5PL2iG/UJLGcA4uS JdqZfyYnTRs5T+9DWrJV2/XrSlg09FtB0cuU8WCAzyi90Tl1HvqlMVneqoA2nsHifa+2 blag53e2izbbadKyPiGiXtyQKkmmbyUOnlfe0+GIlJ+XaqgaoVpBpvlBgA3cYvzbWEYr aj7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=J6qpJoeN4x75NBrNew76I60iAgZx44rhp8h3k3ui3xw=; b=vvtIHevRyfbAOSNuVaanUtY+04sFJqKM2e5yfgDehNiBVxB1M8CJJ33p5IF6+9EplV OrYTUC2+SvUpwu8VTiAppTbz8PoRSdEMJA+DBmEXQ3zHlkomW7H0z+X+xWR9Lb5SvN1Y QxLDGbimFA7QneRPUzK6a4HjDskVQ9Yjuzc3HI4asLlcIa4dpd49hp1LJlsj3QA5ThJS rSyQR49WFWh717WnMhrzV3NRqxJ6yA63suG5cN3G4MKiQKoQaI6cMNGl2lo3VTpXK3NL uJcQRfKGC6UyIpB6Ncwb/xfPiSkuUhSsvb/MQZYjS8JQK6+Wv0ExPkA6llFC9AblWhBm qpWg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=GiVZFooZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t12-20020a170902e84c00b001a6e1b073cdsi2420288plg.639.2023.05.05.12.22.58; Fri, 05 May 2023 12:23:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=GiVZFooZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233051AbjEETOG (ORCPT + 99 others); Fri, 5 May 2023 15:14:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45862 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232979AbjEETOE (ORCPT ); Fri, 5 May 2023 15:14:04 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7D5198A65 for ; Fri, 5 May 2023 12:14:03 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 18A22612ED for ; Fri, 5 May 2023 19:14:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 16A1CC433EF; Fri, 5 May 2023 19:14:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1683314042; bh=4jYgePMhwPc9Dims/nrzw+Gr6MqL3fFrp9uR0NeldDU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=GiVZFooZFKlm2eBJ0yl4stLGsdbaO2zL2nrnRdvEQs9gHL01jH8OQ6UAtGJgJwO9D 7tomHzm2P1nqxq4MS9PnfoFA9HbaCA+yeRynxD1pBTVwhekwj2TaStxdJ/mBFDqvRe VVsf7Eo5rFMN7rZwmoUdOwmQp8npdCzWp+hKnARg= Date: Fri, 5 May 2023 12:14:01 -0700 From: Andrew Morton To: Nhat Pham Cc: hannes@cmpxchg.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, minchan@kernel.org, ngupta@vflare.org, senozhatsky@chromium.org, sjenning@redhat.com, ddstreet@ieee.org, vitaly.wool@konsulko.com, kernel-team@meta.com Subject: Re: [PATCH] zsmalloc: move LRU update from zs_map_object() to zs_malloc() Message-Id: <20230505121401.31826e1251fb8792fe64f675@linux-foundation.org> In-Reply-To: <20230505185054.2417128-1-nphamcs@gmail.com> References: <20230505185054.2417128-1-nphamcs@gmail.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-11.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 5 May 2023 11:50:54 -0700 Nhat Pham wrote: > Under memory pressure, we sometimes observe the following crash: > > [ 5694.832838] ------------[ cut here ]------------ > [ 5694.842093] list_del corruption, ffff888014b6a448->next is LIST_POISON1 (dead000000000100) > > ... > > Suggested-by: Johannes Weiner > Acked-by: Johannes Weiner > Signed-off-by: Nhat Pham Am I correct in believing that we should backport this fix into earlier kernels? And that a suitable Fixes: target is 64f768c6b32e ("zsmalloc: add a LRU to zs_pool to keep track of zspages in LRU order)"?