Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <c1a309b0-3d29-151d-b1af-04d524cfbd83@amd.com>
Date:   Fri, 5 May 2023 15:40:51 -0500
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Reply-To: babu.moger@amd.com
Subject: Re: [PATCH v4 4/7] x86/resctrl: Re-arrange RFTYPE flags and add more
 comments
Content-Language: en-US
To:     Reinette Chatre <reinette.chatre@intel.com>,
        Babu Moger <babu.moger@amd.com>, corbet@lwn.net,
        tglx@linutronix.de, mingo@redhat.com, bp@alien8.de
Cc:     fenghua.yu@intel.com, dave.hansen@linux.intel.com, x86@kernel.org,
        hpa@zytor.com, paulmck@kernel.org, akpm@linux-foundation.org,
        quic_neeraju@quicinc.com, rdunlap@infradead.org,
        damien.lemoal@opensource.wdc.com, songmuchun@bytedance.com,
        peterz@infradead.org, jpoimboe@kernel.org, pbonzini@redhat.com,
        chang.seok.bae@intel.com, pawan.kumar.gupta@linux.intel.com,
        jmattson@google.com, daniel.sneddon@linux.intel.com,
        sandipan.das@amd.com, tony.luck@intel.com, james.morse@arm.com,
        linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
        bagasdotme@gmail.com, eranian@google.com,
        christophe.leroy@csgroup.eu, jarkko@kernel.org,
        adrian.hunter@intel.com, quic_jiles@quicinc.com,
        peternewman@google.com
References: <168177435378.1758847.8317743523931859131.stgit@bmoger-ubuntu>
 <168177447844.1758847.17789021842152864417.stgit@bmoger-ubuntu>
 <67e00f1e-bbb2-59b6-fe34-758d5b268324@intel.com>
From:   "Moger, Babu" <bmoger@amd.com>
In-Reply-To: <67e00f1e-bbb2-59b6-fe34-758d5b268324@intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?U2MrZDVzVXRPcXNIVXhjYXFobnl6c3BPU3dGU25uZU0rYkQvK1BiTXhKc2VO?=
 =?utf-8?B?UStBMXljWDBQZGNibzBIZzZpTkRjcFNsL0wwaDZ6cUd1QVMzeDRscHQvdkIr?=
 =?utf-8?B?YmtyeGUydkhiQnBSLzIwcHNHN25iNytyNGQ3Y2JycXkxMmZqN3NyYStXMVRB?=
 =?utf-8?B?YXAxNnMyWEdyZmpTRkNTRDBVOXUrTFJLZlZ2RVR1TXFDNm85U0xvUmswWjJz?=
 =?utf-8?B?SXZlbjFJTkFjOG05Z3UyNytydkU0a1JBUy9HNlFkYk9BWVVVT2pISGZpZkZp?=
 =?utf-8?B?K0U0UHRUNXZvU09yMVNlZWdLaGVhTDBBYlB2cUk3YkNFcCtENWtmK3Q4a2Z3?=
 =?utf-8?B?ekdlRUVNNERzL29hbDVJT0l5ZTNpdHRiQnNzbzNrYUlnekZrUG12am1tQmpZ?=
 =?utf-8?B?QkNveWg0eVhNZEVLOWxxK1ZPTXdVRlJWM25NcVdYMTMzQy9VcVdxVWlsSlhS?=
 =?utf-8?B?WFE2SXN6ako3Z3VwZlpQV0VUZ3VwbmMrTm5ZRDdUUlZBS1FhaUZrL0NlckMz?=
 =?utf-8?B?UEtZcmlkUGg2TGdvSVpQeXNteVByeC9CMThjdTdVVnhUem9sWmNTUWZZT1hN?=
 =?utf-8?B?Q095UWkyTUVIWXI3dXJ0bStRYjZwdEJqQ0YyTTZQUFZhVGN5VWNJVWNlN3lR?=
 =?utf-8?B?SS9ZbWFwQUh1OWZ2UEtWMC9VTFB6ZHdUYlE2NDMyUXFiWmNUaGlJckV6UjE5?=
 =?utf-8?B?MzNnZVJodHV2L3Z6VXYvYzE2bWlna08zNjRnVjBMWm5hNHZMSmtUNnJtTGl5?=
 =?utf-8?B?SVhSYXg3T1JLbTd3ZzlDU0Rob3B0SVYwNGxoWWhTaUZwSGg0OVNDQ3lvV2dZ?=
 =?utf-8?B?YkxFeHlOOE1DWGpDUmxsVGpJUFQ4bjFRaGxYTlRMKzRZUTdFc21vWWljcnlK?=
 =?utf-8?B?bDFDUCt2NXZIdGx6bjV6cHE3WjZKUzJCTGxRMCt2T0JteUYwb2dWT3JnOXBw?=
 =?utf-8?B?RlpXclkrUXJqcCtQaGp3cksrM0lrRmVzN0xwMENXYWFUTEJGc29hUTB0SWZO?=
 =?utf-8?B?aHEvekdGRkE2ZExzYTh0V3ljbHJlc2VCNDB1dEU0NTdwNTN6N05QUFlCeElR?=
 =?utf-8?B?c1plOG9RQld5cDhuVTMrMVNWdHJQNVpTWWNZZ3RlUXpuMkVlQ200QnB4aXJR?=
 =?utf-8?B?WHg4YjNJdzRTMlAyclF2ckIzREJEWlp1TzJTUHdLbXVqQlRMdFBYNGoxbGt5?=
 =?utf-8?B?Q0NrTzJsb2V3WXk0UEMxbllYQk1hYXo3YnQxRWlCNzdFdFdUNjQ1b0RONkdn?=
 =?utf-8?B?L0JKVDZlT3lGVTFIcnFrbjJmYWVRQzkzSUxKZThGRTZvNGlQMExJSlZsNG05?=
 =?utf-8?B?Zll2R2ZyM0x4NHpSRVNCYjl1c082bXpZZXUwU2RyT1R5M0FSREE1SlNDaE9o?=
 =?utf-8?B?TTQrUkI0WjAybEdZMnpaY2FKUjFHNDdveDd3ZDEzS1V3Ym1oZDhlNDRnNUho?=
 =?utf-8?B?ZjR1a3gxNjU3Y1ljUWc0NFVkVmwvNW14M2ZIaEJkSnFBdnJnVEpNZ0JXVUJs?=
 =?utf-8?B?RjRJZ0hjUUF3RGdBc0FHSWhaZU5Xb0tSN0ZkdWVwOTZROUtVMHVEWHRjZ1Jn?=
 =?utf-8?B?cUlQaVZqd3loK0VIaGtXd044T2wyQ1N2ZUxBTFFNSWlmaFMvOFRBQUQ0QWlS?=
 =?utf-8?B?SytQNmRWUjhaTXRtcjUzOXArVmh1ZElPYUdHMEVJRkpyR3dvWHpOYmZ3VTFR?=
 =?utf-8?B?U0dmZDlUWndQcDJYZW5KcHMva1dsL3N2Zzk5eEZlcER4RS90WXZwWHFXQmdk?=
 =?utf-8?B?RU9MSkZpUHdGOU5YSUY2MW9wbk12NUJuMEFzSnFrTmErMnlCZ2h6bFFPNkl4?=
 =?utf-8?B?M25kbnRMZmZ5c3Z1Ri9ZVmZ3THZsd0xhenJFNVZCUnpLcmIrY3lIWU01a0w2?=
 =?utf-8?B?NjlPZTc2d1VZVHpRYXJBY1R5Tk9RRVZLREl6Y3lGQ1ZtSHJwZUdIekwyVkxX?=
 =?utf-8?B?VGliNlRVZWxlRzQ3eDU2UlU3THdJb3loTWZNRG5zN2hKanlrTWM3Z0tJK05L?=
 =?utf-8?B?eHhwVFFxakRoRHFKM0s3ajZaMEhDZEtpQ1lNTXpzcjc2MHFLYk5aN0I3S2J6?=
 =?utf-8?B?MWh0MHgydERQTlJ0eDhmSndQTEVUYmU0QnhFbWVmQlBoVEd5ajE2MllqZUVj?=
 =?utf-8?Q?0jqX5BaCi55KA6RYBietHcpWx?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 240c152b-8d25-4035-246b-08db4da90847
X-MS-Exchange-CrossTenant-AuthSource: MW3PR12MB4553.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2023 20:40:58.9079
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: epSvtu2sPC1Q5/4Y4Ck6atEjuPDyjHVLyKKCv2y9LtCRyjqFrl/f1JSttgpJQMOj
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4513
X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Reinette,

On 5/4/2023 2:00 PM, Reinette Chatre wrote:
> Hi Babu,
>
> On 4/17/2023 4:34 PM, Babu Moger wrote:
>> Remove gaps in bit definitions of RFTYPE flags and add more comments
> Why is it necessary to remove gaps in the bit definitions?

Removing the gaps is not necessary definitely. I thought adding comments 
will help adding new flags in the future.

If you want me to drop this whole patch, I am fine with it.

Thanks

Babu