Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230505204119.3443491-1-irogers@google.com>
In-Reply-To: <20230505204119.3443491-1-irogers@google.com>
From:   Namhyung Kim <namhyung@kernel.org>
Date:   Fri, 5 May 2023 13:54:33 -0700
Message-ID: <CAM9d7cifodHyFJHmfSCBBTocab1GbvzoebLQRbf4vjYJHJWb+g@mail.gmail.com>
Subject: Re: [PATCH v1] perf metrics: Fix segv with --for-each-cgroup
To:     Ian Rogers <irogers@google.com>
Cc:     Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@kernel.org>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Kajol Jain <kjain@linux.ibm.com>,
        linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Precedence: bulk

On Fri, May 5, 2023 at 1:41 PM Ian Rogers <irogers@google.com> wrote:
>
> Ensure the metric threshold is copied correctly or else a use of
> uninitialized memory happens.
>
> Fixes: d0a3052f6fae ("perf metric: Compute and print threshold values")
>
> Reported-by: Namhyung Kim <namhyung@kernel.org>
> Signed-off-by: Ian Rogers <irogers@google.com>

Thanks for the fix.  Now it runs ok

  $ sudo ./perf stat -a --bpf-counters \
  > --for-each-cgroup user.slice,system.slice sleep 1

Tested-by: Namhyung Kim <namhyung@kernel.org>

Thanks,
Namhyung


> ---
>  tools/perf/util/metricgroup.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/tools/perf/util/metricgroup.c b/tools/perf/util/metricgroup.c
> index 4b9a16291b96..c566c6859302 100644
> --- a/tools/perf/util/metricgroup.c
> +++ b/tools/perf/util/metricgroup.c
> @@ -1730,6 +1730,7 @@ int metricgroup__copy_metric_events(struct evlist *evlist, struct cgroup *cgrp,
>                                 return -ENOMEM;
>
>                         new_expr->metric_expr = old_expr->metric_expr;
> +                       new_expr->metric_threshold = old_expr->metric_threshold;
>                         new_expr->metric_name = strdup(old_expr->metric_name);
>                         if (!new_expr->metric_name)
>                                 return -ENOMEM;
> --
> 2.40.1.521.gf1e218fcd8-goog
>