Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 5 May 2023 15:55:58 -0500
From:   Rob Herring <robh@kernel.org>
To:     Anup Sharma <anupnewsmail@gmail.com>
Cc:     lgirdwood@gmail.com, broonie@kernel.org,
        alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
        KCHSU0@nuvoton.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: dt-bindings: nau8540: Convert to dtschema
Message-ID: <20230505205558.GA3544888-robh@kernel.org>
References: <ZE9rK6mktPByvRRz@yoga>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZE9rK6mktPByvRRz@yoga>
Precedence: bulk

On Mon, May 01, 2023 at 01:02:59PM +0530, Anup Sharma wrote:
> Convert the NAU8540 audio CODEC bindings to DT schema
> 
> Signed-off-by: Anup Sharma <anupnewsmail@gmail.com>
> ---
>  .../devicetree/bindings/sound/nau8540.txt     | 16 --------
>  .../bindings/sound/nuvoton,nau8540.yaml       | 40 +++++++++++++++++++
>  2 files changed, 40 insertions(+), 16 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/sound/nau8540.txt
>  create mode 100644 Documentation/devicetree/bindings/sound/nuvoton,nau8540.yaml
> 
> diff --git a/Documentation/devicetree/bindings/sound/nau8540.txt b/Documentation/devicetree/bindings/sound/nau8540.txt
> deleted file mode 100644
> index 307a76528320..000000000000
> --- a/Documentation/devicetree/bindings/sound/nau8540.txt
> +++ /dev/null
> @@ -1,16 +0,0 @@
> -NAU85L40 audio CODEC
> -
> -This device supports I2C only.
> -
> -Required properties:
> -
> -  - compatible : "nuvoton,nau8540"
> -
> -  - reg : the I2C address of the device.
> -
> -Example:
> -
> -codec: nau8540@1c {
> -       compatible = "nuvoton,nau8540";
> -       reg = <0x1c>;
> -};
> diff --git a/Documentation/devicetree/bindings/sound/nuvoton,nau8540.yaml b/Documentation/devicetree/bindings/sound/nuvoton,nau8540.yaml
> new file mode 100644
> index 000000000000..ac344e435a5c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/nuvoton,nau8540.yaml
> @@ -0,0 +1,40 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/sound/nuvoton,nau8540.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Nuvoton Technology Corporation NAU85L40 Audio CODEC
> +
> +maintainers:
> +  - KCHSU0@nuvoton.com, broonie@kernel.org

Not the right format. It's one email per line/entry.

It needs a name too and drop Mark. It's who knows the h/w, not who 
applies patches.

> +
> +allOf:
> +  - $ref: dai-common.yaml#
> +
> +properties:
> +  compatible:
> +    const: nuvoton,nau8540
> +
> +  reg:
> +    maxItems: 1
> +
> +  "#sound-dai-cells":
> +    const: 0
> +
> +required:
> +  - compatible
> +  - reg
> +
> +unevaluatedProperties: false
> +
> +examples:
> +  - |
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +        codec@1c {
> +            compatible = "nuvoton,nau8540";
> +            reg = <0x1c>;
> +        };
> +    };
> -- 
> 2.34.1
>