Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <8d3cb414-88df-4c89-7dfc-6e598501d722@intel.com>
Date:   Fri, 5 May 2023 14:24:08 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.10.1
Subject: Re: [PATCH v4 4/7] x86/resctrl: Re-arrange RFTYPE flags and add more
 comments
Content-Language: en-US
To:     <babu.moger@amd.com>, <corbet@lwn.net>, <tglx@linutronix.de>,
        <mingo@redhat.com>, <bp@alien8.de>
CC:     <fenghua.yu@intel.com>, <dave.hansen@linux.intel.com>,
        <x86@kernel.org>, <hpa@zytor.com>, <paulmck@kernel.org>,
        <akpm@linux-foundation.org>, <quic_neeraju@quicinc.com>,
        <rdunlap@infradead.org>, <damien.lemoal@opensource.wdc.com>,
        <songmuchun@bytedance.com>, <peterz@infradead.org>,
        <jpoimboe@kernel.org>, <pbonzini@redhat.com>,
        <chang.seok.bae@intel.com>, <pawan.kumar.gupta@linux.intel.com>,
        <jmattson@google.com>, <daniel.sneddon@linux.intel.com>,
        <sandipan.das@amd.com>, <tony.luck@intel.com>,
        <james.morse@arm.com>, <linux-doc@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <bagasdotme@gmail.com>,
        <eranian@google.com>, <christophe.leroy@csgroup.eu>,
        <jarkko@kernel.org>, <adrian.hunter@intel.com>,
        <quic_jiles@quicinc.com>, <peternewman@google.com>
References: <168177435378.1758847.8317743523931859131.stgit@bmoger-ubuntu>
 <168177447844.1758847.17789021842152864417.stgit@bmoger-ubuntu>
 <67e00f1e-bbb2-59b6-fe34-758d5b268324@intel.com>
 <c1a309b0-3d29-151d-b1af-04d524cfbd83@amd.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <c1a309b0-3d29-151d-b1af-04d524cfbd83@amd.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Ung5enMyWHVKSE4zQWxOcjZKUi9UeWFlb0UybnkxUEN3SHlyNzdIU2czM0xR?=
 =?utf-8?B?bXhvdmZQMjRkVzNWd3FubzY4WmxLNzBIUjZmaVJkZzh4WnpDZWt6NU1DblFU?=
 =?utf-8?B?VE9xUVI2bTFYcU9NZ1p0SXlIM3JXRGNKYmFmWEJQYmZsa1Ixd2QxS1dGVlhN?=
 =?utf-8?B?TlZxM1U0SXF1R3RxckZNM0FxU3V6VmRMTmZOM2NtZUdORmtveWlCcjNJelBk?=
 =?utf-8?B?NnUxQ0hSVFRPV3hxdmZzanFqUGl1cDBQRml2dEQ3bFVCTzRsUGh6bE4vaWhC?=
 =?utf-8?B?Z2JOTmNxV1o2TTIzb05tdzlWVlQxV0ZTRXhudVdSYXpuTk84Z3ZTSlM5QkhG?=
 =?utf-8?B?ZUZWSkhIUXZndjRCdGczZHpPcDdYS3BuMU9VWWdiVXkzR1dyUjRBSnpWNmxn?=
 =?utf-8?B?TGR1NWlUYjh3RG1DZXFFZ1FRdEZVWEhic250WklONG0weFh6d0FPOGwrdDha?=
 =?utf-8?B?aXVYVmxjZDduQ0hGU3pnRDR4KzMvRG9qRUFKZEljakpjekRQVkRwSm1xK2tN?=
 =?utf-8?B?QTA0dkx5VU5wdGtFQlBYZ1p6Q1pBN004UnFXcmZjV1RXZGhLSjNUZGU2ZDJ1?=
 =?utf-8?B?dis1T0VXZUtPek1mZzhET2tMQ1dCSE9kUUVoUGc2djRJdkwzVThvdHJRdkh6?=
 =?utf-8?B?U25FNi9JU21TYnNZcytySmdHdTZHRVB6eXhVdzM2NU1wWm5wcWF1ZG05RHlD?=
 =?utf-8?B?UXJreUdlMFFsTzlVR09UeGlpWnBBWERjN3RrdUVkTWpSQ2tlRVpHU3RCNGZP?=
 =?utf-8?B?VEQvR3ZzazBJM1poSFE4ZkJtSGxpTHFyazlrQ2duME9hR1Nzbjk2ZHlTUkRm?=
 =?utf-8?B?d3M1NjhoSXh6MDk5YldEZ0dpT2U0MHB3SlNicGZXWUJJUUxGSUxVSUtwRFZN?=
 =?utf-8?B?SG0wRUY5NWF3YzBQQzF1V2JoZ3pJT0tmcFcrckI4dHh0MW1FQmQ5azVRMlpo?=
 =?utf-8?B?bWJnVnBvdlp2SGN0NG40Q2pZSzF4QjRRTXh2cWVoeUVmMTdybk10WmVod2Vs?=
 =?utf-8?B?RlY3MHlreVRtOXQ2U1pyUnMvYjF6N0RrMDFCdkw1Ym1NZlYvd2RDSTZiUnBs?=
 =?utf-8?B?QzkvV2JIUHQrekVRbCtWVWlhcXVBZXY5Um9VSEtzWU16Q1RzSlBJb0ZqbWdu?=
 =?utf-8?B?UEtTSzdES2kwRUdmL1Jma1RrQUQ2bmUyajNuUGZzT1pkSXphZzJlS3FYQVJK?=
 =?utf-8?B?UkkzTmswM2c3QjgzZ2tWK0RnaGdzTms2MDNrb1MyMVZkSzc5NU90VElySnU0?=
 =?utf-8?B?eDlyQytPS0x0N3FEcWdUR2dSZWh2WG9tdWtadE1NaTNZWGV3azNxWVF6TWFV?=
 =?utf-8?B?SjVZcUVpN011MFI2UDN1LyswMWM3WDkvaERCQjJHS3RZaFhQeC9WMEwxcjdP?=
 =?utf-8?B?Vk5ETDJlK0VSdno2RXR4MUlIMmVmeUhxU2c3cmRDRExNT01NM1hGUUxmeWRE?=
 =?utf-8?B?c3ZwM0hxWmNYN2JwMCt1eFU0OWw5eWZ1T3g5UEM4QUlmZDZjVzNjSkhySHlu?=
 =?utf-8?B?NjE2NXV2Sm1Va21XYzZhZEJja21WM0FBOUZxVVE1WG43QnowSjR5Uk91TTJr?=
 =?utf-8?B?VmcxQ3oydEU5TXBqN3VyQTV1MkNweEF0TWZCQ0pmeURVSStockNoaDcvTmhu?=
 =?utf-8?B?eTRBRmpIcDZOTVNKWlYxMzgycm4vVW5YYWF3b3N1dkc5dVJERmpsQ2hmWldn?=
 =?utf-8?B?MnpLeVlhRzJmYjQwOElyVjhDb2V3bzE2bVVvTWsrTkNNaytaRTIxdTFVYko2?=
 =?utf-8?B?QXVmeXNUR21XRFF0UzB1UFFydENTT2hXQk1yWnlDTmkrS0ZMbzVJNVdBbDc0?=
 =?utf-8?B?RmxaSHRmS1VQYzZQd05pTXdJWjF6KzlxZlFHeG5tZ2tUVGhqNXo0MVNxeW5G?=
 =?utf-8?B?Rk9WUjFYdm9DVFJYNlh1eXJraTlRQVhDNzF1MFZ2MmJkZzZON1BONkFKeXVD?=
 =?utf-8?B?UVlZVS9Na3FmaTJNQmRvTFphR3NGQmFoV2gxSGhKWXQ4WUtDZTBGNnBUNVNU?=
 =?utf-8?B?Uk1Yb09qSkNxaUVpRUc4NlZ2bGFmdVF4Z0hjVGg2b0owc290L2l6TW5QNGNi?=
 =?utf-8?B?YnB0OXMvU3JTZXk1ZFhFdTNna1NpVUlnTGdTOUdBK0Z5R0Q5dW4vaTVycS9C?=
 =?utf-8?B?YXk1emtyVE56L3NpUytTNXdEeGY4VGZVWUtnNERwRXBoVVQ3K0poc29hb1M2?=
 =?utf-8?B?VWc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: e8a2255b-4b33-4cf3-11a0-08db4daf11c1
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2023 21:24:11.7794
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: NZG1jWWBruPIunJ/thqMaLsy61dg28wvGZSd4mnwqXPWm2ICdeXiqGGFPdmtkr4uJnG3oIz4WIacnqioeeBsIpdt95KL4zSnd8ogAFqJYOU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5830
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-8.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Babu,

On 5/5/2023 1:40 PM, Moger, Babu wrote:
> Hi Reinette,
> 
> On 5/4/2023 2:00 PM, Reinette Chatre wrote:
>> Hi Babu,
>>
>> On 4/17/2023 4:34 PM, Babu Moger wrote:
>>> Remove gaps in bit definitions of RFTYPE flags and add more comments
>> Why is it necessary to remove gaps in the bit definitions?
> 
> Removing the gaps is not necessary definitely. I thought adding
> comments will help adding new flags in the future.
> 

I agree that removing the gaps are not necessary.

> If you want me to drop this whole patch, I am fine with it.> 

The comments may be useful. If you decide to keep it please review
it for consistency. The comments should not increase confusion.
For example,
* in one instance you refer to "info" and "base" as components, in
  another you refer to them as directories, which is confusing since
  there is a "info" directory but no "base" directory.
* related to previous item, the comments start by referring to the
  "info" and "base" components but then the comments switch to
  describing a "info directory structure and "group structure"
* the separator (---) is used above a header in one instance and
  below a header in another
* in some places you use the syntax:
	--> <flag name> (<dir name>, <dir name>)
  in other places you use:
	--> <flag name>
	   --> (<dir name>)
	   --> (<dir name>)

Reinette