Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230505074701.1030980-1-bigunclemax@gmail.com>
 <20230505105805.548d1a1b@donnerap.cambridge.arm.com> <CALHCpMi8=t1bMceTOfZjh7aKEQcEEpfeG4wi9pB=5o34Ca+N3w@mail.gmail.com>
 <20230505170015.664c18bc@donnerap.cambridge.arm.com>
In-Reply-To: <20230505170015.664c18bc@donnerap.cambridge.arm.com>
From:   Maxim Kiselev <bigunclemax@gmail.com>
Date:   Sat, 6 May 2023 01:25:02 +0400
Message-ID: <CALHCpMiwqkMRV2Nv0sKG8ZD2D6jbjVaB6_jcShf6hMBUP3D3Dg@mail.gmail.com>
Subject: Re: [PATCH] riscv: dts: allwinner: d1: Add SPI0 controller node
To:     Andre Przywara <andre.przywara@arm.com>
Cc:     robh+dt@kernel.org,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
        Jernej Skrabec <jernej.skrabec@gmail.com>,
        Samuel Holland <samuel@sholland.org>,
        Paul Walmsley <paul.walmsley@sifive.com>,
        Palmer Dabbelt <palmer@dabbelt.com>,
        Albert Ou <aou@eecs.berkeley.edu>,
        Cristian Ciocaltea <cristian.ciocaltea@collabora.com>,
        devicetree@vger.kernel.org, linux-riscv@lists.infradead.org,
        linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev,
        linux-kernel@vger.kernel.org, icenowy@outlook.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

> Can you please try these patches, and use:
> compatible = "allwinner,sun20i-d1-spi", "allwinner,sun50i-r329-spi";
> for the compatible string?

I tested my patch (with compatible prop changed to
allwinner,sun50i-r329-spi) on top of these patches and it works fine
for me.

> If possible, you could revive this series, and add the D1/T113s support on
> top: just add the compatible string combo to the binding document.

Just one question. Should I do it now, or is it better to wait while
Icenowy Zheng finishes work on the next revision of this series?