Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e21f2ca92490d9efd8f8fad0679d05ef08a52147.camel@linux.intel.com>
Subject: Re: [PATCH 2/6] sched/fair: Check whether active load balance is
 needed in busiest group
From:   Tim Chen <tim.c.chen@linux.intel.com>
To:     Peter Zijlstra <peterz@infradead.org>
Cc:     Juri Lelli <juri.lelli@redhat.com>,
        Vincent Guittot <vincent.guittot@linaro.org>,
        Ricardo Neri <ricardo.neri@intel.com>,
        "Ravi V . Shankar" <ravi.v.shankar@intel.com>,
        Ben Segall <bsegall@google.com>,
        Daniel Bristot de Oliveira <bristot@redhat.com>,
        Dietmar Eggemann <dietmar.eggemann@arm.com>,
        Len Brown <len.brown@intel.com>, Mel Gorman <mgorman@suse.de>,
        "Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
        Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Valentin Schneider <vschneid@redhat.com>,
        Ionela Voinescu <ionela.voinescu@arm.com>, x86@kernel.org,
        linux-kernel@vger.kernel.org,
        Shrikanth Hegde <sshegde@linux.vnet.ibm.com>,
        Srikar Dronamraju <srikar@linux.vnet.ibm.com>,
        naveen.n.rao@linux.vnet.ibm.com,
        Yicong Yang <yangyicong@hisilicon.com>,
        Barry Song <v-songbaohua@oppo.com>,
        Ricardo Neri <ricardo.neri-calderon@linux.intel.com>
Date:   Fri, 05 May 2023 15:29:45 -0700
In-Reply-To: <20230505121631.GF4253@hirez.programming.kicks-ass.net>
References: <cover.1683156492.git.tim.c.chen@linux.intel.com>
         <231cf298efb8627499bb42788588a6108c7b8f7c.1683156492.git.tim.c.chen@linux.intel.com>
         <20230505121631.GF4253@hirez.programming.kicks-ass.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4 (3.44.4-2.fc36) 
MIME-Version: 1.0
Precedence: bulk

On Fri, 2023-05-05 at 14:16 +0200, Peter Zijlstra wrote:
>=20
> > +static inline bool asym_active_balance_busiest(struct lb_env *env, str=
uct sd_lb_stats *sds)
> > +{
> > +	/*
> > +	 * Don't balance to a group without spare capacity.
> > +	 *
> > +	 * Skip non asymmetric sched group balancing. That check
> > +	 * is handled by code path handling imbalanced load between
> > +	 * similar groups.
> > +	 */
> > +	if (env->idle =3D=3D CPU_NOT_IDLE ||
> > +	    sds->local_stat.group_type !=3D group_has_spare ||
> > +	    !asymmetric_groups(sds->local, sds->busiest))
> > +		return false;
> > +
> > +	/*
> > +	 * For SMT source group, pull when there are two or more
> > +	 * tasks over-utilizing a core.
> > +	 */
> > +	if (sds->busiest->flags & SD_SHARE_CPUCAPACITY &&
> > +	    sds->busiest_stat.sum_h_nr_running > 1)
> > +		return true;
> > +
> > +	return false;
> > +}
>=20
> This all seems to be mixing two 'asymmetric' things in the 'asym'
> namespace :/ One being the SD_ASYM_PACKING and then the above SMT/no-SMT
> core thing.

Yeah, I am kind of abusing the "asymmetric" word.  However, the above
code does try to set things up for the aysm_active_balance() code
later. Any suggestion on better names for "asymmetric_groups()" and
and "asym_active_balance_busiest()"?=C2=A0

Perhaps "hybrid_groups()" and "hybrid_active_balance_busiest()"?

>=20
> > +
> >  /**
> >   * calculate_imbalance - Calculate the amount of imbalance present wit=
hin the
> >   *			 groups of a given sched_domain during load balance.
> > @@ -10164,6 +10200,12 @@ static inline void calculate_imbalance(struct =
lb_env *env, struct sd_lb_stats *s
> >  			return;
> >  		}
> > =20
> > +		if (asym_active_balance_busiest(env, sds)) {
> > +			env->migration_type =3D migrate_task;
> > +			env->imbalance =3D 1;
> > +			return;
> > +		}
> > +
> >  		if (busiest->group_weight =3D=3D 1 || sds->prefer_sibling) {
> >  			unsigned int nr_diff =3D busiest->sum_nr_running;
> >  			/*
> > @@ -10371,6 +10413,9 @@ static struct sched_group *find_busiest_group(s=
truct lb_env *env)
> >  			 */
> >  			goto out_balanced;
> > =20
> > +		if (asym_active_balance_busiest(env, &sds))
> > +			goto force_balance;
> > +
> >  		if (busiest->group_weight > 1 &&
> >  		    local->idle_cpus <=3D (busiest->idle_cpus + 1))
> >  			/*
>=20
> All the cases here have a nice (CodingStyle busting) comment, perhaps
> add the missing {} when hou add the comment?

Sure, will add a comment here.

Tim